Commit Graph

4013 Commits

Author SHA1 Message Date
Treehugger Robot
63c6f707c4 Merge "Update deps for rmtypedefs and mkstubs." am: 99a9d7be5e am: d480253149 am: 4def7525c1
Original change: https://android-review.googlesource.com/c/platform/development/+/2287993

Change-Id: I7b340bcd5d29b33de2402947b630edf5e24544c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-05 06:01:12 +00:00
Krzysztof Kosiński
02fd031e00 Update deps for rmtypedefs and mkstubs.
Use Guava built from source and a newer version of asm.

Test: mm
Bug: 244341573
Change-Id: Ic061b6a9b801f1378fafb23e493f1d29c46b06fe
2022-11-04 19:25:41 +00:00
Kean Mariotti
b5a9158e35 Fix viewer screen recording
- Minimized <video> element would still intercept pointer events
- Original area occupied by ViewerScreenRecording component would always intercept
  pointer events, even after dragging the element somewhere else.

Test: npm run build:all && npm run test:all
Fix: b/238090772
Change-Id: I1dee45bada91e61c0a80495a9ec8ce16c73cbba7
2022-11-03 14:51:30 +00:00
Kean Mariotti
150a5378f3 Fix disappearing labels in SurfaceFlinger rects view
Test: open SF trace, scroll back and forth in time, check that labels don't disappear
Fix: b/254244305
Change-Id: I05129db8f5a7a5ee2dd42d7d685aac1588b8594c
2022-11-03 14:51:27 +00:00
Kean Mariotti
3a78e1fcdd Merge "Make CollectTracesComponent more responsive" 2022-11-03 14:47:35 +00:00
Cosmin Băieș
46b6825eb0 Merge "Refactor and simplify layouts and css styles" 2022-11-03 14:34:09 +00:00
Cosmin Băieș
649c56ebcd Refactor and simplify layouts and css styles
Test: npm start and check responsiveness to diferent screen sizes
Fix: 254047706
Change-Id: If89ffdf8d7edb9b82ebb392163b74bc650f62cb9
2022-11-03 13:34:54 +01:00
Kean Mariotti
1febe1caa9 Make CollectTracesComponent more responsive
Test: collect traces through ADB proxy and check that they are loaded more quickly
Change-Id: Ibecf18b354d702f6b956e24a95dbc9ceaaae9088
2022-11-01 13:57:53 +00:00
Kean Mariotti
32c8f58390 Fix handling of traces with no entries
Test: npm run build:unit && npm run test:unit
Change-Id: Ic715711c0f9971b8b6d5dfc7219e6c459e1a421e
2022-11-01 13:46:24 +00:00
Kean Mariotti
81bc9f49db ParserWindowManagerDump more robust to invalid input
ParserWindowManagerDump is prone to accepting invalid inputs because it lacks a magic number check.
This commit reduces changes of accepting invalid inputs by making sure that the parser is actually
able to create a trace entry from the decoded proto.

Test: npm run build:unit && npm run test:unit
Change-Id: I1aad12387ce064cde6e27e09cd6d329bb21f5066
2022-11-01 13:46:24 +00:00
Kean Mariotti
343b2f165c Fix UI change detection after trace collection
CollectTracesComponent used to correctly notify AppComponent through callbacks, but the Angular
change detection was not always triggered (no input change), AppComponent was not updated and the
UI would hang with the message "Loading data..." or would not respond to "Upload new" botton clicks.

This commit solves the issue by manually triggering the Angular change detection through
ChangeDetectorRef#detectChanges().

Fix: b/256602610
Fix: b/256766721
Test: start winscope and collect a trace through ADB proxy
Change-Id: Iddbcc6a29c5d5a502f294b4fc49295dc06c9f00b
2022-11-01 10:09:00 +00:00
Kean Mariotti
a34a33b8e7 Update tabs order
Different views (when available) are displayed in tabs with this order:
SF
WM
IME
Transactions
Protolog

Test: open winscope, load traces, check that tab order is correct
Fix: b/254043055
Change-Id: I5b08cc8cdb4c623552f7ad8a1ba693ebfefb4928
2022-10-31 13:39:36 +00:00
Kean Mariotti
a9286726c6 Fix accesses to undefined in IME viewers
Fix: b/255741990
Test: npm run build:unit && npm run test:unit
Change-Id: I555397d75b667890fb5c0d27af708db69deb8fe9
2022-10-31 13:24:19 +00:00
Kean Mariotti
d39a88a2c1 Fix log views not fully rendered
Fix: b/255966194
Test: npm run build:all && npm run test:all
Change-Id: Icb5c4c6064c6a2f3967ede5f251b337dc26dfec1
2022-10-30 18:31:58 +00:00
Kean Mariotti
5d96d3c955 Add screenrecording viewer
This change also needed and includes the refactorings listed below.

Extend viewer's interface to support overlay views:
viewers return a list of views that could have either "tab" or "overlay" type.

Extend TraceViewComponent to render overlay views as well.

Simplify TraceViewComponent's interface for simpler event handling:
receive list of viewers + callback as input instead of entire TraceCoordinator

Test: npm run build:all && npm run test:all
Fix: b/238090772
Change-Id: Iac4c7e66ebe662a76166318d045c2c35e689ef15
2022-10-27 18:16:10 +00:00
Kean Mariotti
bfb80775a6 Improve rects view code health
Fix: b/254244305
Test: npm run test:component
Change-Id: Iac424696b4351dc22c2f802d19aff6d7b029556c
2022-10-21 09:55:15 +00:00
Kean Mariotti
fe3458851f Improve rects view
- Labels have typography consistent with the rest of Winscope
- Fix labels position - get rid of fragile hardcoded x-axis shifts

Fix: b/251785717
Test: run "npm run start", load SF trace, check layers labels
Change-Id: Id32b31f3bf66e4096fedfb3369f6df479f4e0c47
2022-10-21 09:19:18 +00:00
Kean Mariotti
9815ff5c32 Remove blank space in properties view
- WindowManager viewer
- IME viewers

Fix: b/254437771
Test: load WM + IME traces in winscope, click on an entry in the hierarchy view, check that there is no blank space in the properties view between controls on top (filter) and the properties (tree) view below
Change-Id: I943433b594e91d4d6323af50087002b42d324d40
2022-10-21 09:19:18 +00:00
Kean Mariotti
5137d1ae45 Fix npm package vulnerability
The previous version of terser was volnerable to ReDos attacks.

Test: npm audit
Change-Id: I0ceda6931e68ad4338f7b382bfc6866812315e08
2022-10-21 09:19:18 +00:00
Kean Mariotti
0fa0e6070b Add prettier
Test: npm run prettier
Change-Id: Ie15a2104be13ccf37ca155c334fdd2798bad539f
2022-10-21 09:19:18 +00:00
Kean Mariotti
fd6c1bdf85 Merge "Add viewer Transaction" 2022-10-21 09:18:10 +00:00
Kean Mariotti
81c2db9a67 Add viewer Transaction
Fix: 238088678
Test: npm run build:all && npm run test:all
Change-Id: I90ad36a0a18e3b68216ea18d2a47e3ff38d98412
2022-10-21 08:13:54 +00:00
Kean Mariotti
fe5c7132de Remove obsolete dependencies to legacy transactions proto
Fix: b/254653004
Test: yarn build
Change-Id: I864c3c3a6a8524e54e363398f17403db7e81c0a6
2022-10-20 16:39:09 +00:00
Kean Mariotti
00c160c5fd Merge "Add viewer ProtoLog" 2022-10-20 15:23:52 +00:00
TreeHugger Robot
1838d44fcd Merge "Add InputWindowInfoProto to proto parsing" 2022-10-18 14:12:07 +00:00
TreeHugger Robot
b125034389 Merge "Add support to PositionProto in ObjectFormatter" 2022-10-18 12:32:47 +00:00
Nataniel Borges
e7cd8fc412 Add InputWindowInfoProto to proto parsing
The field is not registered as an IntDef but uses the same values as
LayeoutParams according to code codumentation

Test: npm run test:all && open a layers trace and check if
inputWindowInfo has a value and if the flags are correctly formatted

Change-Id: I868e1b3088cf9925c50faf0decce2da1f584288d
2022-10-17 16:56:59 +00:00
Nataniel Borges
26c8956a45 Add support to PositionProto in ObjectFormatter
Fixes: 254057780
Test: run winscope and open a SF trace
Change-Id: If69e4c135129b9c38f5a461eb73c3a74769f9425
2022-10-17 16:54:18 +00:00
Kean Mariotti
1fbdd3efaa Add viewer ProtoLog
Fixes: 251159338
Test: npm run build:all && npm run test:all
Change-Id: Ibd6774ed0bf2bc91a5d128eb8258ed4073279166
2022-10-17 10:26:03 +00:00
Kean Mariotti
ef2a794a0c Improve hierarchy component test
Test: npm run test:component
Change-Id: I36bf2d3f124a2d373e9ab37eadbe4144765edd02
2022-10-16 16:32:48 +00:00
Kean Mariotti
5638bf799b Improve binary search of timestamps
In case of repeated/equal timestamps, the first occurrence is the search's result.

Test: npm run build:unit && npm run test:unit
Change-Id: If15a7c815c654a3c6ad53c6626b9a89fcb536bff
2022-10-16 16:32:48 +00:00
Kean Mariotti
f20b6e475b Update icon
Test: start winscope and admire the new icon
Change-Id: Ica350d3ea8ae6f4db902fe99f6251b11b16c7df7
2022-10-14 11:50:14 +00:00
Cosmin Băieș
7fa68d374e Use flex instead of fixed sizes
Bug: 251087601
Test: npm run and check scaling with different screen sizes
Change-Id: I18efdd1250f0598ca2a01414dfa24e25b2bd6232
2022-10-13 18:47:46 +02:00
Vishnu Nair
bda80defc3 Winscope: replace isbufferlayer checks with buffer not empty
Layer types are deprecated.

Test: open traces with winscope and check buffer info is visible
Bug: 238781169
Change-Id: I1f1aeae4e86a2d44a7125dd03d31271d1b143a75
2022-10-05 17:06:10 +00:00
Treehugger Robot
e7cb38929e Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" am: f8a1fc304c am: e6b29979c9 am: 9d969a890e am: 831d03cfb6 am: c63265f6be
Original change: https://android-review.googlesource.com/c/platform/development/+/2237051

Change-Id: I64fd8c8011f0fcbf3a928b2a05d895b99a36a57a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 07:48:21 +00:00
utzcoz
e381c93d13 idegen: Migrate try-finally to try-with-resources for Configuration.java
Test: run idegen.sh to generate files for IntelliJ without error

Signed-off-by: utzcoz <utzcoz@gmail.com>
Change-Id: If1066d236ef44aff6b9f73a40751ad232a80f6f9
2022-10-01 10:04:48 +00:00
Treehugger Robot
143460473c Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806 am: e78fac030c am: 517c07c85e am: 7db63833a3 am: e49b237676
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929

Change-Id: Id1ab370fdf046d773edf9dc7b2ab45885f7f1399
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-30 08:38:33 +00:00
Treehugger Robot
d6c9ae2806 Merge "idegen: Handle symbolic link that targets to current or parent directory" 2022-09-30 06:23:50 +00:00
Priyanka Patel
0c8cdf9609 IME Viewers - Table of IME properties and SF/WM.
Add extra properties to IME viewers from the IME traces and SF/WM
traces.

Bug: b/238088679
Test: npm run test:all

Change-Id: I177fc7353f963cc8b1391a88d5d8f4b2e4f387fa
2022-09-28 09:02:35 +00:00
Priyanka Patel
32c0ee72db IME Viewers.
IM Clients, Service and Manager Service viewers - not yet including new
WM/SF combined properties view in hierarchy.

Bug: b/238088679
Test: npm run test:all

Change-Id: I4bd05ca5dff14abbf6d3a89b0e07730233edf1b0
2022-09-26 09:44:43 +00:00
Kean Mariotti
d1a7418db6 Remove chips from trace data types
Test: npm run build:all && npm run test:all
Change-Id: If2d0f70529b377404fa23d4a1c15ef5045e4a12b
2022-09-24 14:03:04 +00:00
Kean Mariotti
0a2c4a07a5 Refactor tree utils
Refactor tree utils for proper reuse from IME viewers:
- add common/trace/trace_tree_node (factored out from viewers)
- rename renaming viewers/common/tree_utils -> viewers/common/ui_tree_utils
- add common/utils/tree_utils: generic tree utils reused from "trace" and "ui"

Bug: 238088679
Test: npm run build:all && npm run test:all
Change-Id: Ib14dd3495dc7e91e3a0eef2fdc20efa27fe1ef2e
2022-09-23 14:57:15 +00:00
utzcoz
97a3f307a6 idegen: Handle symbolic link that targets to current or parent directory
Test: run idegen.sh to generate files for IntelliJ without error

Signed-off-by: utzcoz <utzcoz@gmail.com>
Change-Id: I80958e94f93a8e1ef546bc34bd929d04a224dc9e
2022-09-21 22:03:49 +08:00
Priyanka Patel
2597772279 Merge changes I2ab79fe4,I582d7c0d
* changes:
  Add ime_utils.ts
  Refactor tree_utils.ts
2022-09-20 09:40:47 +00:00
Krzysztof Kosiński
6b29d5190d Merge "Remove Python enables identical to global defaults." am: 5acfb41d4a am: 6fdc0d453f am: 0663a35093 am: f91c90e81c am: c6b947d357
Original change: https://android-review.googlesource.com/c/platform/development/+/2220481

Change-Id: Iebf42441eebcd9c0acde69abf7e332cc3b8db965
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 19:04:49 +00:00
Kean Mariotti
9b22ee7ee4 Add ime_utils.ts
Fixes: 238090771
Test: npm run build:unit && npm run test:unit
Change-Id: I2ab79fe44b9626cb764d22a62aa9fa5955a6adc4
2022-09-19 09:46:00 +00:00
Kean Mariotti
82c8561f8b Refactor tree_utils.ts
Test: npm run build:all && npm run test:all
Change-Id: I582d7c0df5da93e49efae5a5dad9d38732bd169a
2022-09-19 09:42:28 +00:00
Krzysztof Kosiński
45c7ebda06 Remove Python enables identical to global defaults.
Bug: 245854393
Test: presubmit
Change-Id: I9bb5cbd972432a26afcb13d7c2a6bbc73fb0991f
2022-09-17 11:33:50 +00:00
Priyanka Patel
d7e342220d Refactor Tree Generator/Transformer.
Properly type all the tree utils.

Bug: b/246498545
Test: npm run test:all
Change-Id: I715e5b1cdc103fda228aac492e7d4c368601803c
2022-09-16 15:22:05 +00:00
Priyanka Patel
cbb5a19e5f Better controls on rects view.
Rect labels are clickable. Pan added via right click and drag, zoom added via scroll.

Bug: b/245914589
Test: npm run test:all
Change-Id: I49ffd26b1c735390960e6b523acf3070951c903d
2022-09-15 12:44:49 +00:00