Commit Graph

34330 Commits

Author SHA1 Message Date
Nataniel Borges
707aadb98a Use display cutout from proto dump
Bug: 262390300
Test: atest FlickerLibTest
Change-Id: I03a7f85ee34fcbbe88df693e5787ba93709db716
2022-12-21 10:13:43 +00:00
Nataniel Borges
5cef50c328 Fix show default formatting for WM and SF traces
Now the checkbox shows false/0 values when checked.

Side effect: now transaction trace shows all properties. It should have
a checkbox similar to SF/WM trace to show only the meaningful values

Bug: 254054329
Test: npm run test:unit
Change-Id: I0f88dc3870c8863756a49f9a3698eb4d6d4bed58
2022-12-21 10:13:35 +00:00
TreeHugger Robot
f0b452ecd2 Merge "Use the CMakeLists.txt for IS_NEWER_THAN" 2022-12-20 00:52:49 +00:00
Neha Jain
31448ad802 Update build tools version to fix b/237299698 am: 0d7a50767b am: a0e7aed535 am: 17dc2742ce am: 3307a6c45c
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20764506

Change-Id: I2039e8a8d0318360ad49514150a3dd9cdc7fa4a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-20 00:04:07 +00:00
Neha Jain
3307a6c45c Update build tools version to fix b/237299698 am: 0d7a50767b am: a0e7aed535 am: 17dc2742ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20764506

Change-Id: I2b7c49af576bde829e1561c7509663d83cfa1ad4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 23:19:44 +00:00
John Reck
a90e707c53 Use the CMakeLists.txt for IS_NEWER_THAN
The directory isn't updated every build necessarily
but the CMakeLists.txt itself is regenerated often.

This should improve the consistency of changing
targets & re-loading the cmake project

Test: make && reload cmake in clion
Change-Id: I5a184ea9c626f03d70f6dc3a5e05646ee33cfe2f
2022-12-19 17:39:57 -05:00
Neha Jain
17dc2742ce Update build tools version to fix b/237299698 am: 0d7a50767b am: a0e7aed535
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20764506

Change-Id: I4111dedfa654f79b5ba5f5a37a9dbb4c167bd41d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 22:37:07 +00:00
Neha Jain
8d46cf0b02 Update build tools version to fix b/237299698 am: 0d7a50767b am: cfc8963c7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20764506

Change-Id: I1a92d1b37a7dbee71d2d160daf38849e69daead1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 22:35:40 +00:00
Neha Jain
a0e7aed535 Update build tools version to fix b/237299698 am: 0d7a50767b
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20764506

Change-Id: Id6ecefa041dfcdd7a1335ec5f7bea0015eacdf0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 22:03:21 +00:00
Neha Jain
cfc8963c7c Update build tools version to fix b/237299698 am: 0d7a50767b
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/20764506

Change-Id: I6622f418945b2d9559d8020ce94f68740ed5d005
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 22:02:57 +00:00
Kean Mariotti
b228591503 Fix snackbar messages
Test: npm run build:all && npm run test:all
Change-Id: I0f77bfe0e703b076296c5c4ee87af795d41aeca4
2022-12-19 18:42:09 +00:00
Kean Mariotti
3f5843666f Merge "Fix snackbar position" 2022-12-19 17:42:07 +00:00
Kean Mariotti
aa3b8091d9 Merge changes I95aa0ac4,Ia8bacc9a
* changes:
  Factor out some common code in end-to-end tests
  Display progress bar while loading data from remote tools (ABT or Buganizer)
2022-12-19 15:28:10 +00:00
Kean Mariotti
30d5862e9f Fix snackbar position
Fix: b/262518408
Test: collect or load traces and check that snackbar shows up in the center
Change-Id: I06362381ffaa7af9789d4f5dcee8481c7bdbe09d
2022-12-19 15:26:30 +00:00
Kean Mariotti
d57d9b378a Factor out some common code in end-to-end tests
Test: npm run build:all && npm run test:all
Change-Id: I95aa0ac4bb37716ca6774b5c58993a464e160cf5
2022-12-19 12:47:04 +00:00
Kean Mariotti
bd2c1c3b9c Display progress bar while loading data from remote tools (ABT or Buganizer)
- Mediator forwards data from remote tools to UploadTracesComponent
- If traces are not visualized, store timestamp received from remote tool and apply it later
- Minor refactoring: do not pass Mediator down to TimelineComponent

Fix: b/263047560
Bug: b/260994827
Test: npm run build:all && npm run test:all
Change-Id: Ia8bacc9a84b7b7c27e0ebb19c9675dd65ec5db9b
2022-12-19 11:27:22 +00:00
Yu Liu
d35d90d4fc Merge "Explicitly search header files in abi dumper." am: a3871b8183 am: 3db068e5db am: 4169d8c290
Original change: https://android-review.googlesource.com/c/platform/development/+/2359334

Change-Id: I2df18ac3cb44b7db478162bd4674248025ce91c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-17 00:02:40 +00:00
Yu Liu
4169d8c290 Merge "Explicitly search header files in abi dumper." am: a3871b8183 am: 3db068e5db
Original change: https://android-review.googlesource.com/c/platform/development/+/2359334

Change-Id: I6934039d551e253be781f96bef40ac9864e4c6bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 23:19:51 +00:00
Yu Liu
3db068e5db Merge "Explicitly search header files in abi dumper." am: a3871b8183
Original change: https://android-review.googlesource.com/c/platform/development/+/2359334

Change-Id: Ia375ae3def2ce033e6fee1d90501c6a71e5e3648
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 22:43:59 +00:00
Yu Liu
a3871b8183 Merge "Explicitly search header files in abi dumper." 2022-12-16 22:23:27 +00:00
Neha Jain
0d7a50767b Update build tools version to fix b/237299698
Bug: 262711178
Change-Id: Ia275a2ab69ee31b7d81a2ca8c83bef08cbf107df
2022-12-16 21:12:33 +00:00
Pablo Gamito
cbf084b07a Merge changes I74b6796a,If55d6a05
* changes:
  Pass through excludesCompositionState flag to layer creation
  Make sure UI send empty trace configs to proxy
2022-12-16 15:53:56 +00:00
Kean Mariotti
c987bf5abe Improve cross-tool protocol's origin allow listing
Test: npm run build:all && npm run test:all
Bug: b/260994827
Change-Id: Iab8db927a55f060784a375f00a831bd10020ed0c
2022-12-16 15:36:46 +00:00
Pablo Gamito
bee470988b Pass through excludesCompositionState flag to layer creation
So that Flicker lib components can fallback on the bounds when the composition information for visible region is known to not be available

Test: collect a trace without composition enabled and make sure we still have visible layers
Bug: 250998831
Change-Id: I74b6796a508cd4aa72bf0042bf9825434689f6e5
2022-12-16 13:15:05 +00:00
Pablo Gamito
38dbb6c195 Make sure UI send empty trace configs to proxy
Otherwise when we don't select any of the trace configuration we won't update the tracing config and will just use the latest config

Test: deselect all trace config flags and make sure that config is set when tracing
Bug: 262563422
Change-Id: If55d6a0592552c1ebeb5d928073fe9d12440a3f1
2022-12-16 13:03:28 +00:00
Kean Mariotti
eaa86c789c Merge changes Id61114b8,I3451e8a8,I01a258ba
* changes:
  Add AbtChromeExtensionProtocol
  Add GlobalConfig to customize Winscope behavior for testing
  Cross-tool protocol
2022-12-16 10:19:56 +00:00
Kean Mariotti
e5aa73c153 Add AbtChromeExtensionProtocol
Test: build local ABT chrome extension (go/abt-extension) (version in manifest must match
chrome version and winscope URL must point to dev winscope), open a buganizer bug with .zip
and/or <file>.winscope attachments, click on the button "open in winscope".

Fix: b/255966630

Change-Id: Id61114b88ebf59d5f43f6b8a8a74566233a0b8d1
2022-12-16 10:16:18 +00:00
Kean Mariotti
74529e8c0d Add GlobalConfig to customize Winscope behavior for testing
Add a GlobalConfig object that provides different
configs/values depending on the execution mode.

GlobalConfig currently supports "DEV" and "PROD" modes.
We'll add a "TEST" mode in the future to enable/activate
mocks in e2e tests.

Bug: b/260401392
Fix: b/262389857
Test: npm run build:all && npm run test:all
Change-Id: I3451e8a8456db2bb750c81ef27ecaf7dbabff934
2022-12-16 08:51:04 +00:00
Kean Mariotti
5a86978f6b Cross-tool protocol
- Add CrossToolProtocol
- Refactor Mediator (holds reference to components instead of callbacks)
- Add remote tool mock (for e2e tests)

Test: npm run build:all && npm run test:all
Change-Id: I01a258ba96204883a81fc72a475eb2349e15c6fb
2022-12-16 08:51:04 +00:00
Yu Liu
0d3029fb87 Explicitly search header files in abi dumper.
Bug: None
Test: Manual
Change-Id: Ie72e0c4490ab9e29152fcdc45e48ca9724e31f7d
2022-12-15 21:48:11 -08:00
Bob Badour
29b8f3b891 Merge "[LSC] Add LOCAL_LICENSE_KINDS to development" am: fd964def39 am: bbf1831dc6 am: f8061e548f
Original change: https://android-review.googlesource.com/c/platform/development/+/2357751

Change-Id: Ic590297514c0e083a91d09c92bd68880122761a6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 02:39:16 +00:00
Bob Badour
f8061e548f Merge "[LSC] Add LOCAL_LICENSE_KINDS to development" am: fd964def39 am: bbf1831dc6
Original change: https://android-review.googlesource.com/c/platform/development/+/2357751

Change-Id: I6db1f7cad227334c5a112a55b233ed12736f0192
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 01:56:44 +00:00
Bob Badour
bbf1831dc6 Merge "[LSC] Add LOCAL_LICENSE_KINDS to development" am: fd964def39
Original change: https://android-review.googlesource.com/c/platform/development/+/2357751

Change-Id: I9106126a3543659f249e9a429a8f5e5029cc2b64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-16 01:22:09 +00:00
Bob Badour
fd964def39 Merge "[LSC] Add LOCAL_LICENSE_KINDS to development" 2022-12-16 00:59:40 +00:00
Bob Badour
0b10b71586 [LSC] Add LOCAL_LICENSE_KINDS to development
Added SPDX-license-identifier-Apache-2.0 to:
  apps/OBJViewer/Android.bp
  samples/HeavyWeight/Android.bp
  samples/MySampleRss/Android.bp
  tools/ndk/Android.bp
  tools/ndk/ndkabidump/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all
Change-Id: I6d275d857a5774e34b7156ecadb66f8c09337a53
2022-12-15 07:19:34 -08:00
Treehugger Robot
17d886284c Merge "Revert "Revert "Add tools for updating NDK ABI dumps.""" am: dff4dc6240 am: 4a98147c1d am: d347d5b081
Original change: https://android-review.googlesource.com/c/platform/development/+/2336135

Change-Id: Ia37bc779947aab8661f57114ab1ef63bcd2d9569
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 02:40:18 +00:00
Treehugger Robot
d347d5b081 Merge "Revert "Revert "Add tools for updating NDK ABI dumps.""" am: dff4dc6240 am: 4a98147c1d
Original change: https://android-review.googlesource.com/c/platform/development/+/2336135

Change-Id: I321fb517babaa37b40651de2091bdb7077fe1aae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 02:00:02 +00:00
Treehugger Robot
4a98147c1d Merge "Revert "Revert "Add tools for updating NDK ABI dumps.""" am: dff4dc6240
Original change: https://android-review.googlesource.com/c/platform/development/+/2336135

Change-Id: I56790789dee3509260e9444536a4e34e24c3f95b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-15 01:25:47 +00:00
Treehugger Robot
dff4dc6240 Merge "Revert "Revert "Add tools for updating NDK ABI dumps.""" 2022-12-15 01:00:57 +00:00
TreeHugger Robot
3a4f0e337c Merge "Don't set default SF config in proxy" 2022-12-14 17:39:20 +00:00
Pablo Gamito
aa2691832b Don't set default SF config in proxy
Forward the responsibility  to the UI

Fixes: 262563422
Change-Id: I6b9561ddeea1e6f30f7a52517b20eba269139a10
2022-12-14 16:11:45 +00:00
Hsin-Yi Chen
5d7076294f Merge "Refactor DiffStatus into a class" am: 5eef9c8c1a am: c298718579 am: a11b9c9c9b
Original change: https://android-review.googlesource.com/c/platform/development/+/2337409

Change-Id: I112a990c3fe346b39ea36d8440bc426f7eb9fffd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 13:42:25 +00:00
Hsin-Yi Chen
a11b9c9c9b Merge "Refactor DiffStatus into a class" am: 5eef9c8c1a am: c298718579
Original change: https://android-review.googlesource.com/c/platform/development/+/2337409

Change-Id: I68467ea390281d065969a377b1450aaecfa9fdf7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 13:02:38 +00:00
Hsin-Yi Chen
c298718579 Merge "Refactor DiffStatus into a class" am: 5eef9c8c1a
Original change: https://android-review.googlesource.com/c/platform/development/+/2337409

Change-Id: I425fde7ccc1a91ae23540fc64997d77ee3c3351b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 12:29:57 +00:00
Hsin-Yi Chen
5eef9c8c1a Merge "Refactor DiffStatus into a class" 2022-12-14 11:46:01 +00:00
Hsin-Yi Chen
ddcd2f8581 Merge "Assert the output file of header-abi-diff" am: 9f8239f8d4 am: 202191db4f am: a4c76dbecd
Original change: https://android-review.googlesource.com/c/platform/development/+/2337408

Change-Id: Ica4f946c3ff3f8d6cf4f40994b7f8d93f727f212
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 03:47:34 +00:00
Hsin-Yi Chen
a4c76dbecd Merge "Assert the output file of header-abi-diff" am: 9f8239f8d4 am: 202191db4f
Original change: https://android-review.googlesource.com/c/platform/development/+/2337408

Change-Id: Iebcb25ad2b9956533901d258184faec54e115fed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 03:08:07 +00:00
Hsin-Yi Chen
202191db4f Merge "Assert the output file of header-abi-diff" am: 9f8239f8d4
Original change: https://android-review.googlesource.com/c/platform/development/+/2337408

Change-Id: I15feae89241d50e54c7460d3578c9c1f7bace69a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-14 02:36:40 +00:00
Hsin-Yi Chen
4a0b74b22a Refactor DiffStatus into a class
DiffStatus is a class that exposes constants and member functions.
AbiDiffHelper calls the member functions to determine how to report the
diff. The actual value of a DiffStatus object is encapsulated so that
developers can define new status without changing existing logic.

Test: ./test.py
Bug: 259148872
Change-Id: I2c3be62046aa01d68c84690cb158f8fc7a5b474b
2022-12-14 10:06:13 +08:00
Hsin-Yi Chen
9f8239f8d4 Merge "Assert the output file of header-abi-diff" 2022-12-14 02:05:06 +00:00