Add tslint with google3 config (google3/javascript/typescript/tslint).
Skipped google3 custom rules that need to be built and added to the project.
If needed, with some extra effort it should be possible
to get the google3 rules to build/run also in the Winscope environment.
However, it is probably simpler and quicker to run (and maybe fix?)
those checks on critique once we port Winscope to google3.
Fix: b/264505907
Test: npm run tslint:check / npm run tslint:fix
Change-Id: If3a79de673503e0c06541f0329163dee93849c3c
Handle the case where corner radius > height/2 (or width/2)
Fix: b/264264761
Test: npm run build:all && npm run test:all
Change-Id: I9327189a3b9a59128d9ed3cc885f5887900a952a
TO meet the U requirement that apps targetSdkVersion U+ must specify
foreground service type and permissions.
Bug: 262580021
Test: build and run.
Change-Id: I0e6bf918b17eee82bdb2669a8c28e17e327a728f
The rounded corners property should be 0 on WM traces, instead of null
Fixes: 264024995
Test: open a wm trace and check rects view
Change-Id: I53e6668a8bdaa460e2e740936b719a3a4f813f8c
Add new check based on tool "madge" to prevent cyclic dependencies regressions.
Madge currently reports 10 cycles. The new check makes sure we don't introduce new ones.
Bug: b/261552483
Test: npm run deps_graph:check_cycles
Change-Id: I2630ddcb94101be9b288ce0708fca3231962f406
Unleash prettier on the entire codebase
Fix: b/263471740
Test: npm run format:check && npm run lint:check
Change-Id: Ida110947bec9c9a9b385c64e126ccf6d7ad6652b
- Add npm scripts format:check, format:fix, lint:check, lint:fix
- Include format:check + lint:check into the test suite (test:all)
- Configure eslint to play nice with prettier (basically no format checks)
Test: npm run format:check && npm run lint:check
Bug: b/263471740
Change-Id: I6f215860a24302ed04c2689ac31e4dd4e7e6fd5e
This commit moves the functions that determine struct extensions from
ir_diff_representation.cpp to abi_diff_helpers.cpp. The functions
are called before IRDiffDumper so that the IR and the dumper do not
include the diff logic.
Test: ./test.py
Bug: 259148872
Change-Id: I93aaa3028bf6a30312f0b0e5b1ef5f6ae1041f21
The cargo2android.json config file now supports the key "variants" with
a list of entries containing keys and build name suffix. Each entry
will produce a different library (or binary). Keys supplied for each
variant will overwrite any existing ones specified in the config file.
See an example of the protobuf crate on aosp/2368788.
Test: None
Change-Id: Iaca67c7f22718c27b3cb118d9794f1ff01d31c84
Plus some code clean up
Result: https://screenshot.googleplex.com/BNYzBrQ9SMeiPxU
Test: npm start and open a trace with rounded corners (e.g. quick
switch)
Change-Id: I93c36eaccd440c3420e3bb7fe25d262979dbde5e
`header-abi-diff --allow-extensions` allows function parameters to be
more qualified, and return types to be less qualified. The ABI tools
follows the qualifier conversion rules in C++.
The ABI tool only allows extending the qualifiers of the functions that
have corresponding symbols. The qualifiers of the other types, such as
function pointers, class members, and global variables, must be
identical between the old and new ABIs.
Test: ./test.py
Bug: 259148872
Change-Id: I227f6ed774cc88009713acce955e35f1c3cff1ca
- Use OnPush Angular change detection strategy in SF viewer (better perf and avoids change loop errors)
- Hide PropertyGroupsComponent when root layer is selected
- Add formatting for "raw" long numbers
Fix: b/254044321
Test: npm run build:all && npm run test:all
Change-Id: I56274973a8d42c28e49e4a4a92fd6ae09a6693db
