Commit Graph

18257 Commits

Author SHA1 Message Date
Aurimas Liutikas
ab86053704 Add new rules to Checkstyle config.
Add the following new checks:
- JavadocMethod
- MissingDeprecated
- MissingOverride
- OneTopLevelClass
- StringLiteralEquality
- ArrayTypeStyle
- RedundantModifier
- NewlineAtEndOfFile

Bug: 27051781
Change-Id: I4d34278f73ee821cd6cfea705cf949881eaebfc2
2016-02-08 22:29:25 +00:00
Keyvan Amiri
9e9fdcb8e9 Merge "SupportLeanbackShowcase: Changed styles into new theme APIs" into mnc-ub-dev 2016-02-04 00:07:01 +00:00
Keyvan Amiri
5abd85c64e SupportLeanbackShowcase: Changed styles into new theme APIs
The card styles are  converted into themes, and in the
ImageCardViewPresenter, each ImageCardView is generated through the use
of the resource ID of each specific theme.
This is to conform to the latest widget API change which moved a set of
attributes to theme for customizing widgets.

Bug: 26249596
Change-Id: Id64aeebb96bee13c6cb68f8ab69cacdfb9a98531
2016-02-03 15:58:27 -08:00
Aurimas Liutikas
76b3663fe0 Merge "Update Intellij config to work with new version of Intellij." into mnc-ub-dev 2016-02-02 17:58:33 +00:00
Aurimas Liutikas
c4e1082548 Merge "Skip JavaDoc checks for Java tests classes" into mnc-ub-dev 2016-02-02 00:49:55 +00:00
Aurimas Liutikas
2aa181da74 Update Intellij config to work with new version of Intellij.
Tested with:
Android Studio 2.0 preview
Android Studio 1.5
Intellij 15

Change-Id: Ibc617cd0e5ac7b535158d5c8919c6c59441199a4
2016-02-01 15:59:00 -08:00
Keyvan Amiri
4c7054297b Merge "Fixed the video view crash in SupportLeanbackShowcase master build" into mnc-ub-dev 2016-02-01 23:11:43 +00:00
Keyvan Amiri
32be3d30dc Fixed the video view crash in SupportLeanbackShowcase master build
The "Video consumption Examples" view in SupportLeanBackShowcase was failing on
the master build (fugu-userdebug N AAC30 2573265 devkeys),
since onCreate gets called in the reverse order of fragments' appearence in the
code when using a single transaction.
Fixed that by using separate transactions per fragment addition, and now the
example video view works on the master build as well as the LMP-MR1 build.

Bug: 26894030

Change-Id: Ic020cb87049af7e2095387ca1aab017f2b026630
2016-02-01 15:00:29 -08:00
Susnata Basak
c140afb120 Merge "Updating SupportLeanbackDemo to showcase GuidedStepFragment." into mnc-ub-dev 2016-01-29 21:39:53 +00:00
susnata
15871fb0d4 Updating SupportLeanbackDemo to showcase GuidedStepFragment.
Included sample activities/fragments to showcase how to
use GuidedStepFragment in half screen mode.

Change-Id: I9eefe417ddf79b0dfe896a5cec25b7c7cd3a41e7
2016-01-29 13:29:00 -08:00
Aurimas Liutikas
99451e5b13 Skip JavaDoc checks for Java tests classes
Bug: 26862656
Change-Id: I708ee552154796ece6655db8f9f3157a2e9f3ba5
2016-01-29 13:10:01 -08:00
Chris Banes
2353152044 Make AVDC sample drawable larger
Makes it easier to see

Change-Id: Ied27b97481d9d523e6410d6769229b3abb10c14f
2016-01-29 11:49:44 +00:00
Chris Banes
b58648deb6 Merge "Add AVDC demo to Support7Demos" into mnc-ub-dev 2016-01-29 09:17:08 +00:00
Chris Banes
cb5ed20163 Add AVDC demo to Support7Demos
Also renamed some of the other demos to
fit into the correct categories.

BUG: 26638431

Change-Id: Iaa7333f67cd7606bb504e7bbfe766da543ea7afa
2016-01-29 09:16:39 +00:00
Keyvan Amiri
4e89da7764 SupportLeanbackShowcase: update support library version
update android support library to 23.1.1

Change-Id: Ibf50836110dea71992946214ab5c9578582ffd84
2016-01-28 10:51:34 -08:00
Aurimas Liutikas
49342a6760 Allow both (c) and (C) in the copyright header.
Bug: 26818467
Change-Id: Iec1a17ecad3e6853d318e907596ed3ae29208902
2016-01-27 10:25:18 -08:00
Yuichi Araki
2b497aca8c Merge "Add usage of BottomSheetBehavior with Fragment" into mnc-ub-dev 2016-01-27 04:03:23 +00:00
Aurimas Liutikas
2d59cfb992 Add support for running Checkstyle on a given SHA-1.
Usage e.g.: ./checkstyle.py -s 3aca02ca91816a86febb5ed6e380ec2122adea47

Additionally this CL adds a pre-push script that can be used a git
hook to run Checkstyle on 'repo upload'

Bug: 25852971
Change-Id: Ia00d48df80b2b024de0899d9590868016c5b7bf0
2016-01-25 17:16:28 -08:00
Aurimas Liutikas
23e2d4b3eb Add new two new rules to Checkstyle.
- Add Android copyright header check

- Add comment suppression filter rule to enable suppressing indentation check
Usage:
// CHECKSTYLE:OFF IndentationCheck
  Code.With();
    Bad = Indentation;
// CHECKSTYLE:ON IndentationCheck

Bug: 26747466
Change-Id: I837d7bde1fd85250678a3aba66309043bfc324b1
2016-01-25 11:25:29 -08:00
Yuichi Araki
03349d5713 Add usage of BottomSheetBehavior with Fragment
Bug: 26507828
Change-Id: I62bb8db4bb6b1c7b8a908ecc88d603347839301a
2016-01-25 15:22:42 +09:00
Kirill Grouchnikov
5e9ef02951 Merge "Sample app for appcompat-v7's PopupMenu." into mnc-ub-dev 2016-01-22 15:34:20 +00:00
Aurimas Liutikas
a0e889762d Checkstyle handling when all lines are deleted.
It is valid to have empty modified_lines list for files
that only contain deletions. In such case we should skip
all the errors except for forced rules.

Updated the test to match the expectation.

Change-Id: I6993968b882fb6fbe2ba1f63f3b6879c3308ff34
2016-01-21 14:43:12 -08:00
Dake Gu
b571663f91 Merge "Add example of DatePicker" into mnc-ub-dev 2016-01-21 22:34:26 +00:00
Kirill Grouchnikov
4d3dc3cfd0 Sample app for appcompat-v7's PopupMenu.
Change-Id: I3daaf8fcd9fce204d2cc50ff493cb7b544df6afc
2016-01-21 16:13:19 -05:00
Kirill Grouchnikov
38a34c05f7 Merge "Simplify the content layout of the DrawerLayout demo." into mnc-ub-dev 2016-01-21 20:05:24 +00:00
Kirill Grouchnikov
c8d7c07e4a Simplify the content layout of the DrawerLayout demo.
No need to overcomplicate things with FrameLayout and margins.
Vertical LinearLayout does the job for this specific case.

Change-Id: I23bf53cc2a90b602f8956782a0c0af1e20a8cd52
2016-01-21 11:18:28 -05:00
Yuichi Araki
711d3d346d Merge "BottomSheetBehavior passes View to callbacks" into mnc-ub-dev 2016-01-21 04:21:01 +00:00
Chris Banes
e9535f2cdc Merge "TabLayout layout items sample" into mnc-ub-dev 2016-01-15 16:33:33 +00:00
Kirill Grouchnikov
7da5bbb6e9 Add end drawer to the sample app.
Bug: 26555813
Change-Id: Ia7f00f8bb1a3342750c5c2db76b6ea1bb7cbb1bd
2016-01-14 10:55:46 -05:00
Chris Banes
91e3d95fcf TabLayout layout items sample
BUG: 19634570

Change-Id: I9501e0cb44f975370330117bfffdee8c1de89141
2016-01-14 11:54:41 +00:00
Chris Banes
39eac83a81 Merge "Make sample use TextInputEditText" into mnc-ub-dev 2016-01-14 10:58:41 +00:00
Yuichi Araki
625889b674 BottomSheetBehavior passes View to callbacks
Bug: 26509449
Change-Id: I7de0dd0f59d7bd16fe50fae32b3b2f13761c93fc
2016-01-14 18:06:20 +09:00
Yuichi Araki
8abd4451a9 Merge "Use of bottom sheet with ScrollView in background" into mnc-ub-dev 2016-01-14 03:41:30 +00:00
Dake Gu
5df19367bb Merge "SupportLeanbackDemo: demo of custom theme of ImageCardView" into mnc-ub-dev 2016-01-13 18:44:02 +00:00
Chris Banes
079eca8847 Make sample use TextInputEditText
Change-Id: Ic995fa3086316ddb19b1b3929d5142091331f469
2016-01-13 16:24:13 +00:00
Yuichi Araki
6dc55051fc Use of bottom sheet with ScrollView in background
Bug: 26237244
Change-Id: I79d500ce1262021368aeb4693246bbc6bba8c6e7
2016-01-13 20:02:53 +09:00
Dake Gu
c77aa4f798 GuidedStepFragment: add test for icon
Bug 26473407

Change-Id: I2f59fe2d869c39c802a6451533a49f6682cdef8a
2016-01-11 16:00:33 -08:00
Dake Gu
7d3da1d678 Add example of DatePicker
Bug 25390757

Change-Id: Iec578a2a195a7f8c6873fd95ceb08a33f502894b
2016-01-11 13:26:34 -08:00
Chris Banes
f5b1907589 Add demo for ShareActionProvider
Change-Id: I083354ef09738da812ea508f3091496f08f10123
2016-01-04 12:07:31 +00:00
Chris Banes
7eb7c4f7df Fix SupportVectorDrawable sample not building
Change-Id: I0a304cd7ea9320b0e5636121c89e8e24d3f7180f
2015-12-21 11:54:47 +00:00
Chris Banes
87d5e9b38c Merge "Make the SupportDemo apps work the AppCompat + VDC" into mnc-ub-dev 2015-12-21 11:05:00 +00:00
Dake Gu
cb09b7bf22 SupportLeanbackDemo: demo of custom theme of ImageCardView
Change-Id: I8ba65d9d6ffbc461460acff99ac1c3125eb87d00
2015-12-18 17:16:13 -08:00
Aurimas Liutikas
9cd6eaacba Update Checkstyle rules to better match the style guide.
- Correct import order.

Bug: 25852971

Change-Id: I6addc06f7bb91df3d9d011807b5688b5aeba0a0d
2015-12-18 15:10:14 -08:00
Aurimas Liutikas
8c1e871ae2 Merge "Fix import order config file for Intellij." into mnc-ub-dev 2015-12-18 19:26:14 +00:00
Jeff Sharkey
221249dc6e And yet another pass at cleaning up ordering.
To meet the spirit of the style guide, this places "com.android" near
"android" to separate it from other "com" items.

It also enforces identical ordering on all static imports.

Change-Id: I51e9847a42505db5cec8b9083d1dbc840a47c2c3
2015-12-18 19:24:05 +00:00
Aurimas Liutikas
5afb1b3781 Fix import order config file for Intellij.
Start following out public style guide for imports:
https://source.android.com/source/code-style.html#order-import-statements

Bug: 25852971
Change-Id: I4fb05aba2d114b6dee56d1bcf94246cf38526a37
2015-12-18 11:21:13 -08:00
Jeff Sharkey
cc31a92c11 Fix import order to match style guide.
Change-Id: Ibd0d15b8d92f2d02d4279c9c7a90016d390e6abd
2015-12-18 17:45:30 +00:00
Chris Banes
91eee205f3 Make the SupportDemo apps work the AppCompat + VDC
Change-Id: Ib13152d2256081e4534b4b03bb1e376b8cc18f79
2015-12-18 10:45:04 +00:00
Aurimas Liutikas
6b82b75c69 Allow to run checkstyle with untracked files present.
Additionally, this CL adds basic tests.

Bug: 25852971

Change-Id: Ia8a62e0d49428e1d933d2cef832c977e62f9c614
(cherry picked from commit 55e7480eff)
2015-12-18 00:54:02 +00:00
Aurimas Liutikas
4e8bad8045 Fix a crash when a brand new file is added.
Checkstyle.py was not handling additions of new files resulting in
a crash. For new files git.modified_lines() returns None. Added code
handles that case.

Bug: 25852971
Change-Id: I91e2b8c92581ec9e89bcbbcd2d274f56c791f3a9
(cherry picked from commit 5b87dbad0c)
2015-12-18 00:53:20 +00:00