Commit Graph

31954 Commits

Author SHA1 Message Date
Priyanka
c132b4643c Fix broken trace views for accessibility/IM.
Due to new UI, Accessibility Trace and IM Trace views were broken. This
CL passes values in for presentTags and presentErrors to ensure the
views display as expected.

Bug: b/197628035

Test: run a trace with all checkboxes ticked and ensure the views
display as expected.

Change-Id: Iad98ab88b0250447ead72c5bcf467f8873d25182
2021-08-24 14:50:02 +00:00
Treehugger Robot
11de296e46 Merge changes I47b4756d,I0564369e am: f486885133 am: 39e7a58749 am: a150d58370 am: f3c7c0d3ef am: 71194cd9f1
Original change: https://android-review.googlesource.com/c/platform/development/+/1804439

Change-Id: I5ee890a18a926c2fb5e3a95c0c0d44f223e75cd2
2021-08-23 17:02:44 +00:00
Treehugger Robot
71194cd9f1 Merge changes I47b4756d,I0564369e am: f486885133 am: 39e7a58749 am: a150d58370 am: f3c7c0d3ef
Original change: https://android-review.googlesource.com/c/platform/development/+/1804439

Change-Id: Ie324e2ee75dae472ebf0e8b98085718cbf05c8ac
2021-08-23 16:47:01 +00:00
Treehugger Robot
f3c7c0d3ef Merge changes I47b4756d,I0564369e am: f486885133 am: 39e7a58749 am: a150d58370
Original change: https://android-review.googlesource.com/c/platform/development/+/1804439

Change-Id: I18310fbec547adaffd6285e67c21beb2b12476a4
2021-08-23 16:31:08 +00:00
Treehugger Robot
a150d58370 Merge changes I47b4756d,I0564369e am: f486885133 am: 39e7a58749
Original change: https://android-review.googlesource.com/c/platform/development/+/1804439

Change-Id: Ie7b51080ffe15b69bbff2f36218ae94988fdb2f4
2021-08-23 16:15:45 +00:00
Treehugger Robot
39e7a58749 Merge changes I47b4756d,I0564369e am: f486885133
Original change: https://android-review.googlesource.com/c/platform/development/+/1804439

Change-Id: I73665b6aaf439a8728b35553e6cbd3622d2ef4c6
2021-08-23 15:57:44 +00:00
Treehugger Robot
f486885133 Merge changes I47b4756d,I0564369e
* changes:
  Let the test mapping updater make commits and upload changes.
  Allow passing globs to update_crate_tests.py.
2021-08-23 15:42:49 +00:00
Priyanka
aadd3418fd Add tags/errors to trace views.
At the start or end timestamp of a transition, or at an error timestamp, colour coded tags show up
next to the relevant layer/task in the WM and SF trace hierarchy views.
Tick the transition checkbox to only show entries that have tags/errors.
Compatible with flat checkbox.

Bug: b/196544612

Test: upload the zip onto the x20 (see bug) and test above.
Change-Id: Ied84adbedc38324629c8b50178b44041f8e8b66e
2021-08-23 10:58:29 +00:00
Joel Galenson
4a2a3a8211 Let the test mapping updater make commits and upload changes.
This will make it easier to run it on many crates and upload all of
the changes.  It puts the uploaded CLs in a topic to save resources.
If the script does not change a TEST_MAPPING, it does not upload
anything.

Test: Run on a subset of crates.
Change-Id: I47b4756d968c54d7d810c8a19a8a7419aebc6e15
2021-08-20 12:26:37 -07:00
Joel Galenson
08352445c8 Allow passing globs to update_crate_tests.py.
This makes it easier to run it on multiple directories.

Test: Call with various globs.
Change-Id: I0564369e4e8b9d62482fb2162a16d0e588f94e57
2021-08-20 11:39:48 -07:00
Priyanka
0e80ea1000 Add tags and errors to focused/targeted timelines.
Extend the tag timeline display from global to specific WM/SF trace
timelines. During focused or targeted navigation, the tags/errors should display for their associated trace
only. On global navigation, the minimum start and maximum end timestamp
for each transition is displayed. In the search bar, under transitions
and errors, note that the timestamps displayed as the global start and
end.

Bug: b/197066003

Test: upload SampleWinscope.zip from bug and test the different
navigation types.

Change-Id: Id273bf77425c504d943f1ee9716ce2f3ad0ec9c5
2021-08-20 14:45:04 +00:00
Priyanka
e93515ef89 Add functionality to search + navigate tags/errors.
Add a searchbar to bottom of Winscope that can be used to navigate through
all the tags/transitions/errors present in a trace (integrating existing timestamp search).
Choose the desired tab to set the type of search. Typing input into the relevant search will filter the elements.
Click on the start or end timestamp in the scrollable search table to navigate to that
timestamp in the timeline. Click on a transition in the search table to navigate to the start timestamp for that transition. Click on a transition in the timeline to toggle between start and end timestamps for that transition.

Bug: b/196197875

Test: upload the traces on the bug and test the above implementations on
the x20.

Change-Id: Ib3a0fff770cc65a38e50a8d99f130752b2f98eeb
2021-08-20 14:43:55 +00:00
TreeHugger Robot
6f3098ad9c Merge "Fix flat and visible checkboxes on trace views." 2021-08-20 10:35:09 +00:00
Treehugger Robot
21ee402904 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a am: 023d8bfa44 am: 461112ec85 am: d2d3c0d4d9
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: I517e83dd918c656d679d1064265726f8c3308ce1
2021-08-19 22:05:41 +00:00
Treehugger Robot
d2d3c0d4d9 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a am: 023d8bfa44 am: 461112ec85
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: I5170fb8ea6a2a5d223aff85212e13098f7bbc0d6
2021-08-19 21:51:15 +00:00
Treehugger Robot
461112ec85 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a am: 023d8bfa44
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: I1020f5807de22c5f5dad72e4633f7c4d0360160f
2021-08-19 21:32:54 +00:00
Treehugger Robot
023d8bfa44 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: Id720629612f67560e57ddc0d787ee6314dbbf999
2021-08-19 21:15:29 +00:00
Treehugger Robot
4976675e9a Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: Idb3bc4cbff66d8bd9c410cf5225bb9c1f7dac04a
2021-08-19 21:01:12 +00:00
Treehugger Robot
097e8c0a15 Merge "Add support for reuse configuration in OTA generator." 2021-08-19 20:45:53 +00:00
Treehugger Robot
dedcabf27b Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc am: e3d4db13a7 am: cd0f8452be am: 74f0d027a6 am: 59ee286b44
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: Ifae3dc3d4c1b4ef0d4a9182dfda3247c567e23a4
2021-08-19 17:53:27 +00:00
Treehugger Robot
59ee286b44 Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc am: e3d4db13a7 am: cd0f8452be am: 74f0d027a6
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: I6c06e0da2ec2d2a0536dd3698171dcd10b343eed
2021-08-19 17:34:26 +00:00
Treehugger Robot
74f0d027a6 Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc am: e3d4db13a7 am: cd0f8452be
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: Ic2c060f9fc579bed3fb4d332ed436a6718cae30d
2021-08-19 17:18:59 +00:00
Treehugger Robot
cd0f8452be Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc am: e3d4db13a7
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: I40e960906f9bfc241c479fd3c2121c6845364e55
2021-08-19 17:01:09 +00:00
Treehugger Robot
e3d4db13a7 Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: I9f74bd1fd9422116d4fe6726b4d34585c5f84cdf
2021-08-19 16:51:53 +00:00
Treehugger Robot
54f24641bc Merge "Fix a bug that may cause the ota generation fail." 2021-08-19 16:37:30 +00:00
lishutong
1ec526c9a0 Add support for reuse configuration in OTA generator.
Use vuex to store the otaConfig, now the history configurations can be
reused in the job detail page. Also the targetBuilds, incrementalSources
are not stored in vuex as well. Once the targetBuilds are chosen, it
will not lose the states when switching the tab between singleOTA,
batchOTA and chainOTA.

Test: npm run test:unit
Change-Id: I563ac0c79fd0cedd5e71e8722b956545f6624551
2021-08-19 16:34:09 +00:00
lishutong
e8c8d88b8c Fix a bug that may cause the ota generation fail.
The extra space in args['extra'] may cause the ota generation fail.

Test: python test_ota_interface.py -v
Change-Id: Iac6d06a89c52ab7554e54c08e5e04496b3da730a
2021-08-19 15:32:38 +00:00
Priyanka
9236a95bd6 Fix flat and visible checkboxes on trace views.
Now ticking the flat checkbox displays all entries without indentation,
and only visible entries are shown upon ticking only visible.

Bug: b/196951608

Test: upload a WM or SF trace and tick flat - all entries should be
aligned to left of Hierarchy box.

Change-Id: Iedb755d94895afcdca334871e980064c79430206
2021-08-19 10:58:48 +00:00
Treehugger Robot
fa63220b14 Merge "Fully remove deprecated --no-test-mapping argument." am: 52469f2093 am: 7622c162e6 am: 313f801fc6 am: 2af1e3f802 am: b477c39bf8
Original change: https://android-review.googlesource.com/c/platform/development/+/1798316

Change-Id: Ic102f843d765c7c3b98b0cbe5702957cb350fb0a
2021-08-19 10:18:45 +00:00
Treehugger Robot
b477c39bf8 Merge "Fully remove deprecated --no-test-mapping argument." am: 52469f2093 am: 7622c162e6 am: 313f801fc6 am: 2af1e3f802
Original change: https://android-review.googlesource.com/c/platform/development/+/1798316

Change-Id: I21d1307e71f3f32e138f6ab6b9a17249c2c2a385
2021-08-19 10:02:46 +00:00
Treehugger Robot
2af1e3f802 Merge "Fully remove deprecated --no-test-mapping argument." am: 52469f2093 am: 7622c162e6 am: 313f801fc6
Original change: https://android-review.googlesource.com/c/platform/development/+/1798316

Change-Id: Ieba64055153db6298c1f81ec5439a6ab5cce4a64
2021-08-19 09:54:58 +00:00
Treehugger Robot
313f801fc6 Merge "Fully remove deprecated --no-test-mapping argument." am: 52469f2093 am: 7622c162e6
Original change: https://android-review.googlesource.com/c/platform/development/+/1798316

Change-Id: I6916157eddf577474f2bc6f7c356c737632dffe8
2021-08-19 09:44:32 +00:00
Treehugger Robot
7622c162e6 Merge "Fully remove deprecated --no-test-mapping argument." am: 52469f2093
Original change: https://android-review.googlesource.com/c/platform/development/+/1798316

Change-Id: Icdc72b87817fcaf3b8ce69c0b240ec0aec1c5335
2021-08-19 09:19:41 +00:00
Treehugger Robot
52469f2093 Merge "Fully remove deprecated --no-test-mapping argument." 2021-08-19 09:01:26 +00:00
Colin Cross
dc268f7d34 [automerger skipped] Merge "Add explicit exported tags" into sc-dev-plus-aosp am: 3955a5947b am: 2dd47af555 am: cc0c6ae999 -s ours
am skip reason: Merged-In Ifd07672da0141c74ad32613a17691c6cd09e54de with SHA-1 7512a62755 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/15599789

Change-Id: I578e6abda472d8d337e3c702a0551eb40c9c6734
2021-08-19 00:19:37 +00:00
Colin Cross
cc0c6ae999 Merge "Add explicit exported tags" into sc-dev-plus-aosp am: 3955a5947b am: 2dd47af555
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/15599789

Change-Id: Ibd17d67160c66ab2c5c60d008505ae7962a294ea
2021-08-19 00:06:47 +00:00
Colin Cross
2dd47af555 Merge "Add explicit exported tags" into sc-dev-plus-aosp am: 3955a5947b
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/15599789

Change-Id: I5b142122251bec815677eafdb1c0667d26772a3f
2021-08-18 22:08:52 +00:00
Colin Cross
3955a5947b Merge "Add explicit exported tags" into sc-dev-plus-aosp 2021-08-18 21:54:27 +00:00
Treehugger Robot
ce94ea7003 Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb am: 5b72622eba am: d66dd9da46 am: eafc8734a5 am: 40d314d0aa
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: I9dd89fc6cf8a585337306798e764da876b0e0968
2021-08-18 20:17:59 +00:00
Treehugger Robot
40d314d0aa Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb am: 5b72622eba am: d66dd9da46 am: eafc8734a5
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: If517dc76118669142b287a21dd02809eafcb064f
2021-08-18 19:55:12 +00:00
Treehugger Robot
eafc8734a5 Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb am: 5b72622eba am: d66dd9da46
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: I7c45d3982dc6293cd0d42f9cbc7ab6430e8fc0cf
2021-08-18 19:44:34 +00:00
Treehugger Robot
d66dd9da46 Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb am: 5b72622eba
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: Iccb0024f5dae64030d065191bce59dbdae2e40e9
2021-08-18 19:24:33 +00:00
Treehugger Robot
5b72622eba Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: I12f9c1334b7e1b042b745a383a5facd20eb71d96
2021-08-18 19:11:55 +00:00
Treehugger Robot
571c6e4ecb Merge "Add test to the MapParser class in OTA_analyzer." 2021-08-18 18:58:09 +00:00
Joel Galenson
c3bfaf8a1e Fully remove deprecated --no-test-mapping argument.
This argument has already been deprecated, but now there should be no
more uses of it.  Let's remove it and the remaining logic.

Test: Run the updater.
Change-Id: I8ab6f6fadba3b462567237d18ddc02cc4c22e62f
2021-08-18 09:39:36 -07:00
Joel Galenson
e4744485e6 Merge "Do not dump the --config argument." am: a4648dfcba am: 8756774265 am: f37fb782d0 am: e9ea77e619 am: d5538f6ed0
Original change: https://android-review.googlesource.com/c/platform/development/+/1798415

Change-Id: Id3fba328dc146ce76583da1ca024a4d86f2f5ea4
2021-08-18 16:10:42 +00:00
lishutong
fce8266b7e Add test to the MapParser class in OTA_analyzer.
Add unit test to the MapParser class in map_parser.js. Please refer to
this CL for the original class definition:

https://android-review.googlesource.com/c/platform/development/+/1760909

Test: npm run test:unit
Change-Id: I2d640e9c5e27c0a012e32b4be09348034b67b235
2021-08-18 16:06:32 +00:00
Joel Galenson
d5538f6ed0 Merge "Do not dump the --config argument." am: a4648dfcba am: 8756774265 am: f37fb782d0 am: e9ea77e619
Original change: https://android-review.googlesource.com/c/platform/development/+/1798415

Change-Id: I48d3f4eed17b6f5a2a3ef9130e96056ae78895a1
2021-08-18 15:55:36 +00:00
Joel Galenson
e9ea77e619 Merge "Do not dump the --config argument." am: a4648dfcba am: 8756774265 am: f37fb782d0
Original change: https://android-review.googlesource.com/c/platform/development/+/1798415

Change-Id: Ic944bd3abfe6e4aa431019caaa608b3ad30371f2
2021-08-18 15:42:19 +00:00
Joel Galenson
f37fb782d0 Merge "Do not dump the --config argument." am: a4648dfcba am: 8756774265
Original change: https://android-review.googlesource.com/c/platform/development/+/1798415

Change-Id: Ia201420cf133ca42c42dfc2dc65c364ed49f2cb2
2021-08-18 15:32:39 +00:00