Commit Graph

33173 Commits

Author SHA1 Message Date
Treehugger Robot
f3cd490aed Merge "Fix the comparison between opaque parameters" am: 1caa406e30
Original change: https://android-review.googlesource.com/c/platform/development/+/2238125

Change-Id: I73ad577c316b6a8c74c6da6b28a95230037e5ccc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-07 02:40:49 +00:00
Treehugger Robot
1caa406e30 Merge "Fix the comparison between opaque parameters" 2022-10-07 02:07:49 +00:00
Hsin-Yi Chen
5cc255dee6 Fix the comparison between opaque parameters
Function parameters can be opaque and have no size information. For
example, __va_list in AArch64 ABI. header-abi-diff considers opaque
types compatible if their mangled names are the same.

The mangled name of __va_list can be _ZTI9__va_list or _ZTISt9__va_list.
They are also compatible.

Test: ./test.py
Bug: 248418092
Change-Id: I812abcabb620301eb575c54c7e3d2ff63dade488
2022-10-06 15:46:16 +08:00
Inseob Kim
f4cbf12fa2 Merge "Add overrides support for snapshots" am: f6e13d426b
Original change: https://android-review.googlesource.com/c/platform/development/+/2238539

Change-Id: I013a576650aeb4138708ff3d145acc052ed6ece7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-06 00:09:53 +00:00
Inseob Kim
f6e13d426b Merge "Add overrides support for snapshots" 2022-10-05 23:43:00 +00:00
Hsin-Yi Chen
5e8fd40e2d Merge "Simplify the error message for ABI check" am: acccadc399
Original change: https://android-review.googlesource.com/c/platform/development/+/2238114

Change-Id: Ic8d6a65e6231a934428ab5a33c5899734a7956fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 05:35:48 +00:00
Hsin-Yi Chen
acccadc399 Merge "Simplify the error message for ABI check" 2022-10-05 05:13:20 +00:00
Hsin-Yi Chen
2b3d297c0b Merge "Do not allow extending pass-by-value parameters or return types" am: fc212f2a34
Original change: https://android-review.googlesource.com/c/platform/development/+/2236034

Change-Id: I86802aa767981cd78a31ab2d62fc9fe22cbc8ad0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-05 02:25:43 +00:00
Hsin-Yi Chen
f5f04a5b6c Simplify the error message for ABI check
- Remove "VNDK" from the message.
- Deprecate -elf-unreferenced-symbol-errors.
- Fix the status string for CompatibilityStatusIR::UnreferencedChanges.

Test: ./test.py
Bug: 249324120
Change-Id: I5a1fd64f9101caa29d87d9f65bd4d17b8bd77059
2022-10-05 10:13:41 +08:00
Hsin-Yi Chen
fc212f2a34 Merge "Do not allow extending pass-by-value parameters or return types" 2022-10-05 02:03:26 +00:00
Inseob Kim
1c56623fac Add overrides support for snapshots
Overrides properties will now be captured in json flag files, which will
be copied to installed vendor snapshot modules.

Bug: 216567575
Test: soong test && manual install
Change-Id: I921a19b978b17812e830d15df562d217e4e51f73
2022-10-04 14:45:06 +09:00
Treehugger Robot
e6b29979c9 Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" am: f8a1fc304c
Original change: https://android-review.googlesource.com/c/platform/development/+/2237051

Change-Id: I4b778c7f65621f2882b2dd869a5e2641ff5c3982
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-03 05:23:53 +00:00
Treehugger Robot
f8a1fc304c Merge "idegen: Migrate try-finally to try-with-resources for Configuration.java" 2022-10-03 04:50:00 +00:00
utzcoz
e381c93d13 idegen: Migrate try-finally to try-with-resources for Configuration.java
Test: run idegen.sh to generate files for IntelliJ without error

Signed-off-by: utzcoz <utzcoz@gmail.com>
Change-Id: If1066d236ef44aff6b9f73a40751ad232a80f6f9
2022-10-01 10:04:48 +00:00
Treehugger Robot
e78fac030c Merge "idegen: Handle symbolic link that targets to current or parent directory" am: d6c9ae2806
Original change: https://android-review.googlesource.com/c/platform/development/+/2203929

Change-Id: I539afd4eaa4a467e509433109856749c6f82c5bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-30 06:42:13 +00:00
Treehugger Robot
d6c9ae2806 Merge "idegen: Handle symbolic link that targets to current or parent directory" 2022-09-30 06:23:50 +00:00
Hsin-Yi Chen
4384b4cdd0 Merge "Allow adding class/struct members to padding space" am: 4f2576b93a
Original change: https://android-review.googlesource.com/c/platform/development/+/2238294

Change-Id: Ie1af62f6a9d164dcfea2c0ff988357b622b2e6b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-30 02:36:25 +00:00
Hsin-Yi Chen
4f2576b93a Merge "Allow adding class/struct members to padding space" 2022-09-30 02:09:39 +00:00
Hsin-Yi Chen
9f22a276fd Allow adding class/struct members to padding space
This commit removes the comparison between class size and member offsets
from RecordTypeDiffIR::IsExtended. New members can be added to padding
space in a class without changing the existing members.

Test: ./test.py
Bug: 248418092
Change-Id: I34d002478f1dcfd3c183e76899917e602de2b4c1
2022-09-29 19:49:41 +08:00
Hsin-Yi Chen
d875d513f2 Do not allow extending pass-by-value parameters or return types
Resizing the parameters or return types changes the stack layout. It
is not an allowed extension to functions.
AbiDiffHelper::CompareFunctionTypes additionally checks the sizes of the
parameters and the return types. The difference cannot be ignored by
-allow-extensions. The user who intends to ignore the difference should
specify -ignore-symbols or -ignore-linker-set-key.

Test: ./test.py
Bug: 248418092
Change-Id: Ibef3b9260504afff3fc0260b0565736133b8e0dc
2022-09-28 10:59:51 +00:00
Hsin-Yi Chen
f3c5194bf2 Merge "Allow appending members to structs and classes" am: efd3826863
Original change: https://android-review.googlesource.com/c/platform/development/+/2229078

Change-Id: I86f9478f3177fbb4b0c96e7d4f3c6b91aa64f6c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 09:41:08 +00:00
Hsin-Yi Chen
efd3826863 Merge "Allow appending members to structs and classes" 2022-09-28 09:18:15 +00:00
Hsin-Yi Chen
8c7213fa16 Merge "Delete VNDK definition tools" am: e0d81eed8f
Original change: https://android-review.googlesource.com/c/platform/development/+/2216377

Change-Id: Id674e3121dd72b032a2afae98f2eb6545420d727
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-28 04:51:51 +00:00
Hsin-Yi Chen
e0d81eed8f Merge "Delete VNDK definition tools" 2022-09-28 04:24:25 +00:00
Hsin-Yi Chen
cdf49db15c Allow appending members to structs and classes
This commit adds RecordTypeDiffIR::IsExtended() that determines whether
the difference is a pure extension, i.e., appending members and
increasing the size. The extensions are stored in
record_type_extension_diffs in abi_diff messages. They can be ignored by
specifying -allow-extensions.

Test: ./test.py
Bug: 248418092
Change-Id: Ibdef042c6176dc84d2dd61f71a3f88035e943dd4
2022-09-28 12:18:01 +08:00
Treehugger Robot
b119c3792c Merge "Add FLAG_IMMUTABLE to PendingIntents" am: a3aa817aa5
Original change: https://android-review.googlesource.com/c/platform/development/+/2229375

Change-Id: I922df5e7b14e99bc925e77f33acfd6abeb0785a0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-24 01:03:57 +00:00
Treehugger Robot
a3aa817aa5 Merge "Add FLAG_IMMUTABLE to PendingIntents" 2022-09-24 00:24:30 +00:00
Cole Faust
f4dc2d5f25 Add FLAG_IMMUTABLE to PendingIntents
If your app targets Android 12, you must specify the mutability of each PendingIntent
object that your app creates. This additional requirement improves your app's security.
https://developer.android.com/about/versions/12/behavior-changes-12#pending-intent-mutability

Android Lint is being updated, and adds an error-level check for this.

Bug: 247885568
Test: Presubmits
Change-Id: I2bb91d98b443af2b5c16944ce197d863dbd33f9a
2022-09-23 15:17:52 -07:00
Hsin-Yi Chen
7995aca67b Merge "Filter added or removed types by -ignore-linker-set-key" am: adc960d590
Original change: https://android-review.googlesource.com/c/platform/development/+/2223129

Change-Id: Ic6b0eb48506a5477f4bdf9ef1f32b9a37b80ec77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-23 03:49:12 +00:00
Hsin-Yi Chen
adc960d590 Merge "Filter added or removed types by -ignore-linker-set-key" 2022-09-23 03:31:49 +00:00
Hsin-Yi Chen
7c5e16840f Merge "Add linker_set_key to RecordTypeDiff and EnumTypeDiff" am: cc90871286
Original change: https://android-review.googlesource.com/c/platform/development/+/2218448

Change-Id: I8623206b3d79d6710340e94ed39a62fbcccc4fef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-22 07:39:01 +00:00
Hsin-Yi Chen
cc90871286 Merge "Add linker_set_key to RecordTypeDiff and EnumTypeDiff" 2022-09-22 07:00:47 +00:00
Treehugger Robot
d42dd28394 Merge "Move SdkSetup app into device/generic/goldfish" am: 16a8d0fa8e
Original change: https://android-review.googlesource.com/c/platform/development/+/2221506

Change-Id: If594341755591e895469aeca474d9b64067e8079
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-21 21:32:36 +00:00
utzcoz
97a3f307a6 idegen: Handle symbolic link that targets to current or parent directory
Test: run idegen.sh to generate files for IntelliJ without error

Signed-off-by: utzcoz <utzcoz@gmail.com>
Change-Id: I80958e94f93a8e1ef546bc34bd929d04a224dc9e
2022-09-21 22:03:49 +08:00
Hsin-Yi Chen
37792200d3 Filter added or removed types by -ignore-linker-set-key
Test: development/vndk/tools/header-checker/tests/test.py
Bug: 243903630
Change-Id: I103779591cf8f52f9178d33ad5a205ca4eaaba2f
2022-09-21 09:00:40 +00:00
Hsin-Yi Chen
00d8159166 Add linker_set_key to RecordTypeDiff and EnumTypeDiff
RecordTypeDiff and EnumTypeDiff in abi_diff.proto contain linker set
keys. The developers can copy them to the ignore list. The other Diff
messages do not need the field because it's in the messages imported
from abi_dump.proto.

Test: Update prebuilts/clang-tools; make libz
Bug: 243903630
Change-Id: I1e90d3c6cbfd09d72b3fdb244a4079ae899630aa
2022-09-21 16:50:58 +08:00
Treehugger Robot
16a8d0fa8e Merge "Move SdkSetup app into device/generic/goldfish" 2022-09-20 22:15:01 +00:00
Roman Kiryanov
a60ef1b115 Move SdkSetup app into device/generic/goldfish
this app is designed for emulator

Bug: 247004472
Test: presubmit
Signed-off-by: Roman Kiryanov <rkir@google.com>
Change-Id: I3fa6178d51551bc3540d03827dea17d5abba06c7
2022-09-19 16:33:48 -07:00
Pirama Arumuga Nainar
7c1eb9cfe1 Merge "Update clang-tools build to clang-r458507" am: dafc6d0793
Original change: https://android-review.googlesource.com/c/platform/development/+/2220861

Change-Id: Idbdb71ecefb52da0ee9b2e7ec92f23799d5ed999
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 20:28:35 +00:00
Pirama Arumuga Nainar
dafc6d0793 Merge "Update clang-tools build to clang-r458507" 2022-09-19 20:02:41 +00:00
Krzysztof Kosiński
6fdc0d453f Merge "Remove Python enables identical to global defaults." am: 5acfb41d4a
Original change: https://android-review.googlesource.com/c/platform/development/+/2220481

Change-Id: I9b9bc00b756f4f680a21b02065e6f32c2263fd85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 17:06:23 +00:00
Krzysztof Kosiński
5acfb41d4a Merge "Remove Python enables identical to global defaults." 2022-09-19 16:08:47 +00:00
Pirama Arumuga Nainar
2e6f159eae Update clang-tools build to clang-r458507
Bug: http://b/236798112
Bug: http://b/244486343
Test: presubmit
Change-Id: Icff1712b289925901582f5429bfea3fde1834eec
2022-09-19 05:16:10 +00:00
Krzysztof Kosiński
45c7ebda06 Remove Python enables identical to global defaults.
Bug: 245854393
Test: presubmit
Change-Id: I9bb5cbd972432a26afcb13d7c2a6bbc73fb0991f
2022-09-17 11:33:50 +00:00
Hsin-Yi Chen
f38939ac24 Delete VNDK definition tools
The tools have not been maintained since Android 11.
vndk-lib-extra-list-*.txt are not deleted because VTS depends on them.

Test: make
Bug: 247032590
Change-Id: Iafaf98d13e77edea34a45c84ac44804703aa6d24
2022-09-16 14:37:04 +08:00
Treehugger Robot
b69a8ac2ea Merge "Revert "Revert "Add license metadata to non-module targets.""" am: 01cd913312
Original change: https://android-review.googlesource.com/c/platform/development/+/2215211

Change-Id: I0e8b71fc1a4ffa10a447c8db0e47d741654a384c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 19:19:37 +00:00
Treehugger Robot
01cd913312 Merge "Revert "Revert "Add license metadata to non-module targets.""" 2022-09-14 18:48:30 +00:00
Matthew Maurer
d0d91303e2 Merge changes I78bc86ad,Ieeab8376 am: 16ed4a3cc3
Original change: https://android-review.googlesource.com/c/platform/development/+/2215842

Change-Id: I5b7bee417d614ecf6994b0eafd84934ac919891d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 15:08:07 +00:00
Matthew Maurer
16ed4a3cc3 Merge changes I78bc86ad,Ieeab8376
* changes:
  c2a: Legacy cleanup
  c2a: Parse new cargo output
2022-09-14 14:41:30 +00:00
Treehugger Robot
ca55840d51 Merge "add u option(unbundled build) in build_vendor.sh" am: 43ee75e845
Original change: https://android-review.googlesource.com/c/platform/development/+/2216242

Change-Id: Ia39807c63b5a78300e7ac3db021481ad2fb2c17b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 06:45:54 +00:00