LineageOS/android_external_libcxx
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace assert(true) in tests with actual asserts. Reviewed as https://reviews.llvm.org/D40324

Browse Source 
In a17cd7c641 Marshall added assert(true) to the vector<bool>::size tests, which break on C1XX:

D:\Contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(62): error C2220: warning treated as error - no 'object' file generated
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(33) : warning C6326: Potential comparison of a constant with another constant.
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(52) : warning C6326: Potential comparison of a constant with another constant.

The corresponding test for vector::size asserts assert(c.size() == 3);, so I changed it to do that here.

git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@318812 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Billy Robert O'Neal III
2017-11-21 23:03:02 +00:00
parent abba9f214b
commit 9af08238a7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/std/containers/sequences/vector.bool/size.pass.cpp
View File

@@ -31,7 +31,7 @@ int main()
c.push_back(true);
assert(c.size() == 2);
c.push_back(C::value_type(3));
assert(true);
assert(c.size() == 3);
c.erase(c.begin());
assert(c.size() == 2);
c.erase(c.begin());
@@ -50,7 +50,7 @@ int main()
c.push_back(true);
assert(c.size() == 2);
c.push_back(C::value_type(3));
assert(true);
assert(c.size() == 3);
c.erase(c.begin());
assert(c.size() == 2);
c.erase(c.begin());