Commit Graph

20653 Commits

Author SHA1 Message Date
Johann
652beb6ac1 trivial: fix spelling errors
Found when updating a downstream client.

Change-Id: Ibaa20d883ebfea9410d0252e7a19c7acdb78c907
2020-01-10 15:59:30 -08:00
Jerome Jiang
ba7f9f38c9 Merge "Fix test failure with --size-limit" 2020-01-10 06:00:31 +00:00
Jerome Jiang
99284cb118 Fix test failure with --size-limit
The test didn't verify expected error code with invalid sizes. It
assumed VPX_CODEC_OK.

Added new Encoder class which doesn't run decoding at all. It accepts
expected error code to verify with encoder output.

The encoder behavior was changed in 94a65e8.

BUG=webm:1670

Change-Id: I6324d8f744e6c4aa82aa66913923dc140b07bfc9
2020-01-09 19:59:14 -08:00
Clement Courbet
ccb06a9fb1 Avoid reloads in vp9_read_mode_info.
The compiler cannot prove that the buffers do not alias, so it has to emit a
reload. On our internal workloads, the reloads are about 1% of the total time
spent decoding frames.

The loop before the change:

movzwl 0x8(%r15), %edx       # load ref_frame
addq $0xc, %rax
movw %dx, -0x4(%rax)         # store ref_frame
movq 0xc(%r15), %rdx         # load mv
movq %rdx, -0xc(%rax)        # store mv
cmpq %rax, %rcx
jne -0x1a

The loop after the change:

movw %r9w, 0x8(%rax)         # store cached ref_frame
addq $0xc, %rax
movq %r8, -0xc(%rax)         # store cached mv
cmpq %rax, %rdx
jne -0x12

Change-Id: Ia1e9634bcabb4d7e06ed60f470bc4cd67f5ab27e
2020-01-07 17:04:36 +01:00
Johann
50d1a4aa72 Merge remote-tracking branch 'origin/pekin'
Change-Id: I6f8e21696023fa4067960a7dedb6e7bbdb531ff9
2019-12-19 14:24:23 -08:00
Johann Koenig
d99a0bc769 Merge "vp8: move error check earlier" 2019-12-18 06:01:54 +00:00
Johann Koenig
67aa6c8c23 Merge "trivial: remove reference to error correction" 2019-12-17 20:44:58 +00:00
Johann Koenig
f5d2cc293c Merge "trivial: fix 'fragment' spelling" 2019-12-17 20:22:07 +00:00
Johann
d1e872e1b9 vp8: move error check earlier
This avoids assigning variables which will not be used. A
similar change was made to vpx_dsp/bitreader.c a long time
ago.

Change-Id: Ia5012091b8d85ca9bfefc7735a2aa69c5c2bf516
2019-12-17 11:44:29 -08:00
Johann Koenig
8a30a2a450 Merge "vp8 boolreader: ignore invalid input" 2019-12-17 19:41:23 +00:00
angiebird
ace8ab89b7 Rename encode_frame_index
to next_encode_frame_index

Change-Id: Id9bd2a0f6c4278bf0f0c270eb937a317232dead6
2019-12-16 15:19:35 -08:00
angiebird
56f51daecb Add start_show_index/show_frame_count
to GroupOfPicture

Change-Id: I905be72686b6c0e27ea782a12f1e8a8176c8b0f5
2019-12-16 15:07:51 -08:00
angiebird
01347cd62c Cosmetic change of update_encode_frame_result()
Move output parameter to the end.

Change-Id: I579a118768d29cb1ae2e3c8995a952ef11cfeb8d
2019-12-13 11:15:12 -08:00
angiebird
bfa9d015b0 Move psnr/sse computation under RATE_CTRL flag
in update_encode_frame_result()

Change-Id: Ie86d11f66744ef95dd224c7daf325750a5e5458b
2019-12-13 11:15:12 -08:00
angiebird
b4a8ac3c46 Add detailed description about GroupOfPicture
Change-Id: I96a447e59bdcf156ab6fbf9e766d867633ca47f3
2019-12-13 11:15:05 -08:00
angiebird
fadfea8a6a Cosmetic change of vp9_get_gop_coding_frame_count
Move the output parameter to the end.

Change-Id: I39c718b683a76cd7c5998724c3a07e88275198bf
2019-12-12 12:15:33 -08:00
angiebird
a53b7e53e8 Add GetFramePixelCount to SimpleEncode
Gets the total number of pixels of YUV planes per frame.

Change-Id: Ifdf35190cdde1378de6d7e93ab4428868a5795fa
2019-12-12 12:03:28 -08:00
angiebird
204ba94f4b Cosmetic changes for RATE_CTRL related functions
Move input parameters ahead of output parameters.

Change-Id: I384f69523b6be92224535d05373ebb33467a040e
2019-12-11 15:43:39 -08:00
Angie Chiang
fa370c32e7 Merge changes I54f60f62,Idbc437d3
* changes:
  Rename parameter two_pass to twopass.
  Add GetNextEncodeFrameInfo ObserveGroupOfPicture
2019-12-11 00:42:01 +00:00
angiebird
2f65eb2a00 Rename parameter two_pass to twopass.
Change-Id: I54f60f62f27f9ef96db892d5b6219c9591ce2dc9
2019-12-10 11:43:40 -08:00
angiebird
757a5e6aa9 Add GetNextEncodeFrameInfo ObserveGroupOfPicture
GetNextEncodeFrameInfo()
Gets encode_frame_info for the next coding frame.

ObserveGroupOfPicture()
Provides the group of pictures that the next coding frame is in.

Change-Id: Idbc437d32c392f25b06efb2d4e1ec01347d678f2
2019-12-10 11:41:01 -08:00
Johann
7ec7a33a08 Release v1.8.2 Pekin Duck
Fixed: webm:1661

Change-Id: Icc17635d63fbd533a084e17cc291693b9a453887
2019-12-09 15:09:20 -08:00
Angie Chiang
9c46931645 Merge changes I41ff04bb,I3d88d719
* changes:
  Set frames_since_key in vp9_get_coding_frame_num
  Add vp9_get_gop_coding_frame_count()
2019-12-09 22:15:50 +00:00
angiebird
38a4e46fd3 Set frames_since_key in vp9_get_coding_frame_num
Set frames_since_key to 0 whenever a key frame appears.

Add dependency notes to get_gop_coding_frame_num()

Change-Id: I41ff04bb1c6176e60946b05fe21c72fbb82be62a
2019-12-09 14:14:11 -08:00
angiebird
c33f859615 Add vp9_get_gop_coding_frame_count()
Call this function before coding a new group of picture to get
information about it.

Change-Id: I3d88d719dd27c6d7383eb8f92307a93096b30706
2019-12-09 14:13:53 -08:00
Debargha Mukherjee
b7e03724b3 Merge "Merge Timestamp TestVpxRollover tests for Vp8/Vp9" 2019-12-07 02:10:33 +00:00
Debargha Mukherjee
65e0663f06 Merge Timestamp TestVpxRollover tests for Vp8/Vp9
BUG=webm:701

Change-Id: Id0b928db3cbb6263d136d7b9eb8d9453b3c63824
2019-12-06 15:52:25 -08:00
angiebird
94fb57d3a5 Add GetKeyFrameGroupSize()
Makes vp9_get_frames_to_next_key() public.

Change-Id: I903cefbb3925d6ffc641412c6d60d95a2ff256a4
2019-12-06 15:03:23 -08:00
James Zern
efa05b7cc9 configure.sh,darwin: fix asm conv w/external build
always set asm_conversion_cmd as e.g., vpx_config.asm may still be
generated with make when using --enable-external-build

BUG=webm:1535

Change-Id: I120452d4e06580b67119aee8d0a710998ac87a7a
2019-12-06 13:18:37 -08:00
Wan-Teh Chang
f835ab7608 Fix argv leak on Unrecognized input file type err
Free argv (allocated by argv_dup) after the
"Unrecognized input file type" error.

Change-Id: I2b6273a1abca2ff8e51445fb15839bd993c41741
2019-12-06 10:42:49 -08:00
Debargha Mukherjee
04383393e4 Add missing typecast and re-enable timestamp test
BUG=webm:701

Change-Id: I1d8a6e263fddb9e4cc6265a313011a18d18bbf9e
2019-12-05 19:15:53 -08:00
Johann
92ce61dded trivial: fix 'fragment' spelling
Change-Id: I71b17f3dcb72d5cb2c1d7fe94dd5228433c6eef5
2019-12-04 15:10:19 -08:00
Johann
69022e9f41 trivial: remove reference to error correction
vp9 does not support error correction

Change-Id: I89517ae97abfa60833c9150495556d49c9656778
2019-12-04 15:07:12 -08:00
Johann
80e5666cdc vp8 boolreader: ignore invalid input
Do basic initialization even when the result will not be used.

BUG=chromium:1026961

Change-Id: Iaa480534b49efe1ecc66484b316f8d654e8a1245
2019-12-04 14:01:28 -08:00
Jerome Jiang
1d49040369 remove init_motion_estimation from update_initial_width
Change-Id: I04da24eb6a87425490b25e50ead7a8fd8117e7cb
2019-12-04 12:46:56 -08:00
Angie Chiang
3609eca0c4 Merge "Fix the encode inconsistency of SimpleEncode" 2019-12-04 20:26:28 +00:00
Angie Chiang
8cb34dd640 Merge "Describe ObserveFirstPassStats with more details" 2019-12-04 19:31:02 +00:00
angiebird
42916ce604 Fix the encode inconsistency of SimpleEncode
Make sure restore_coding_context() is always called in the end
of encode_with_recode_loop().

Add EncodeConsistencyTest.

Change-Id: I3c8e4c8fcff4e3f7afef9bec469beef2a5fb6eeb
2019-12-03 18:33:10 -08:00
angiebird
f0878a719a Describe ObserveFirstPassStats with more details
Change-Id: I7c15aeaf0c0884b7c7b265fb03fbbb9ccc6b73be
2019-12-03 18:32:48 -08:00
Debargha Mukherjee
89375f0315 Merge "Avoid dividing by 0 in vp8 gf_group bits compute" 2019-12-03 02:29:30 +00:00
Debargha Mukherjee
5eeabfffcb Avoid dividing by 0 in vp8 gf_group bits compute
BUG=webm:1653

Change-Id: Ic59fe5e573f08dbca678d3927d4a750ae75f903c
2019-12-02 14:49:50 -08:00
Jerome Jiang
d2a5e26359 Fix SVC regression in webrtc tests.
BUG=1029438

Change-Id: I4495fc7bb45e77e9d91059a5c6c4695d8da1bf34
2019-12-02 12:20:17 -08:00
James Zern
2ba45e8291 Merge "Fix mutex free in multi-thread lpf" 2019-12-02 20:16:33 +00:00
Venkatarama NG. Avadhani
b4e0986391 Fix mutex free in multi-thread lpf
The mutex lf_mutex will now be allocated and destroyed, making it easier
to verify if it has been inited before destruction.

BUG=webm:1662

Change-Id: I8169bea9e117bd615d68b8d02da98aeab570b53f
2019-11-27 08:56:32 +05:30
Johann Koenig
b8549ed889 Merge "fix __has_attribute in visual studio" 2019-11-26 14:44:15 +00:00
angiebird
8d211a3969 Make GetCodingFrameNum const function
Change-Id: I6a5a2400cfb6e122c77667e0950c80026c48a1f6
2019-11-25 10:38:16 -08:00
angiebird
ef263a11fe Add missing includes to simple_encode.h
Change-Id: Ic3bb2450443c52ba3df1ed6729cecdab51245e76
2019-11-25 10:37:53 -08:00
angiebird
85108a55b2 Correct typo in simple_encode.h
Change-Id: Ifa858acad8b943d1579283fd1c72ff41434c0710
2019-11-25 10:37:25 -08:00
angiebird
2157d613c5 Cosmetic change of GetBitrateInKbps
Change-Id: Id4b852cdfba0f6fa1e12a05e2617df0de395be9d
2019-11-25 10:37:07 -08:00
Angie Chiang
30c669ca87 Merge "Change vp9_get_encoder_config." 2019-11-25 18:34:26 +00:00