LineageOS/android_hardware_libhardware
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dynamic_sensor: Improve error logging

Browse Source 
Correctly pass errno to strerror() rather than the return value, which
will always be -1 on error.

Fixes: 245585769
Test: build only
Change-Id: Iae1170949f3b2a0286ef8b9ddf26c74a6cee6783
This commit is contained in:
Brian Duddie
2022-09-07 19:34:47 +00:00
parent 6f1044deef
commit 7aad531bc9
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
modules/sensors/dynamic_sensor/HidRawDevice.cpp
View File

@@ -204,7 +204,7 @@ bool HidRawDevice::getFeature(uint8_t id, std::vector<uint8_t> *out) {
int res = ::ioctl(mDevFd, HIDIOCGFEATURE(size), mIoBuffer.data());
if (res < 0) {
LOG_E << "HidRawDevice::getFeature: feature " << static_cast<int>(id)
<< " ioctl returns " << res << " (" << ::strerror(res) << ")" << LOG_ENDL;
<< " ioctl returned " << res << ", errno: " << ::strerror(errno) << LOG_ENDL;
return false;
}
@@ -249,8 +249,8 @@ bool HidRawDevice::setFeature(uint8_t id, const std::vector<uint8_t> &in) {
std::copy(in.begin(), in.end(), &mIoBuffer[1]);
int res = ::ioctl(mDevFd, HIDIOCSFEATURE(size), mIoBuffer.data());
if (res < 0) {
LOG_E << "HidRawDevice::setFeature: feature " << id << " ioctl returns " << res
<< " (" << ::strerror(res) << ")" << LOG_ENDL;
LOG_E << "HidRawDevice::setFeature: feature " << id << " ioctl returned " << res
<< ", errno: " << ::strerror(errno) << LOG_ENDL;
return false;
}
return true;
@@ -287,8 +287,8 @@ bool HidRawDevice::sendReport(uint8_t id, std::vector<uint8_t> &data) {
res = ::write(mDevFd, data.data(), size);
}
if (res < 0) {
LOG_E << "HidRawDevice::sendReport: output " << id << " write returns " << res
<< " (" << ::strerror(res) << ")" << LOG_ENDL;
LOG_E << "HidRawDevice::sendReport: output " << id << " write returned "
<< res << ", errno: " << ::strerror(errno) << LOG_ENDL;
return false;
}
return true;
@@ -302,8 +302,8 @@ bool HidRawDevice::receiveReport(uint8_t *id, std::vector<uint8_t> *data) {
uint8_t buffer[256];
int res = ::read(mDevFd, buffer, 256);
if (res < 0) {
LOG_E << "HidRawDevice::receiveReport: read returns " << res
<< " (" << ::strerror(res) << ")" << LOG_ENDL;
LOG_E << "HidRawDevice::receiveReport: read returned " << res
<< ", errno: " << ::strerror(errno) << LOG_ENDL;
return false;
}