LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove two new permission checks

Browse Source 
These checks while technically reasonable are a hard to swallow API change
that may break existing apps and pragmatically serves no purpose:  the protected
data is available in publicly readable java VM properties.

Change-Id: I522c493c2604a33e28d99e2be31054326c9a8323
This commit is contained in:
Robert Greenwalt
2013-02-22 14:57:00 -08:00
parent faa4b403d9
commit 0e0ae8a849
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
services/java/com/android/server/ConnectivityService.java
View File

@@ -2999,7 +2999,10 @@ public class ConnectivityService extends IConnectivityManager.Stub {
} }
public ProxyProperties getProxy() { public ProxyProperties getProxy() {
enforceAccessPermission(); // this information is already available as a world read/writable jvm property
// so this API change wouldn't have a benifit. It also breaks the passing
// of proxy info to all the JVMs.
// enforceAccessPermission();
synchronized (mDefaultProxyLock) { synchronized (mDefaultProxyLock) {
return mDefaultProxyDisabled ? null : mDefaultProxy; return mDefaultProxyDisabled ? null : mDefaultProxy;
} }
@@ -3051,7 +3054,10 @@ public class ConnectivityService extends IConnectivityManager.Stub {
} }
public ProxyProperties getGlobalProxy() { public ProxyProperties getGlobalProxy() {
enforceAccessPermission(); // this information is already available as a world read/writable jvm property
// so this API change wouldn't have a benifit. It also breaks the passing
// of proxy info to all the JVMs.
// enforceAccessPermission();
synchronized (mGlobalProxyLock) { synchronized (mGlobalProxyLock) {
return mGlobalProxy; return mGlobalProxy;
} }