LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Error Prone errors

Browse Source 
Soong wasn't including android_app or android_test sources in the
javac-check target used for the Error Prone build, which allowed
some Error Prone errors to get in.  Fix them so Error Prone can be
re-enabled for these targets.

Fixes:
cts/hostsidetests/net/app/src/com/android/cts/net/hostside/RequiredPropertiesRule.java:61: error: [CollectionIncompatibleType] Argument '~requiredProperty.getValue()' should not be passed to this method; its type int is not compatible with its collection's type argument Property

Bug: 146455923
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: I7c5bf823bf371902285ce3ee3929796fa40c653b
Merged-In: I48b1ccb61c807d0b41a165298ef5981258d6656e
This commit is contained in:
Sudheer Shanka
2020-04-22 13:50:15 -07:00
parent 1206400ccf
commit 39cc315273
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/cts/hostside/app/src/com/android/cts/net/hostside/RequiredPropertiesRule.java
View File

@@ -58,8 +58,12 @@ public class RequiredPropertiesRule extends BeforeAfterRule {
continue;
}
for (Property requiredProperty : requiredProperties.value()) {
if (!allRequiredProperties.contains(~requiredProperty.getValue())) {
allRequiredProperties.add(requiredProperty);
for (Property p : Property.values()) {
if (p.getValue() == ~requiredProperty.getValue()) {
if (!allRequiredProperties.contains(p)) {
allRequiredProperties.add(requiredProperty);
}
}
}
}
}