am 81af1e4f: am 6c93739f: am 49f74a38: Clear process DNS NetID binding when expiring or releaseing legacy requests.

* commit '81af1e4f390a4aedb49c1405f3ea8e1b27fadbfa':
  Clear process DNS NetID binding when expiring or releaseing legacy requests.
This commit is contained in:
Paul Jensen
2015-01-06 20:09:18 +00:00
committed by Android Git Automerger

View File

@@ -935,10 +935,8 @@ public class ConnectivityManager {
return -1;
}
NetworkCallback networkCallback = removeRequestForFeature(netCap);
if (networkCallback != null) {
if (removeRequestForFeature(netCap)) {
Log.d(TAG, "stopUsingNetworkFeature for " + networkType + ", " + feature);
unregisterNetworkCallback(networkCallback);
}
return 1;
}
@@ -1105,6 +1103,14 @@ public class ConnectivityManager {
int expireSequenceNumber;
Network currentNetwork;
int delay = -1;
private void clearDnsBinding() {
if (currentNetwork != null) {
currentNetwork = null;
setProcessDefaultNetworkForHostResolution(null);
}
}
NetworkCallback networkCallback = new NetworkCallback() {
@Override
public void onAvailable(Network network) {
@@ -1114,10 +1120,7 @@ public class ConnectivityManager {
}
@Override
public void onLost(Network network) {
if (network.equals(currentNetwork)) {
currentNetwork = null;
setProcessDefaultNetworkForHostResolution(null);
}
if (network.equals(currentNetwork)) clearDnsBinding();
Log.d(TAG, "startUsingNetworkFeature lost Network:" + network);
}
};
@@ -1146,10 +1149,7 @@ public class ConnectivityManager {
LegacyRequest l = sLegacyRequests.get(netCap);
if (l == null) return;
ourSeqNum = l.expireSequenceNumber;
if (l.expireSequenceNumber == sequenceNum) {
unregisterNetworkCallback(l.networkCallback);
sLegacyRequests.remove(netCap);
}
if (l.expireSequenceNumber == sequenceNum) removeRequestForFeature(netCap);
}
Log.d(TAG, "expireRequest with " + ourSeqNum + ", " + sequenceNum);
}
@@ -1180,12 +1180,15 @@ public class ConnectivityManager {
}
}
private NetworkCallback removeRequestForFeature(NetworkCapabilities netCap) {
private boolean removeRequestForFeature(NetworkCapabilities netCap) {
final LegacyRequest l;
synchronized (sLegacyRequests) {
LegacyRequest l = sLegacyRequests.remove(netCap);
if (l == null) return null;
return l.networkCallback;
l = sLegacyRequests.remove(netCap);
}
if (l == null) return false;
unregisterNetworkCallback(l.networkCallback);
l.clearDnsBinding();
return true;
}
/**