LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Attempt "fix" the broken QUIC packet to be slightly less broken

Browse Source 
Bug: 139403355
Signed-off-by: Erik Kline <ek@google.com>
Change-Id: I9c938998b5e30f7d3994b410878b2af6a75f9b5a
This commit is contained in:
Erik Kline
2019-08-16 11:58:37 -07:00
committed by Maciej Żenczykowski
parent a9a8bf6ae3
commit aa76b34ae8
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/cts/net/jni/NativeMultinetworkJni.cpp
View File

@@ -455,13 +455,17 @@ JNIEXPORT jint Java_android_net_cts_MultinetworkApiTest_runDatagramCheck(
setsockopt(fd, SOL_SOCKET, SO_SNDTIMEO, &timeo, sizeof(timeo));
// For reference see:
// https://tools.ietf.org/html/draft-tsvwg-quic-protocol-01#section-6.1
uint8_t quic_packet[] = {
0x0c, // public flags: 64bit conn ID, 8bit sequence number
// https://tools.ietf.org/html/draft-tsvwg-quic-protocol#section-6.1
uint8_t quic_packet[1200] = {
0x0d, // public flags:
// - version present (0x01),
// - 64bit connection ID (0x0c),
// - 1 byte packet number (0x00)
0, 0, 0, 0, 0, 0, 0, 0, // 64bit connection ID
0x01, // sequence number
0xaa, 0xda, 0xca, 0xaa, // reserved-space version number
1, // 1 byte packet number
0x00, // private flags
0x07, // type: regular frame type "PING"
0x07, // PING frame (cuz why not)
};
arc4random_buf(quic_packet + 1, 8); // random connection ID
@@ -489,7 +493,7 @@ JNIEXPORT jint Java_android_net_cts_MultinetworkApiTest_runDatagramCheck(
i + 1, MAX_RETRIES, rcvd, errnum);
}
}
if (rcvd < sent) {
if (rcvd < 9) {
ALOGD("QUIC UDP %s: sent=%zd but rcvd=%zd, errno=%d", kPort, sent, rcvd, errnum);
if (rcvd <= 0) {
ALOGD("Does this network block UDP port %s?", kPort);
@@ -505,8 +509,7 @@ JNIEXPORT jint Java_android_net_cts_MultinetworkApiTest_runDatagramCheck(
return -EPROTO;
}
// TODO: log, and compare to the IP address encoded in the
// response, since this should be a public reset packet.
// TODO: Replace this quick 'n' dirty test with proper QUIC-capable code.
close(fd);
return 0;