LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge changes I6a51d803,I162fae5c

Browse Source 
* changes:
  Replace hidden NMS API for setting MTU
  Replace hidden NMS default network configuration API
This commit is contained in:
Chiachang Wang
2020-10-29 05:03:43 +00:00
committed by Gerrit Code Review
parent 3fa68ae83a 6d5c0e714b
commit cbcc4ae04c
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/core/java/com/android/server/ConnectivityService.java
View File

@@ -2431,9 +2431,9 @@ public class ConnectivityService extends IConnectivityManager.Stub
try {
if (VDBG || DDBG) log("Setting MTU size: " + iface + ", " + mtu);
mNMS.setMtu(iface, mtu);
} catch (Exception e) {
Slog.e(TAG, "exception in setMtu()" + e);
mNetd.interfaceSetMtu(iface, mtu);
} catch (RemoteException | ServiceSpecificException e) {
Slog.e(TAG, "exception in interfaceSetMtu()" + e);
}
}
@@ -6700,11 +6700,11 @@ public class ConnectivityService extends IConnectivityManager.Stub
try {
if (null != newNetwork) {
mNMS.setDefaultNetId(newNetwork.network.netId);
mNetd.networkSetDefault(newNetwork.network.netId);
} else {
mNMS.clearDefaultNetId();
mNetd.networkClearDefault();
}
} catch (Exception e) {
} catch (RemoteException | ServiceSpecificException e) {
loge("Exception setting default network :" + e);
}

14
tests/net/java/com/android/server/ConnectivityServiceTest.java
View File

@@ -6023,23 +6023,23 @@ public class ConnectivityServiceTest {
mCellNetworkAgent = new TestNetworkAgentWrapper(TRANSPORT_CELLULAR);
mCellNetworkAgent.connect(true);
trustedCallback.expectAvailableThenValidatedCallbacks(mCellNetworkAgent);
verify(mNetworkManagementService).setDefaultNetId(eq(mCellNetworkAgent.getNetwork().netId));
reset(mNetworkManagementService);
verify(mMockNetd).networkSetDefault(eq(mCellNetworkAgent.getNetwork().netId));
reset(mMockNetd);
mWiFiNetworkAgent = new TestNetworkAgentWrapper(TRANSPORT_WIFI);
mWiFiNetworkAgent.connect(true);
trustedCallback.expectAvailableDoubleValidatedCallbacks(mWiFiNetworkAgent);
verify(mNetworkManagementService).setDefaultNetId(eq(mWiFiNetworkAgent.getNetwork().netId));
reset(mNetworkManagementService);
verify(mMockNetd).networkSetDefault(eq(mWiFiNetworkAgent.getNetwork().netId));
reset(mMockNetd);
mWiFiNetworkAgent.removeCapability(NET_CAPABILITY_TRUSTED);
trustedCallback.expectAvailableCallbacksValidated(mCellNetworkAgent);
verify(mNetworkManagementService).setDefaultNetId(eq(mCellNetworkAgent.getNetwork().netId));
reset(mNetworkManagementService);
verify(mMockNetd).networkSetDefault(eq(mCellNetworkAgent.getNetwork().netId));
reset(mMockNetd);
mCellNetworkAgent.removeCapability(NET_CAPABILITY_TRUSTED);
trustedCallback.expectCallback(CallbackEntry.LOST, mCellNetworkAgent);
verify(mNetworkManagementService).clearDefaultNetId();
verify(mMockNetd).networkClearDefault();
mCm.unregisterNetworkCallback(trustedCallback);
}