LineageOS/android_packages_modules_Connectivity
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add more assertions related to LocalServerSocket.accept()

Browse Source 
The isConnected() / isBound() behavior is new, the behavior
when bind() / connect() is called is not. See related
frameworks/base changes.

Test: Tests run under vogar.
Bug: https://code.google.com/p/android/issues/detail?id=35942
Change-Id: I8577212270f3b3e76ea015914eebddc0fe4a6afa
This commit is contained in:
Neil Fuller
2017-01-04 10:37:34 +00:00
parent 26fc3c1dd7
commit d9e98a6688
2 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/cts/net/src/android/net/cts/LocalServerSocketTest.java
View File

@@ -38,6 +38,9 @@ public class LocalServerSocketTest extends TestCase {
clientSocket.connect(new LocalSocketAddress(address));
LocalSocket serverSocket = localServerSocket.accept();
assertTrue(serverSocket.isConnected());
assertTrue(serverSocket.isBound());
// send data from client to server
OutputStream clientOutStream = clientSocket.getOutputStream();
clientOutStream.write(12);

13
tests/cts/net/src/android/net/cts/LocalSocketTest.java
View File

@@ -50,7 +50,20 @@ public class LocalSocketTest extends TestCase {
assertFalse(clientSocket.isConnected());
clientSocket.connect(locSockAddr);
assertTrue(clientSocket.isConnected());
LocalSocket serverSocket = localServerSocket.accept();
assertTrue(serverSocket.isConnected());
assertTrue(serverSocket.isBound());
try {
serverSocket.bind(localServerSocket.getLocalSocketAddress());
fail("Cannot bind a LocalSocket from accept()");
} catch (IOException expected) {
}
try {
serverSocket.connect(locSockAddr);
fail("Cannot connect a LocalSocket from accept()");
} catch (IOException expected) {
}
Credentials credent = clientSocket.getPeerCredentials();
assertTrue(0 != credent.getPid());