Commit Graph

10584 Commits

Author SHA1 Message Date
Chalard Jean
0218235ed0 [automerger skipped] Merge "Address nit from aosp/1301317" into rvc-dev am: 75fddad9b4 am: 07b69e4658 am: 4401e112ee -s ours am: 94b0dab36d -s ours
am skip reason: Change-Id If5e5439b22f05e08a293fd83da4d54f6a4363ca5 with SHA-1 1f9e9ce3d5 is in history

Change-Id: I3937b76aee04cd94c4c41c51eb443703b3343cc4
2020-05-21 08:13:07 +00:00
Automerger Merge Worker
3f12f86482 Merge "[automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: dceccdfc1c -s ours am: ceb3aa8295 -s ours" into rvc-qpr-dev-plus-aosp am: 73b16cbd77 -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 1112dd3d83 is in history

Change-Id: I47c91c553f8a576948f295825681667ba25597d4
2020-05-21 08:12:56 +00:00
Chalard Jean
96a322cc66 [automerger skipped] Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac am: e3d1f5e2f1 am: a8caf45e3b -s ours am: 9fc4f5297d -s ours
am skip reason: Change-Id I3e4ff990c0d4825b21c7679be29a482a2d1324ec with SHA-1 91a1beddcc is in history

Change-Id: I80c864919c9c66535c78bc3a23e3542d874fd0ab
2020-05-21 08:12:43 +00:00
Chalard Jean
5231654740 [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: dceccdfc1c am: 1a18d48352 -s ours am: a54da62d3a -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 8c5e45895d is in history

Change-Id: I85981411877ad515e086a7dab37b9e3c4fb4cc4c
2020-05-21 08:11:15 +00:00
Chalard Jean
94b0dab36d [automerger skipped] Merge "Address nit from aosp/1301317" into rvc-dev am: 75fddad9b4 am: 07b69e4658 am: 4401e112ee -s ours
am skip reason: Change-Id If5e5439b22f05e08a293fd83da4d54f6a4363ca5 with SHA-1 1f9e9ce3d5 is in history

Change-Id: Iea04465f5b85e642324222d9e2fa8152a9f213ba
2020-05-21 07:35:58 +00:00
Automerger Merge Worker
73b16cbd77 Merge "[automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: dceccdfc1c -s ours am: ceb3aa8295 -s ours" into rvc-qpr-dev-plus-aosp 2020-05-21 07:35:53 +00:00
Chalard Jean
9a1dd02f14 [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: dceccdfc1c -s ours am: ceb3aa8295 -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 1112dd3d83 is in history

Change-Id: I6366c3d76e0a5f61fa90eb93d8ed2323f87e8504
2020-05-21 07:35:47 +00:00
Chalard Jean
9fc4f5297d [automerger skipped] Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac am: e3d1f5e2f1 am: a8caf45e3b -s ours
am skip reason: Change-Id I3e4ff990c0d4825b21c7679be29a482a2d1324ec with SHA-1 91a1beddcc is in history

Change-Id: I65e82972439bd524fedd0906596aeaaf2dac83fa
2020-05-21 07:35:40 +00:00
Chalard Jean
a54da62d3a [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: dceccdfc1c am: 1a18d48352 -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 8c5e45895d is in history

Change-Id: I4c1667bda67f3c8cf19c5407963e2a28e0443ece
2020-05-21 07:35:15 +00:00
Chalard Jean
ceb3aa8295 [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: dceccdfc1c -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 8c5e45895d is in history

Change-Id: Id070eb419a57aa6c7eddacf8266a40eebdbc415b
2020-05-21 07:19:15 +00:00
Chalard Jean
07b69e4658 Merge "Address nit from aosp/1301317" into rvc-dev am: 75fddad9b4
Change-Id: I719006d1f3452a51303999dad5805ae0271ffddf
2020-05-21 07:04:43 +00:00
Chalard Jean
e3d1f5e2f1 Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac
Change-Id: If3e0353505e89ffb4b6ae2fe49e11639f20e293e
2020-05-21 07:03:51 +00:00
Chalard Jean
dceccdfc1c Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65
Change-Id: I47f8f49d7e51ebaec68e7ad678f55fd0087847c7
2020-05-21 07:02:49 +00:00
Chalard Jean
75fddad9b4 Merge "Address nit from aosp/1301317" into rvc-dev 2020-05-21 06:44:30 +00:00
Chalard Jean
8c06a845ac Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev 2020-05-21 06:43:56 +00:00
Treehugger Robot
436608cf39 Address nit from aosp/1301317
Test: atest ConnectivityServiceTest#testVpnSetUnderlyingNetworks
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1307374
Merged-In: If5e5439b22f05e08a293fd83da4d54f6a4363ca5
Change-Id: If5e5439b22f05e08a293fd83da4d54f6a4363ca5
2020-05-21 05:12:41 +00:00
Chalard Jean
fc7054d0e9 Fix a bug where VPNs start out suspended on cellular
As NetworkAgent is in a transition where all agents need
to include the NOT_SUSPENDED capability as part of their
migration to the system API, ConnectivityService adds it
forcefully to all agents that don't have the CELLULAR
transport. This doesn't include VPNs when VPNs have some
cellular network as their underlying network.

The best way to solve this is to make sure the VPN
capabilities reflect those of the underlying networks as
far as the NOT_SUSPENDED capability is concerned. This
is how they work for other similar capabilities.

This also happens to contain a drive-by fix for an issue
with a spurious capabilities callback is triggered when
a VPN connects and it has any underlying network (which
means almost always, because it will take the default
network if it doesn't declare any). Fixing this was
necessary to have a cogent test of this issue, but it
could be moved to another patch or it could stay unfixed
with some minor ajustment to the tests if judged too
dangerous to include in R at this point.

Test: New tests in this patch. Also manually tested with
      tcpdump as described in b/150570873.
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1301317
Merged-In: I3e4ff990c0d4825b21c7679be29a482a2d1324ec
Change-Id: I3e4ff990c0d4825b21c7679be29a482a2d1324ec
2020-05-21 05:10:37 +00:00
Chalard Jean
1112dd3d83 Fix a bug where a spurious capabilities callback is sent.
When a VPN connects and it has any underlying network (which
means almost always, because it will take the default network
if it doesn't declare any), it has default capabilities and
will only take the capabilities of its underlying network
as part of an update happening after making the network
available but before the rematch can take place. This in turn
causes the capabilities callback sent as part of the rematch
to be spuriously sent.

Test: FrameworksNetTests. Also tested together with a
      followup that adds tests with drive-by coverage for this.
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1305393
Merged-In: Id7d8bba486bada1a7ba5b0f152d2aa02e407f249
Change-Id: Id7d8bba486bada1a7ba5b0f152d2aa02e407f249
2020-05-21 05:09:15 +00:00
Remi NGUYEN VAN
288b065c0f Merge "Add integration test for capport API" am: f2853503c3 am: 987e504c1e am: bd08afe9e1 am: 10eb9435df am: 7e94dd9c5e
Change-Id: I062b86c3c03dc2f280cec0e7bb95618213e38f6f
2020-05-20 10:40:33 +00:00
Remi NGUYEN VAN
7e94dd9c5e Merge "Add integration test for capport API" am: f2853503c3 am: 987e504c1e am: bd08afe9e1 am: 10eb9435df
Change-Id: I4b5590e4ac8a0115f2422146470bfc60e7ef39c7
2020-05-20 10:28:45 +00:00
Remi NGUYEN VAN
10eb9435df Merge "Add integration test for capport API" am: f2853503c3 am: 987e504c1e am: bd08afe9e1
Change-Id: I2437fa38c1c503be4f3063030a98cc7fca997b8b
2020-05-20 10:06:58 +00:00
Remi NGUYEN VAN
bd08afe9e1 Merge "Add integration test for capport API" am: f2853503c3 am: 987e504c1e
Change-Id: Ib0051ca4bf36f88cac7ab15741c0a7e8bc53c005
2020-05-20 09:42:15 +00:00
Remi NGUYEN VAN
987e504c1e Merge "Add integration test for capport API" am: f2853503c3
Change-Id: I9e4ebb0e6746806a466544261def371eff4c8e21
2020-05-20 09:41:45 +00:00
Remi NGUYEN VAN
c8e627feb5 Add integration test for capport API
Add a test to verify the ConnectivityService / NetworkMonitor
integration around the captive portal API.

Test: atest ConnectivityServiceIntegrationTest
Bug: 156062304
Change-Id: I4eed02e09fc4943c011d871c58ba97ec572c7763
2020-05-20 15:11:14 +09:00
Treehugger Robot
f11b6dab30 [automerger skipped] Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d am: 2d35a023b5 am: faff36977c am: 81d2a12f42 am: 7e0da4928e -s ours
am skip reason: Change-Id I4457ff2bd466a4c56fed2570e110f251031c2385 with SHA-1 17e3df1968 is in history

Change-Id: I983d298a0ffdc717e50a6ea645afb3d144439712
2020-05-19 11:35:32 +00:00
Treehugger Robot
7e0da4928e Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d am: 2d35a023b5 am: faff36977c am: 81d2a12f42
Change-Id: I353a2740fc6edec7c5a85c93632ed1cb5df53425
2020-05-19 11:11:31 +00:00
Treehugger Robot
81d2a12f42 Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d am: 2d35a023b5 am: faff36977c
Change-Id: I57c34e4e4115159d72fe25a12367262febae46f9
2020-05-19 10:48:43 +00:00
Treehugger Robot
faff36977c Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d am: 2d35a023b5
Change-Id: I566ae57dc9a64636a72aba836f61d1686f5377c9
2020-05-19 10:20:31 +00:00
Treehugger Robot
2d35a023b5 Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d
Change-Id: Iadfaca436895055de90e8018f881b07a6bab4bea
2020-05-19 09:58:50 +00:00
Treehugger Robot
17df6cbb6d Merge "Add an exported flag in integration tests manifest" 2020-05-19 09:32:39 +00:00
Remi NGUYEN VAN
cdd6f0e9ea Add an exported flag in integration tests manifest
(partial cherry-pick of internal change:
I4457ff2bd466a4c56fed2570e110f251031c2385)

With b/150232615, we will need an explicit value set for the exported
flag when intent filters are present, as the default behavior is
changing for S+. This change adds the value reflecting the previous
default to the manifest.

These changes were made using an automated tool, the xml file may be
reformatted slightly creating a larger diff. The only "real" change is
the addition of "android:exported" to activities, services, and
receivers that have one or more intent-filters.

Bug: 150232615
Test: TH
Merged-In: I4457ff2bd466a4c56fed2570e110f251031c2385
Change-Id: I65a1ca1678048bbf09edc9a0485b673644c8109d
2020-05-19 17:53:32 +09:00
Cody Kesting
194fa2a23c Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf am: 07b9ebd24f am: 16ead64d17 am: 74f113166a am: 7b0a44e8dc
Change-Id: Ib8fc96e69847c073aa4dcc81506376e7132334a6
2020-05-18 18:57:14 +00:00
Cody Kesting
7b0a44e8dc Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf am: 07b9ebd24f am: 16ead64d17 am: 74f113166a
Change-Id: I8223d6021ce44033e55837e82760453c4d090381
2020-05-18 18:35:45 +00:00
Cody Kesting
74f113166a Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf am: 07b9ebd24f am: 16ead64d17
Change-Id: I75e65ed0c9fab17c8a190ef2acdd4f4f263e4b6c
2020-05-18 18:31:37 +00:00
Cody Kesting
16ead64d17 Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf am: 07b9ebd24f
Change-Id: I3b6facc6220c5818565fc8d0ed3d1cad4bede2af
2020-05-18 18:29:29 +00:00
Cody Kesting
07b9ebd24f Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf
Change-Id: I0884098a86de1e96b93dd1c753d7863641f34f0b
2020-05-18 17:38:34 +00:00
Cody Kesting
8a38affcbf Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." 2020-05-18 17:21:21 +00:00
Cody Kesting
c721a01ddc [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de -s ours am: e4e4239b68 -s ours am: 9a6be06466 -s ours am: 73f76d16d0 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f4a7e96585 is in history

Change-Id: Icd261ba1d6757a4f9cc40171a4bf00a734854326
2020-05-15 16:55:44 +00:00
Cody Kesting
dc8bf92acb [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 -s ours am: e1fa6e1eed -s ours am: ab88485bc1 -s ours am: 99699130eb -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ccfd0ff534 is in history

Change-Id: Ia8a43927cf5a3abdfcd95206cefcae849db39d2c
2020-05-15 16:55:06 +00:00
Cody Kesting
73f76d16d0 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de -s ours am: e4e4239b68 -s ours am: 9a6be06466 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f4a7e96585 is in history

Change-Id: Icdad1a09f60a11cbf9dc8e49dd4565f370da8ec5
2020-05-15 16:39:18 +00:00
Cody Kesting
99699130eb [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 -s ours am: e1fa6e1eed -s ours am: ab88485bc1 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ccfd0ff534 is in history

Change-Id: I9aaa2b99a80d7589f7e34a4543aa0ba73109889e
2020-05-15 16:39:08 +00:00
Cody Kesting
3f1ee5c7dc [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de am: 8ed473a5e6 -s ours am: 9b3c05e670 -s ours am: 077cdec731 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f4a7e96585 is in history

Change-Id: I66862dd70867f0869fab420b8268cd56c2057182
2020-05-15 16:34:43 +00:00
Cody Kesting
edd0ab415b [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 am: f5780f203f -s ours am: 8524babf8d -s ours am: ee91240cc6 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ccfd0ff534 is in history

Change-Id: Idffc0cb9e9948138529be2fbc1febb531ad7c7f2
2020-05-15 16:34:33 +00:00
Cody Kesting
077cdec731 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de am: 8ed473a5e6 -s ours am: 9b3c05e670 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f4a7e96585 is in history

Change-Id: I3e4262c358cf911c637dd518730ce4274efab587
2020-05-15 16:13:47 +00:00
Cody Kesting
ee91240cc6 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 am: f5780f203f -s ours am: 8524babf8d -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ccfd0ff534 is in history

Change-Id: I5a40a74c489c782151a20f07a23177500b76e2fa
2020-05-15 16:13:37 +00:00
Cody Kesting
9a6be06466 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de -s ours am: e4e4239b68 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f4a7e96585 is in history

Change-Id: I1d5f1c2a7059dfc15348126213f620666fdab83a
2020-05-15 16:11:33 +00:00
Cody Kesting
43facc3418 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de am: 8ed473a5e6 am: a42615900f -s ours am: 5ea424014c -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 b5c7abd071 is in history

Change-Id: I97f084d61d250ef6e84d513199f190d58b1e3c08
2020-05-15 16:11:32 +00:00
Cody Kesting
ab88485bc1 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 -s ours am: e1fa6e1eed -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ccfd0ff534 is in history

Change-Id: Ibdd6d03a7e98bcc30be1832321a3cfe434cd1082
2020-05-15 16:11:25 +00:00
Cody Kesting
0f852d3740 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 am: f5780f203f am: 628481939a -s ours am: e77e46fe73 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ba3433669a is in history

Change-Id: Ied2249806d6e67a3fe1ceaca6a161d3eae6311d1
2020-05-15 16:11:19 +00:00
Cody Kesting
e4e4239b68 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 b5c7abd071 is in history

Change-Id: Idb6ea8087b39242e1bab79d7227107303a81f59d
2020-05-15 15:56:40 +00:00