Commit Graph

10201 Commits

Author SHA1 Message Date
Chalard Jean
711619623e [automerger skipped] Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 5c721ed487 am: 6b0c759287 am: a8caf45e3b -s ours
am skip reason: Change-Id I3e4ff990c0d4825b21c7679be29a482a2d1324ec with SHA-1 fbd6a2c012 is in history

Change-Id: I65e82972439bd524fedd0906596aeaaf2dac83fa
2020-05-21 07:35:40 +00:00
Chalard Jean
cd38e39287 [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: eaf94d5d0e am: 1a18d48352 -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 d568791283 is in history

Change-Id: I4c1667bda67f3c8cf19c5407963e2a28e0443ece
2020-05-21 07:35:15 +00:00
Chalard Jean
6b0c759287 Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 5c721ed487
Change-Id: If3e0353505e89ffb4b6ae2fe49e11639f20e293e
2020-05-21 07:03:51 +00:00
Chalard Jean
eaf94d5d0e Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65
Change-Id: I47f8f49d7e51ebaec68e7ad678f55fd0087847c7
2020-05-21 07:02:49 +00:00
Chalard Jean
5c721ed487 Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev 2020-05-21 06:43:56 +00:00
Chalard Jean
ebbece8b22 Fix a bug where VPNs start out suspended on cellular
As NetworkAgent is in a transition where all agents need
to include the NOT_SUSPENDED capability as part of their
migration to the system API, ConnectivityService adds it
forcefully to all agents that don't have the CELLULAR
transport. This doesn't include VPNs when VPNs have some
cellular network as their underlying network.

The best way to solve this is to make sure the VPN
capabilities reflect those of the underlying networks as
far as the NOT_SUSPENDED capability is concerned. This
is how they work for other similar capabilities.

This also happens to contain a drive-by fix for an issue
with a spurious capabilities callback is triggered when
a VPN connects and it has any underlying network (which
means almost always, because it will take the default
network if it doesn't declare any). Fixing this was
necessary to have a cogent test of this issue, but it
could be moved to another patch or it could stay unfixed
with some minor ajustment to the tests if judged too
dangerous to include in R at this point.

Test: New tests in this patch. Also manually tested with
      tcpdump as described in b/150570873.
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1301317
Merged-In: I3e4ff990c0d4825b21c7679be29a482a2d1324ec
Change-Id: I3e4ff990c0d4825b21c7679be29a482a2d1324ec
2020-05-21 05:10:37 +00:00
Chalard Jean
bee5b3f227 Fix a bug where a spurious capabilities callback is sent.
When a VPN connects and it has any underlying network (which
means almost always, because it will take the default network
if it doesn't declare any), it has default capabilities and
will only take the capabilities of its underlying network
as part of an update happening after making the network
available but before the rematch can take place. This in turn
causes the capabilities callback sent as part of the rematch
to be spuriously sent.

Test: FrameworksNetTests. Also tested together with a
      followup that adds tests with drive-by coverage for this.
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1305393
Merged-In: Id7d8bba486bada1a7ba5b0f152d2aa02e407f249
Change-Id: Id7d8bba486bada1a7ba5b0f152d2aa02e407f249
2020-05-21 05:09:15 +00:00
Remi NGUYEN VAN
f73a16a974 Merge "Add integration test for capport API" am: f2853503c3 am: d7b408a8d8 am: 7909635637 am: ef74998dc9
Change-Id: I4b5590e4ac8a0115f2422146470bfc60e7ef39c7
2020-05-20 10:28:45 +00:00
Remi NGUYEN VAN
ef74998dc9 Merge "Add integration test for capport API" am: f2853503c3 am: d7b408a8d8 am: 7909635637
Change-Id: I2437fa38c1c503be4f3063030a98cc7fca997b8b
2020-05-20 10:06:58 +00:00
Remi NGUYEN VAN
7909635637 Merge "Add integration test for capport API" am: f2853503c3 am: d7b408a8d8
Change-Id: Ib0051ca4bf36f88cac7ab15741c0a7e8bc53c005
2020-05-20 09:42:15 +00:00
Remi NGUYEN VAN
d7b408a8d8 Merge "Add integration test for capport API" am: f2853503c3
Change-Id: I9e4ebb0e6746806a466544261def371eff4c8e21
2020-05-20 09:41:45 +00:00
Remi NGUYEN VAN
2ce373abf2 Add integration test for capport API
Add a test to verify the ConnectivityService / NetworkMonitor
integration around the captive portal API.

Test: atest ConnectivityServiceIntegrationTest
Bug: 156062304
Change-Id: I4eed02e09fc4943c011d871c58ba97ec572c7763
2020-05-20 15:11:14 +09:00
Treehugger Robot
2c6ec04e88 Merge "Add an exported flag in integration tests manifest" am: 8598423cc4 am: 379edab69e am: 23a0020dc2 am: da67d65835
Change-Id: I353a2740fc6edec7c5a85c93632ed1cb5df53425
2020-05-19 11:11:31 +00:00
Treehugger Robot
da67d65835 Merge "Add an exported flag in integration tests manifest" am: 8598423cc4 am: 379edab69e am: 23a0020dc2
Change-Id: I57c34e4e4115159d72fe25a12367262febae46f9
2020-05-19 10:48:43 +00:00
Treehugger Robot
23a0020dc2 Merge "Add an exported flag in integration tests manifest" am: 8598423cc4 am: 379edab69e
Change-Id: I566ae57dc9a64636a72aba836f61d1686f5377c9
2020-05-19 10:20:31 +00:00
Treehugger Robot
379edab69e Merge "Add an exported flag in integration tests manifest" am: 8598423cc4
Change-Id: Iadfaca436895055de90e8018f881b07a6bab4bea
2020-05-19 09:58:50 +00:00
Treehugger Robot
8598423cc4 Merge "Add an exported flag in integration tests manifest" 2020-05-19 09:32:39 +00:00
Remi NGUYEN VAN
d68de90e40 Add an exported flag in integration tests manifest
(partial cherry-pick of internal change:
I4457ff2bd466a4c56fed2570e110f251031c2385)

With b/150232615, we will need an explicit value set for the exported
flag when intent filters are present, as the default behavior is
changing for S+. This change adds the value reflecting the previous
default to the manifest.

These changes were made using an automated tool, the xml file may be
reformatted slightly creating a larger diff. The only "real" change is
the addition of "android:exported" to activities, services, and
receivers that have one or more intent-filters.

Bug: 150232615
Test: TH
Merged-In: I4457ff2bd466a4c56fed2570e110f251031c2385
Change-Id: I65a1ca1678048bbf09edc9a0485b673644c8109d
2020-05-19 17:53:32 +09:00
Cody Kesting
8ba653ae9b Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: feac618a1a am: 5d19c0ae7f am: 3e83585a8b am: 2bc93f229f
Change-Id: I8223d6021ce44033e55837e82760453c4d090381
2020-05-18 18:35:45 +00:00
Cody Kesting
2bc93f229f Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: feac618a1a am: 5d19c0ae7f am: 3e83585a8b
Change-Id: I75e65ed0c9fab17c8a190ef2acdd4f4f263e4b6c
2020-05-18 18:31:37 +00:00
Cody Kesting
3e83585a8b Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: feac618a1a am: 5d19c0ae7f
Change-Id: I3b6facc6220c5818565fc8d0ed3d1cad4bede2af
2020-05-18 18:29:29 +00:00
Cody Kesting
5d19c0ae7f Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: feac618a1a
Change-Id: I0884098a86de1e96b93dd1c753d7863641f34f0b
2020-05-18 17:38:34 +00:00
Cody Kesting
feac618a1a Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." 2020-05-18 17:21:21 +00:00
Cody Kesting
eaa001b991 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: 8ed33c51f1 -s ours am: 49ea39e137 -s ours am: f62cbeaf8d -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 9ddf8a5953 is in history

Change-Id: Icdad1a09f60a11cbf9dc8e49dd4565f370da8ec5
2020-05-15 16:39:18 +00:00
Cody Kesting
0bfee73003 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 05d04fe553 -s ours am: 4cf3195976 -s ours am: 4b6cd6a586 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 a9b761d261 is in history

Change-Id: I9aaa2b99a80d7589f7e34a4543aa0ba73109889e
2020-05-15 16:39:08 +00:00
Cody Kesting
2b1b1c8076 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: 8ed33c51f1 am: afa449c852 -s ours am: adac80cf27 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 9ddf8a5953 is in history

Change-Id: I3e4262c358cf911c637dd518730ce4274efab587
2020-05-15 16:13:47 +00:00
Cody Kesting
bcc7999869 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 05d04fe553 am: 2b628e49d4 -s ours am: dcbe2a47df -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 a9b761d261 is in history

Change-Id: I5a40a74c489c782151a20f07a23177500b76e2fa
2020-05-15 16:13:37 +00:00
Cody Kesting
f62cbeaf8d [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: 8ed33c51f1 -s ours am: 49ea39e137 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 9ddf8a5953 is in history

Change-Id: I1d5f1c2a7059dfc15348126213f620666fdab83a
2020-05-15 16:11:33 +00:00
Cody Kesting
4b6cd6a586 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 05d04fe553 -s ours am: 4cf3195976 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 a9b761d261 is in history

Change-Id: Ibdd6d03a7e98bcc30be1832321a3cfe434cd1082
2020-05-15 16:11:25 +00:00
Cody Kesting
49ea39e137 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: 8ed33c51f1 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f53a075913 is in history

Change-Id: Idb6ea8087b39242e1bab79d7227107303a81f59d
2020-05-15 15:56:40 +00:00
Cody Kesting
4cf3195976 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 05d04fe553 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 fc7cad313d is in history

Change-Id: I378c8d86396f0a8ddb803b86ef8426b4dca1c153
2020-05-15 15:56:20 +00:00
Cody Kesting
c30f8d47af [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: 8ed33c51f1 am: afa449c852 am: a42615900f -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f53a075913 is in history

Change-Id: I9dd9b553b718182482e270776f9ec5a2a163a6cc
2020-05-15 15:53:40 +00:00
Cody Kesting
be9731b619 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 05d04fe553 am: 2b628e49d4 am: 628481939a -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 fc7cad313d is in history

Change-Id: Ibc079b93fe6a2183220fdd57d0d41cbda772c400
2020-05-15 15:53:30 +00:00
Cody Kesting
adac80cf27 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: 8ed33c51f1 am: afa449c852 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f53a075913 is in history

Change-Id: I92ebe59e56a221d9f998286dc9a6d8d1993b12a0
2020-05-15 15:51:31 +00:00
Cody Kesting
dcbe2a47df [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 05d04fe553 am: 2b628e49d4 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 fc7cad313d is in history

Change-Id: I7009a06d57286347c5fae2355132d2f217863383
2020-05-15 15:51:19 +00:00
Treehugger Robot
f801a1ac69 Merge "Address nit from aosp/1301317" am: 1894a79964 am: 2dc15b02b2 am: 4e94c06d29 am: b18e0bfd47
Change-Id: I40af839b2c1838d1fa2a5298197b94d401b62a1e
2020-05-15 08:02:25 +00:00
Treehugger Robot
b18e0bfd47 Merge "Address nit from aosp/1301317" am: 1894a79964 am: 2dc15b02b2 am: 4e94c06d29
Change-Id: Ib5bb0a7349523274f825832a7fc71aa9ed95b764
2020-05-15 07:43:42 +00:00
Treehugger Robot
4e94c06d29 Merge "Address nit from aosp/1301317" am: 1894a79964 am: 2dc15b02b2
Change-Id: I7ae9b80954309b18eb6923da3aeaab3d1b8e3231
2020-05-15 07:14:29 +00:00
Treehugger Robot
2dc15b02b2 Merge "Address nit from aosp/1301317" am: 1894a79964
Change-Id: I2443c5da4b69bce693a39e894c41db5b25b6cf03
2020-05-15 07:03:31 +00:00
Treehugger Robot
1894a79964 Merge "Address nit from aosp/1301317" 2020-05-15 06:43:42 +00:00
Benedict Wong
4072afdccc Merge "Add methods for IKEv2/IPsec test mode profiles" am: 56b98b0206 am: 099b0b8700 am: 317aa920aa am: 2d5ae08cc9
Change-Id: I73284b878b9622992c2773b4efd9297ae71e07fc
2020-05-15 03:29:53 +00:00
Benedict Wong
2d5ae08cc9 Merge "Add methods for IKEv2/IPsec test mode profiles" am: 56b98b0206 am: 099b0b8700 am: 317aa920aa
Change-Id: I03dd060ae9de05f9491a37f321faacdadab73965
2020-05-15 03:12:05 +00:00
Benedict Wong
317aa920aa Merge "Add methods for IKEv2/IPsec test mode profiles" am: 56b98b0206 am: 099b0b8700
Change-Id: I353d999ebcdd108a900abfe20be232e83147b6d2
2020-05-15 02:51:43 +00:00
Benedict Wong
099b0b8700 Merge "Add methods for IKEv2/IPsec test mode profiles" am: 56b98b0206
Change-Id: I9ff22188a641fce6b7bd44f7619d1b825988667a
2020-05-15 02:35:39 +00:00
Benedict Wong
56b98b0206 Merge "Add methods for IKEv2/IPsec test mode profiles" 2020-05-15 02:18:02 +00:00
Cody Kesting
afa449c852 Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: 8ed33c51f1
Change-Id: I126dd23216a3a42a9745a2c97e26ac2599e307e1
2020-05-14 19:19:13 +00:00
Cody Kesting
2b628e49d4 Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 05d04fe553
Change-Id: Ia17090a6a00b878235d512a80e59d9f58fd1cbd9
2020-05-14 19:18:26 +00:00
Cody Kesting
8ed33c51f1 Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev 2020-05-14 18:56:36 +00:00
Cody Kesting
05d04fe553 Merge "Set owner and administrator UIDs for test networks." into rvc-dev 2020-05-14 18:56:16 +00:00
Automerger Merge Worker
6ea3bb8270 Merge "[automerger skipped] Merge "Use the new NetworkStackConnector constructor" into rvc-dev am: 2404bc617a -s ours am: 83bc7a6c91 -s ours" into rvc-d1-dev-plus-aosp am: 3b05e7f649 -s ours
am skip reason: Change-Id I46f247268310e12d420531745a22e93cf3550e89 with SHA-1 05c7af6c7c is in history

Change-Id: I901d2b1c78b526a470bce67b3c935195758bc06d
2020-05-14 00:51:59 +00:00