Commit Graph

285 Commits

Author SHA1 Message Date
Lorenzo Colitti
b7e2baaee0 [automerger skipped] Support setting the default interface to null again. am: 876e5e16a9 -s ours am: 6fb426f10a -s ours am: f7bc865d2c -s ours
am skip reason: Change-Id I5109d8da3aeb6c1f6523291d9e2ec92c64b5ad2d with SHA-1 e81f99d532 is in history

Change-Id: I9cea9b849fff6b292d81b6bd2a1c8338d3d271a1
2020-03-20 02:16:02 +00:00
Lorenzo Colitti
f7bc865d2c [automerger skipped] Support setting the default interface to null again. am: 876e5e16a9 -s ours am: 6fb426f10a -s ours
am skip reason: Change-Id I5109d8da3aeb6c1f6523291d9e2ec92c64b5ad2d with SHA-1 e81f99d532 is in history

Change-Id: I53102631b3030ba3307c2ffe04d340c9421fc50b
2020-03-20 01:09:43 +00:00
Lorenzo Colitti
6fb426f10a [automerger skipped] Support setting the default interface to null again. am: 876e5e16a9 -s ours
am skip reason: Change-Id I5109d8da3aeb6c1f6523291d9e2ec92c64b5ad2d with SHA-1 e81f99d532 is in history

Change-Id: I3adadae13ef96c50e4083b8d826730e0fb4990fd
2020-03-20 00:44:57 +00:00
Lorenzo Colitti
fc26b8e236 Send tethered interface callbacks based on interface existence. am: 165b456d92 am: cad2e49acb am: 3449a34474 am: 4615bbe667
Change-Id: I3303d8506a0d715a60843f9073cfd104b286372a
2020-03-19 16:27:47 +00:00
Lorenzo Colitti
32db6f52cb Support setting the default interface to null again. am: e81f99d532 am: e19d6a8764 am: 4b10eea44f am: a79245c7f0
Change-Id: Ie4bd5ae4c939a19dd95e3a51ebb67b4833d0a8ba
2020-03-19 16:27:43 +00:00
Lorenzo Colitti
4615bbe667 Send tethered interface callbacks based on interface existence. am: 165b456d92 am: cad2e49acb am: 3449a34474
Change-Id: Iac66c95f07fe81d5c9e1b5dfcd42fe676ea2bc70
2020-03-19 16:16:22 +00:00
Lorenzo Colitti
a79245c7f0 Support setting the default interface to null again. am: e81f99d532 am: e19d6a8764 am: 4b10eea44f
Change-Id: I0633a83170f9e9cda8113fe1ccf7b6225f16e794
2020-03-19 16:16:14 +00:00
Lorenzo Colitti
876e5e16a9 Support setting the default interface to null again.
Currently, the default interface can only ever go from null to
non-null. This is correct for fixed interfaces (because they
don't get unplugged) and it's generally correct for USB
interfaces that use ethX as their device name (because when
they are unplugged and plugged in again, the device name won't
change). But it is not correct if, for example, the default
interface is a test interface. So, allow mDefaultInterface to go
back to null.

This CL also fixes a crash if a tethered interface request is
added and removed when there is no default interface.

Also, make dump() report tethered interface requests.

Also remove an unused variable that I missed in the previous CL.

Bug: 150644681
Test: tested by EthernetTetheringTest in same topic
Change-Id: I5109d8da3aeb6c1f6523291d9e2ec92c64b5ad2d
Merged-In: I5109d8da3aeb6c1f6523291d9e2ec92c64b5ad2d
(cherry picked from commit cc156c2f7793731b2699e194d4b164138ee4cf62)
2020-03-19 15:53:13 +00:00
Lorenzo Colitti
3449a34474 Send tethered interface callbacks based on interface existence. am: 165b456d92 am: cad2e49acb
Change-Id: I4b24ea24ede2856d8c33df3e2331efe9d5825ca6
2020-03-19 15:52:09 +00:00
Lorenzo Colitti
4b10eea44f Support setting the default interface to null again. am: e81f99d532 am: e19d6a8764
Change-Id: I373f51835b48bdb9c7a678c4779f1a9079c7a181
2020-03-19 15:52:03 +00:00
Lorenzo Colitti
ee758e6ae1 [automerger skipped] Make Ethernet interfaces more testable. am: fb336e9296 am: 5cc44b3cdd am: ab6fe7445b am: 2af1f3b8b0 -s ours
am skip reason: Change-Id I86eef7a93267f800dbfc8eafd307effa76a344ca with SHA-1 fb336e9296 is in history

Change-Id: I4562315db7b0d4e933d22aa0872a989fa243e5fb
2020-03-19 15:37:44 +00:00
Lorenzo Colitti
fcd828fe68 [automerger skipped] Make Ethernet interfaces more testable. am: fb336e9296 -s ours am: 523093a1ff -s ours am: 8f07511302 -s ours
am skip reason: Change-Id I86eef7a93267f800dbfc8eafd307effa76a344ca with SHA-1 fb336e9296 is in history

Change-Id: Iecf35ecae75b28c4bb529b9baf17121ef7e9dea2
2020-03-19 15:17:12 +00:00
Lorenzo Colitti
2af1f3b8b0 Make Ethernet interfaces more testable. am: fb336e9296 am: 5cc44b3cdd am: ab6fe7445b
Change-Id: I17fc6f115accd82ca6c8eed18a495cab28972751
2020-03-19 15:16:54 +00:00
Lorenzo Colitti
d4a0c5833c [automerger skipped] Make Ethernet interfaces more testable. am: fb336e9296 am: 5cc44b3cdd -s ours am: 6910d448e5 -s ours
am skip reason: Change-Id I86eef7a93267f800dbfc8eafd307effa76a344ca with SHA-1 841195a103 is in history

Change-Id: Icff2a8f5a0ef5d3598cc7deb6e465b97a2c92f4e
2020-03-19 15:16:44 +00:00
Lorenzo Colitti
ab6fe7445b Make Ethernet interfaces more testable. am: fb336e9296 am: 5cc44b3cdd
Change-Id: I437fe3a5462d64a20675642264fc0742469bebd2
2020-03-19 15:00:14 +00:00
Lorenzo Colitti
8f07511302 [automerger skipped] Make Ethernet interfaces more testable. am: fb336e9296 -s ours am: 523093a1ff -s ours
am skip reason: Change-Id I86eef7a93267f800dbfc8eafd307effa76a344ca with SHA-1 841195a103 is in history

Change-Id: Iec8edbba782a10b8d5c2b8c740d265dc2c11e2a1
2020-03-19 15:00:06 +00:00
Lorenzo Colitti
6910d448e5 [automerger skipped] Make Ethernet interfaces more testable. am: fb336e9296 am: 5cc44b3cdd -s ours
am skip reason: Change-Id I86eef7a93267f800dbfc8eafd307effa76a344ca with SHA-1 841195a103 is in history

Change-Id: Ia96d3fa55a985e8a37c0e8b2b5893dce986b7898
2020-03-19 14:59:45 +00:00
Lorenzo Colitti
523093a1ff [automerger skipped] Make Ethernet interfaces more testable. am: fb336e9296 -s ours
am skip reason: Change-Id I86eef7a93267f800dbfc8eafd307effa76a344ca with SHA-1 841195a103 is in history

Change-Id: I31d44b8c1a538f7c4573cf6fa476529326a9c0bf
2020-03-19 14:44:23 +00:00
Lorenzo Colitti
5cc44b3cdd Make Ethernet interfaces more testable. am: fb336e9296
Change-Id: I99a104ce76bbf3ceaca5497ab22b468d716769e0
2020-03-19 14:44:04 +00:00
Lorenzo Colitti
165b456d92 Send tethered interface callbacks based on interface existence.
Currently, callbacks for tethered interface availability are sent
based on interface link state. This is incorrect:

- It is acceptable and expected to be able to enable tethering on
  an interface that does not yet have link up.
- It doesn't seem useful to disable Ethernet tethering if link
  temporarily goes down.

Instead, only base the callbacks on whether an interface exists
or not.

Bug: 150644681
Test: WIP tests in aosp/1260100 pass
Change-Id: I015219cbd03626c38fb5156d0cb2991ba7d7def7
2020-03-19 22:12:32 +09:00
Lorenzo Colitti
e81f99d532 Support setting the default interface to null again.
Currently, the default interface can only ever go from null to
non-null. This is correct for fixed interfaces (because they
don't get unplugged) and it's generally correct for USB
interfaces that use ethX as their device name (because when
they are unplugged and plugged in again, the device name won't
change). But it is not correct if, for example, the default
interface is a test interface. So, allow mDefaultInterface to go
back to null.

This CL also fixes a crash if a tethered interface request is
added and removed when there is no default interface.

Also, make dump() report tethered interface requests.

Also remove an unused variable that I missed in the previous CL.

Bug: 150644681
Test: tested by EthernetTetheringTest in same topic
Change-Id: I5109d8da3aeb6c1f6523291d9e2ec92c64b5ad2d
2020-03-19 22:04:23 +09:00
Lorenzo Colitti
fb336e9296 Make Ethernet interfaces more testable.
This CL adds a setIncludeTestInterfaces method to EthernetManager
that, when called, causes the Ethernet service to recognize and
manage test interfaces created by TestNetworkManager.

Bug: 150644681
Test: Tested by EthernetTetheringTest in same topic
Change-Id: I86eef7a93267f800dbfc8eafd307effa76a344ca
Merged-In: I86eef7a93267f800dbfc8eafd307effa76a344ca
(cherry picked from commit 4978dbd5fb6592fc4e7be08d02783752245da634)
2020-03-19 12:29:35 +00:00
Lorenzo Colitti
0876b70058 Make Ethernet interfaces more testable. am: 841195a103 am: 6d590906f5 am: ee43f745bd am: 7988bb7cdf
Change-Id: If18607492e98def1deb2d35c68d3fd991e67be2b
2020-03-19 12:09:24 +00:00
Lorenzo Colitti
7988bb7cdf Make Ethernet interfaces more testable. am: 841195a103 am: 6d590906f5 am: ee43f745bd
Change-Id: I680a4f7ab3d3b02eb35bfd2477136f87ef514c9f
2020-03-19 11:49:13 +00:00
Lorenzo Colitti
ee43f745bd Make Ethernet interfaces more testable. am: 841195a103 am: 6d590906f5
Change-Id: Icd319cc53f17fc76d1a93bdb9741fc6db77c1ce9
2020-03-19 11:46:55 +00:00
Lorenzo Colitti
841195a103 Make Ethernet interfaces more testable.
This CL adds a setIncludeTestInterfaces method to EthernetManager
that, when called, causes the Ethernet service to recognize and
manage test interfaces created by TestNetworkManager.

Bug: 150644681
Test: Tested by EthernetTetheringTest in same topic
Change-Id: I86eef7a93267f800dbfc8eafd307effa76a344ca
2020-03-19 18:06:59 +09:00
Automerger Merge Worker
8ccee513c1 Revert part of 79eb7ba87b am: fd99009c52 am: 3379686f41 am: 8af676004d
Change-Id: I3dfda5288fef9b04b065cdc946ea7cd3d8b5235a
2020-03-03 00:16:11 +00:00
Automerger Merge Worker
9ca435e31a Revert part of 79eb7ba87b am: fd99009c52 am: 3379686f41 am: 0aa2a61c43
Change-Id: Icf8a4c051a1462b1745f08acfd17204e7472e809
2020-03-03 00:10:38 +00:00
Automerger Merge Worker
37d12a6844 Revert part of 79eb7ba87b am: fd99009c52 am: bab750adfe am: e5bab5554f
Change-Id: If9e3cf11a57f2570c0282a91b4fa256f6effd03e
2020-03-03 00:06:58 +00:00
Automerger Merge Worker
0aa2a61c43 Revert part of 79eb7ba87b am: fd99009c52 am: 3379686f41
Change-Id: Ia7ac2bd617a4185c70eeea6ef1def59d503c8d04
2020-03-03 00:04:43 +00:00
Automerger Merge Worker
8af676004d Revert part of 79eb7ba87b am: fd99009c52 am: 3379686f41
Change-Id: I8fe2ef8f60e07a0ef5eea665c5fb350984781595
2020-03-03 00:04:07 +00:00
Automerger Merge Worker
e5bab5554f Revert part of 79eb7ba87b am: fd99009c52 am: bab750adfe
Change-Id: Ib050674547f74e47fc08092cdf9a1c53d4853b8d
2020-03-02 23:47:45 +00:00
Automerger Merge Worker
3379686f41 Revert part of 79eb7ba87b am: fd99009c52
Change-Id: I764110dd3cacb3c2953afd38983b6f43b83811a2
2020-03-02 23:46:05 +00:00
Automerger Merge Worker
bab750adfe Revert part of 79eb7ba87b am: fd99009c52
Change-Id: Idcdfbe614f49183d38801ce4d1dd4b16de1d73b8
2020-03-02 23:33:04 +00:00
Chalard Jean
fd99009c52 Revert part of 79eb7ba87b
This reverts the parts of the above commit that have to do
with NetworkScore. The parts that convert the factory to the
new NetworkAgent API are conserved.

Bug: 113554781
Test: FrameworksNetTests
Change-Id: If2c368e084e29f9f358f43dcd547d42e8c7c4846
2020-02-28 06:26:20 +00:00
Automerger Merge Worker
6da0ed9d03 Set Ethernet default mode as CLIENT am: f85c0b301c am: dceced7bca am: 97b0e8d67c
Change-Id: Icba5166843dd4741493f2b22b519fbd1ed26489e
2020-02-01 16:17:11 +00:00
Automerger Merge Worker
dceced7bca Set Ethernet default mode as CLIENT am: f85c0b301c
Change-Id: Ib3e9b501c8a9bbc8862fc97f1bcddd2a92bbe46d
2020-02-01 16:00:23 +00:00
Milim Lee
f85c0b301c Set Ethernet default mode as CLIENT
Bug: 130840861
Test: build, boot
      atest EthernetTrackerTest
      manual test (using Ethernet)

Change-Id: I935ea2e5f214aced67fb60f4aec2744077177545
2020-02-01 05:48:53 +09:00
Chalard Jean
05c71a36c9 Merge "Make NetworkScore system API" 2020-01-31 03:06:15 +00:00
Chalard Jean
79eb7ba87b Make NetworkScore system API
Bug: 146583853
Test: FrameworksNetTests
Change-Id: Ie7b70750ef0e17141080f4266dea6155c3601569
2020-01-30 15:14:56 +09:00
Automerger Merge Worker
b1a5c68cee [automerger skipped] Support one Ethernet interface in server mode. am: 32327808e1 am: c5d03c8ca4 am: 8695bd42d3 -s ours
am skip reason: Change-Id I78f85bc36aaceb62ce274003a75ea99d0b6bc8b7 with SHA-1 c750566a77 is in history

Change-Id: I54f24efc6379337a48c54e8ef551117974d6ac04
2020-01-28 09:17:08 +00:00
Lorenzo Colitti
c5d03c8ca4 Support one Ethernet interface in server mode.
am: 32327808e1

Change-Id: I49dd9ef3d199508782e77e3b362ad3135ba82fa0
2020-01-28 00:37:36 -08:00
Lorenzo Colitti
32327808e1 Support one Ethernet interface in server mode.
Currently, Ethernet only supports interfaces in client mode
(e.g., to connect to the Internet). Add minimal support to
Ethernet to support interfaces in server mode. This simple
implementation only works on the default interface, which is the
first interface that is detected on boot (even if the interface
is later removed).

This also provides (but does not yet unhide) a simple API for
Tethering to request that the next-plugged-in interface to be
placed into server mode.

Test: Enabling tethering with change on top
Bug: 130840861
Merged-In: I78f85bc36aaceb62ce274003a75ea99d0b6bc8b7
Change-Id: I78f85bc36aaceb62ce274003a75ea99d0b6bc8b7
(clean cherry-pick from internal branch)
2020-01-28 16:22:46 +09:00
Lorenzo Colitti
c750566a77 Support one Ethernet interface in server mode.
Currently, Ethernet only supports interfaces in client mode
(e.g., to connect to the Internet). Add minimal support to
Ethernet to support interfaces in server mode. This simple
implementation only works on the default interface, which is the
first interface that is detected on boot (even if the interface
is later removed).

This also provides (but does not yet unhide) a simple API for
Tethering to request that the next-plugged-in interface to be
placed into server mode.

Test: Enabling tethering with change on top
Bug: 130840861
Change-Id: I78f85bc36aaceb62ce274003a75ea99d0b6bc8b7
2020-01-27 19:07:56 +09:00
Automerger Merge Worker
6a38d3aa4b Merge "Avoid creating IpClient if ethernet cable is unplugged." am: 918f68fce9 am: 35cc5e821e am: 91a297efc6
Change-Id: I6037008fa8c864a3f006bccf969ba2c1d7aad654
2020-01-09 05:53:55 +00:00
Automerger Merge Worker
91a297efc6 Merge "Avoid creating IpClient if ethernet cable is unplugged." am: 918f68fce9 am: 35cc5e821e
Change-Id: I8c8310da8935ffbdc3b18d7b05db55b81919c774
2020-01-09 05:37:15 +00:00
Lorenzo Colitti
35cc5e821e Merge "Avoid creating IpClient if ethernet cable is unplugged."
am: 918f68fce9

Change-Id: I097f2f68ea5b40997de7d312bbf6946c44e3b011
2020-01-08 21:27:48 -08:00
Lorenzo Colitti
918f68fce9 Merge "Avoid creating IpClient if ethernet cable is unplugged." 2020-01-09 05:26:34 +00:00
Automerger Merge Worker
8b65e6f8ce Fix refCount check at releaseNetworkFor am: b92d1f5513 am: 26965f92c3 am: 01e5c5a98c
Change-Id: Ib743575eb1f1c804182a50f14561ee5491f7087c
2019-12-17 12:47:48 +00:00
Automerger Merge Worker
01e5c5a98c Fix refCount check at releaseNetworkFor am: b92d1f5513 am: 26965f92c3
Change-Id: I82859813cf1e51cba5c240f86e3df4d2e1e0e2f4
2019-12-17 12:31:21 +00:00