Commit Graph

10028 Commits

Author SHA1 Message Date
Treehugger Robot
c1a0fffef6 Merge "Suppress deprecation warnings in LegacyTypeTrackerTest." am: 585dc0665e am: 212e497cbc am: 4ca97a469c
Change-Id: Ibef6fdbb24e7f8c46d925089acacefae3074541f
2020-05-21 08:45:51 +00:00
Treehugger Robot
4ca97a469c Merge "Suppress deprecation warnings in LegacyTypeTrackerTest." am: 585dc0665e am: 212e497cbc
Change-Id: I77fdf03484bd0da36ebffd025a33ab4859a0a5a2
2020-05-21 08:31:13 +00:00
Treehugger Robot
212e497cbc Merge "Suppress deprecation warnings in LegacyTypeTrackerTest." am: 585dc0665e
Change-Id: If35be28eac763d01b99078f171da8ff56d90d93f
2020-05-21 08:11:05 +00:00
Treehugger Robot
585dc0665e Merge "Suppress deprecation warnings in LegacyTypeTrackerTest." 2020-05-21 07:47:45 +00:00
Chalard Jean
06449a4bfe [automerger skipped] Merge "Address nit from aosp/1301317" into rvc-dev am: 75fddad9b4 -s ours am: fe2c8cf87c -s ours
am skip reason: Change-Id If5e5439b22f05e08a293fd83da4d54f6a4363ca5 with SHA-1 436608cf39 is in history

Change-Id: I68df91460ca23d2ec5336543bbedec0b802d80d0
2020-05-21 07:20:46 +00:00
Automerger Merge Worker
c00f8130ff Merge "[automerger skipped] Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac -s ours am: 3743eca9f2 -s ours" into rvc-d1-dev-plus-aosp 2020-05-21 07:20:43 +00:00
Chalard Jean
89f804c1cf [automerger skipped] Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac -s ours am: 3743eca9f2 -s ours
am skip reason: Change-Id I3e4ff990c0d4825b21c7679be29a482a2d1324ec with SHA-1 fc7054d0e9 is in history

Change-Id: I2c65d4269c9774ee850ebaa0c9ee6bc41c9aec62
2020-05-21 07:20:39 +00:00
Chalard Jean
54208694df [automerger skipped] Merge "Address nit from aosp/1301317" into rvc-dev am: 75fddad9b4 am: 07b69e4658 -s ours
am skip reason: Change-Id If5e5439b22f05e08a293fd83da4d54f6a4363ca5 with SHA-1 1f9e9ce3d5 is in history

Change-Id: I5ad62604060d15c2e802f612eaea80cd75040ff8
2020-05-21 07:20:23 +00:00
Chalard Jean
7823ca41be [automerger skipped] Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac am: e3d1f5e2f1 -s ours
am skip reason: Change-Id I3e4ff990c0d4825b21c7679be29a482a2d1324ec with SHA-1 91a1beddcc is in history

Change-Id: I9e8f5333444a3eb70d17a3c4077383a8b55815f9
2020-05-21 07:20:05 +00:00
Chalard Jean
3d11d87b2a [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 -s ours am: cb21e90728 -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 1112dd3d83 is in history

Change-Id: I2dd1178f403d5515f73b3ae2527576b0dd83d4e8
2020-05-21 07:19:51 +00:00
Chalard Jean
ceb3aa8295 [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 am: dceccdfc1c -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 8c5e45895d is in history

Change-Id: Id070eb419a57aa6c7eddacf8266a40eebdbc415b
2020-05-21 07:19:15 +00:00
Chalard Jean
07b69e4658 Merge "Address nit from aosp/1301317" into rvc-dev am: 75fddad9b4
Change-Id: I719006d1f3452a51303999dad5805ae0271ffddf
2020-05-21 07:04:43 +00:00
Chalard Jean
fe2c8cf87c [automerger skipped] Merge "Address nit from aosp/1301317" into rvc-dev am: 75fddad9b4 -s ours
am skip reason: Change-Id If5e5439b22f05e08a293fd83da4d54f6a4363ca5 with SHA-1 1f9e9ce3d5 is in history

Change-Id: Ifaf50fb9e04b1403cc75d9002e46c6955e111a40
2020-05-21 07:04:30 +00:00
Chalard Jean
3743eca9f2 [automerger skipped] Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac -s ours
am skip reason: Change-Id I3e4ff990c0d4825b21c7679be29a482a2d1324ec with SHA-1 91a1beddcc is in history

Change-Id: I22ecee256894e850f85ab02b299136283ebe9a08
2020-05-21 07:03:53 +00:00
Chalard Jean
e3d1f5e2f1 Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev am: 8c06a845ac
Change-Id: If3e0353505e89ffb4b6ae2fe49e11639f20e293e
2020-05-21 07:03:51 +00:00
Chalard Jean
cb21e90728 [automerger skipped] Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65 -s ours
am skip reason: Change-Id Id7d8bba486bada1a7ba5b0f152d2aa02e407f249 with SHA-1 8c5e45895d is in history

Change-Id: I655cca7c9e1ba6ba4fae95b221b1e46e91da5f6d
2020-05-21 07:02:51 +00:00
Chalard Jean
dceccdfc1c Merge "Fix a bug where a spurious capabilities callback is sent." into rvc-dev am: acdacbfe65
Change-Id: I47f8f49d7e51ebaec68e7ad678f55fd0087847c7
2020-05-21 07:02:49 +00:00
Chalard Jean
75fddad9b4 Merge "Address nit from aosp/1301317" into rvc-dev 2020-05-21 06:44:30 +00:00
Chalard Jean
8c06a845ac Merge "Fix a bug where VPNs start out suspended on cellular" into rvc-dev 2020-05-21 06:43:56 +00:00
Treehugger Robot
436608cf39 Address nit from aosp/1301317
Test: atest ConnectivityServiceTest#testVpnSetUnderlyingNetworks
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1307374
Merged-In: If5e5439b22f05e08a293fd83da4d54f6a4363ca5
Change-Id: If5e5439b22f05e08a293fd83da4d54f6a4363ca5
2020-05-21 05:12:41 +00:00
Chalard Jean
fc7054d0e9 Fix a bug where VPNs start out suspended on cellular
As NetworkAgent is in a transition where all agents need
to include the NOT_SUSPENDED capability as part of their
migration to the system API, ConnectivityService adds it
forcefully to all agents that don't have the CELLULAR
transport. This doesn't include VPNs when VPNs have some
cellular network as their underlying network.

The best way to solve this is to make sure the VPN
capabilities reflect those of the underlying networks as
far as the NOT_SUSPENDED capability is concerned. This
is how they work for other similar capabilities.

This also happens to contain a drive-by fix for an issue
with a spurious capabilities callback is triggered when
a VPN connects and it has any underlying network (which
means almost always, because it will take the default
network if it doesn't declare any). Fixing this was
necessary to have a cogent test of this issue, but it
could be moved to another patch or it could stay unfixed
with some minor ajustment to the tests if judged too
dangerous to include in R at this point.

Test: New tests in this patch. Also manually tested with
      tcpdump as described in b/150570873.
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1301317
Merged-In: I3e4ff990c0d4825b21c7679be29a482a2d1324ec
Change-Id: I3e4ff990c0d4825b21c7679be29a482a2d1324ec
2020-05-21 05:10:37 +00:00
Chalard Jean
1112dd3d83 Fix a bug where a spurious capabilities callback is sent.
When a VPN connects and it has any underlying network (which
means almost always, because it will take the default network
if it doesn't declare any), it has default capabilities and
will only take the capabilities of its underlying network
as part of an update happening after making the network
available but before the rematch can take place. This in turn
causes the capabilities callback sent as part of the rematch
to be spuriously sent.

Test: FrameworksNetTests. Also tested together with a
      followup that adds tests with drive-by coverage for this.
Bug: 150570873
Original-Change: https://android-review.googlesource.com/1305393
Merged-In: Id7d8bba486bada1a7ba5b0f152d2aa02e407f249
Change-Id: Id7d8bba486bada1a7ba5b0f152d2aa02e407f249
2020-05-21 05:09:15 +00:00
Lorenzo Colitti
2f0583946a Suppress deprecation warnings in LegacyTypeTrackerTest.
This saves dozens of warnings every time FrameworkNetTests is
compiled. There is nothing we can do about those warnings because
LegacyTypeTracker's reason for existence is to power deprecated
APIs.

Test: m FrameworksNetTests
Change-Id: I4d65b0aade493e12b56a94247efbf9d1ad7bb4b9
2020-05-20 20:53:16 +09:00
Remi NGUYEN VAN
10eb9435df Merge "Add integration test for capport API" am: f2853503c3 am: 987e504c1e am: bd08afe9e1
Change-Id: I2437fa38c1c503be4f3063030a98cc7fca997b8b
2020-05-20 10:06:58 +00:00
Remi NGUYEN VAN
bd08afe9e1 Merge "Add integration test for capport API" am: f2853503c3 am: 987e504c1e
Change-Id: Ib0051ca4bf36f88cac7ab15741c0a7e8bc53c005
2020-05-20 09:42:15 +00:00
Remi NGUYEN VAN
987e504c1e Merge "Add integration test for capport API" am: f2853503c3
Change-Id: I9e4ebb0e6746806a466544261def371eff4c8e21
2020-05-20 09:41:45 +00:00
Remi NGUYEN VAN
c8e627feb5 Add integration test for capport API
Add a test to verify the ConnectivityService / NetworkMonitor
integration around the captive portal API.

Test: atest ConnectivityServiceIntegrationTest
Bug: 156062304
Change-Id: I4eed02e09fc4943c011d871c58ba97ec572c7763
2020-05-20 15:11:14 +09:00
Treehugger Robot
81d2a12f42 Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d am: 2d35a023b5 am: faff36977c
Change-Id: I57c34e4e4115159d72fe25a12367262febae46f9
2020-05-19 10:48:43 +00:00
Treehugger Robot
faff36977c Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d am: 2d35a023b5
Change-Id: I566ae57dc9a64636a72aba836f61d1686f5377c9
2020-05-19 10:20:31 +00:00
Treehugger Robot
2d35a023b5 Merge "Add an exported flag in integration tests manifest" am: 17df6cbb6d
Change-Id: Iadfaca436895055de90e8018f881b07a6bab4bea
2020-05-19 09:58:50 +00:00
Treehugger Robot
17df6cbb6d Merge "Add an exported flag in integration tests manifest" 2020-05-19 09:32:39 +00:00
Remi NGUYEN VAN
cdd6f0e9ea Add an exported flag in integration tests manifest
(partial cherry-pick of internal change:
I4457ff2bd466a4c56fed2570e110f251031c2385)

With b/150232615, we will need an explicit value set for the exported
flag when intent filters are present, as the default behavior is
changing for S+. This change adds the value reflecting the previous
default to the manifest.

These changes were made using an automated tool, the xml file may be
reformatted slightly creating a larger diff. The only "real" change is
the addition of "android:exported" to activities, services, and
receivers that have one or more intent-filters.

Bug: 150232615
Test: TH
Merged-In: I4457ff2bd466a4c56fed2570e110f251031c2385
Change-Id: I65a1ca1678048bbf09edc9a0485b673644c8109d
2020-05-19 17:53:32 +09:00
Cody Kesting
74f113166a Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf am: 07b9ebd24f am: 16ead64d17
Change-Id: I75e65ed0c9fab17c8a190ef2acdd4f4f263e4b6c
2020-05-18 18:31:37 +00:00
Cody Kesting
16ead64d17 Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf am: 07b9ebd24f
Change-Id: I3b6facc6220c5818565fc8d0ed3d1cad4bede2af
2020-05-18 18:29:29 +00:00
Cody Kesting
07b9ebd24f Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." am: 8a38affcbf
Change-Id: I0884098a86de1e96b93dd1c753d7863641f34f0b
2020-05-18 17:38:34 +00:00
Cody Kesting
8a38affcbf Merge "Move Data Stall logic to CS from NetworkMonitorCallbacks." 2020-05-18 17:21:21 +00:00
Cody Kesting
9a6be06466 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de -s ours am: e4e4239b68 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 f4a7e96585 is in history

Change-Id: I1d5f1c2a7059dfc15348126213f620666fdab83a
2020-05-15 16:11:33 +00:00
Cody Kesting
ab88485bc1 [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 -s ours am: e1fa6e1eed -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ccfd0ff534 is in history

Change-Id: Ibdd6d03a7e98bcc30be1832321a3cfe434cd1082
2020-05-15 16:11:25 +00:00
Cody Kesting
e4e4239b68 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 b5c7abd071 is in history

Change-Id: Idb6ea8087b39242e1bab79d7227107303a81f59d
2020-05-15 15:56:40 +00:00
Cody Kesting
e1fa6e1eed [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ba3433669a is in history

Change-Id: I378c8d86396f0a8ddb803b86ef8426b4dca1c153
2020-05-15 15:56:20 +00:00
Cody Kesting
9b3c05e670 [automerger skipped] Merge "Create TestApi for simulating a Data Stall on ConnectivityService." into rvc-dev am: aa921179de am: 8ed473a5e6 -s ours
am skip reason: Change-Id Icad439efa2ab4c872c21d3ee6ceaae8c5b49f18d with SHA-1 b5c7abd071 is in history

Change-Id: I92ebe59e56a221d9f998286dc9a6d8d1993b12a0
2020-05-15 15:51:31 +00:00
Cody Kesting
8524babf8d [automerger skipped] Merge "Set owner and administrator UIDs for test networks." into rvc-dev am: 52655a00d0 am: f5780f203f -s ours
am skip reason: Change-Id I3a974700aa1d83cb285295ed1de0aa263e2e5b58 with SHA-1 ba3433669a is in history

Change-Id: I7009a06d57286347c5fae2355132d2f217863383
2020-05-15 15:51:19 +00:00
Treehugger Robot
7af6037609 Merge "Address nit from aosp/1301317" am: 14a5bf9510 am: 7b20fde8c9 am: b0af0ee400
Change-Id: Ib5bb0a7349523274f825832a7fc71aa9ed95b764
2020-05-15 07:43:42 +00:00
Treehugger Robot
b0af0ee400 Merge "Address nit from aosp/1301317" am: 14a5bf9510 am: 7b20fde8c9
Change-Id: I7ae9b80954309b18eb6923da3aeaab3d1b8e3231
2020-05-15 07:14:29 +00:00
Treehugger Robot
7b20fde8c9 Merge "Address nit from aosp/1301317" am: 14a5bf9510
Change-Id: I2443c5da4b69bce693a39e894c41db5b25b6cf03
2020-05-15 07:03:31 +00:00
Treehugger Robot
14a5bf9510 Merge "Address nit from aosp/1301317" 2020-05-15 06:43:42 +00:00
Benedict Wong
d65104d078 Merge "Add methods for IKEv2/IPsec test mode profiles" am: 0dfb2b7b68 am: c2bdca3a27 am: b1368b92eb
Change-Id: I03dd060ae9de05f9491a37f321faacdadab73965
2020-05-15 03:12:05 +00:00
Benedict Wong
b1368b92eb Merge "Add methods for IKEv2/IPsec test mode profiles" am: 0dfb2b7b68 am: c2bdca3a27
Change-Id: I353d999ebcdd108a900abfe20be232e83147b6d2
2020-05-15 02:51:43 +00:00
Benedict Wong
c2bdca3a27 Merge "Add methods for IKEv2/IPsec test mode profiles" am: 0dfb2b7b68
Change-Id: I9ff22188a641fce6b7bd44f7619d1b825988667a
2020-05-15 02:35:39 +00:00
Benedict Wong
0dfb2b7b68 Merge "Add methods for IKEv2/IPsec test mode profiles" 2020-05-15 02:18:02 +00:00