Commit Graph

216 Commits

Author SHA1 Message Date
Motomu Utsumi
d4a1c63c5d cronet: re-enable lint
Bug: 265674359
Test: TH
Change-Id: I867a66518db0eb9fe446aa28e07d4678f0e3af94
2023-03-10 19:01:18 +09:00
Motomu Utsumi
d229268989 cronet: Hide old newUrlRequestBuilder
Bug: 272009719
Bug: 265674359
Test: TH
Change-Id: If98ea3c45d9e181773f9d5877462d4d3c6097302
2023-03-10 13:38:08 +09:00
Motomu Utsumi
04de61f9e9 Merge "cronet: Make BidirectionalStream.Callback interface" 2023-03-09 16:19:07 +00:00
Treehugger Robot
ba0f26fb86 Merge changes from topics "setter_getter_fix", "use_header_block"
* changes:
  cronet: Use HeaderBlock for getHeaders API
  cronet: Address Setter/Getter related API linter issues
2023-03-09 15:03:34 +00:00
Dan Stahr
78cfe3336b Merge "Expose the getter for idle connection timeout." 2023-03-09 11:33:18 +00:00
Dan Stahr
f63b5df622 Expose the getter for idle connection timeout.
Test: m
Bug: 271423645
API-Coverage-Bug: 251012627
Change-Id: I10862786e83e79ced1c4afd9328d6a158bae7232
2023-03-09 11:32:11 +00:00
Motomu Utsumi
d41fa7b77c cronet: Make BidirectionalStream.Callback interface
Bug: 271423645
Bug: 265674359
Test: TH
Change-Id: I0efb1ad4719a62b1e7ad2c96af0660e212dbb966
2023-03-09 18:33:55 +09:00
Motomu Utsumi
444192ad69 cronet: Use HeaderBlock for getHeaders API
Bug: 265674359
API-Coverage-Bug: 251012627
Test: TH
Change-Id: I03bfafdc6c855f38145eb9d35c1f0ac6934d903f
2023-03-09 18:33:55 +09:00
Motomu Utsumi
00b4a97224 cronet: Address Setter/Getter related API linter issues
Bug: 271423645
Bug: 265674359
Test: TH

Change-Id: Id1628dd7af48a8e079636924b66368db0eb2ec4e
2023-03-09 18:33:52 +09:00
Motomu Utsumi
41b5e83be0 cronet: Fix remaining MissingNullability API linter issue
Bug: 265674359
Test: TH
Change-Id: I7e498d12469a974aa5b4f1d94223e6254e072c29
2023-03-08 11:39:51 +09:00
Chidera Olibie
bff88ee900 cronet: Fix some MissingNullability API lineter issues
Bug: 265674359
Test: th
Change-Id: I710b2cfb0bc358ef7ed24ccaf04c91d56e75ecba
2023-03-08 11:39:31 +09:00
Motomu Utsumi
7c1505915c cronet: Fixed AcronymName API linter issue
Bug: 265674359
Test: TH
Change-Id: Icd786451641f32022587ca95714233d476804e67
2023-03-06 17:15:38 +09:00
Motomu Utsumi
73d869f1b2 cronet: Fix ListenerInterface API linter error
Update UrlRequest.StatusListener to interface

Bug: 265674359
Test: TH
Change-Id: Ib3c0f3dcc42add6e529fc4f36e735ce7ab1fc633
2023-03-06 17:15:38 +09:00
Motomu Utsumi
45a35aec20 cronet: Fix ListenerLast API linter error
This CL adds method with the right signature since there's an internal
caller of old API.
Old API will be removed once the caller has been updated.

Bug: 265674359
Test: TH
Change-Id: I5e614530163d4f05fda0bff3966ba34e7a24d34e
2023-03-06 17:14:04 +09:00
Motomu Utsumi
5505063c1b cronet: Addressed StaticFinalBuilder API linter errors
Bug: 265674359
Test: TH
Change-Id: I767e276413112aa4b1a03e7821c4b3992a2e28c1
2023-03-03 20:02:44 +09:00
Motomu Utsumi
15a147ce7a cronet: Fix BuilderSetStyle API lint errors
Bug: 265674359
Test: TH
API-Coverage-Bug: 251012627
Change-Id: Ie420d553d18c88a2fa654ae41cca8812c863af20
2023-03-03 20:02:44 +09:00
Motomu Utsumi
0ace420204 cronet: Fix MissingNullability API linter errors
Bug: 265674359
Test: TH
Change-Id: Ibaceeaf5f851c0d901c09942a63f038b612818cc
2023-03-03 20:02:41 +09:00
Dan Stahr
3cf0829e71 Expose the socket tagging APIs in Android.
Addressing API Councillor feedback, this is necessary for feature parity
between existing networking APIs and AOSP Cronet.

Test: m
API-Coverage-Bug: 251012627
Change-Id: I462a234dd95aad5a1c09838fbca13b6cf9649cbd
2023-02-17 23:06:34 +00:00
Dan Stahr
35e799efbd Merge "Expose additional Cronet APIs in AOSP." 2023-02-17 23:04:01 +00:00
Dan Stahr
62d57d09c2 Expose additional Cronet APIs in AOSP.
This is required to provide a reasonably feature-comnplete
implementation of current org.chromium.net APIs on top of
android.net.http. The main targets for this change are gRPC (mostly
bidirectional streaming) and prospective early adopters.

Test: m
API-Coverage-Bug: 251012627
Change-Id: I66341581501090641c7eea32de5a5b8453cd97d4
2023-02-17 18:34:59 +00:00
Dan Stahr
722a5f2c5e Merge "Expose the network binding APIs in AOSP." 2023-02-14 14:56:23 +00:00
Dan Stahr
0d2d19a706 Reflect changes from r.android.com/2426234 in the API surface.
HttpEngine.getVersion() can be implemented directly as the API and implementation versions don't differ in AOSP.

Test: m
Change-Id: Ide6881f8978cb8890d585f760cd0d1225a4c2542
2023-02-13 13:00:17 +00:00
Dan Stahr
33a98282e5 Expose the network binding APIs in AOSP.
See the other topic CLs for code changes.

Test: m
API-Coverage-Bug: 251012627
Change-Id: Iad5c500139ce17d834e122e373ca6d0ebee28265
2023-02-09 11:54:38 +00:00
Patrick Rohr
ffdeb180a1 cronet: remove cronet_java_defaults_enabled_srcs
external/cronet has been added to the default manifest in
tm-mainline-prod, so this soong variable is not needed anymore.

Test: TH
Merged-In: I5750d87c9cab0e9d4d213b5a81a2d71cc9610a08
Change-Id: I5750d87c9cab0e9d4d213b5a81a2d71cc9610a08
2023-01-25 01:07:04 -08:00
Dan Stahr
e2be25f6a0 Add Cronet to the Tethering apex.
Test: m
API-Coverage-Bug: 258707653

Change-Id: I2d6401ec719ce265abdb30d6ba8fd94861845197
2023-01-17 08:06:53 -08:00
Motomu Utsumi
841643a95e cronet: Introduce constant for CronetJavaDefaultsEnabled srcs
This is required temporarily until the external/cronet is auto-merged
to tm-mainline-prod

Test: m
Change-Id: Ie875e4108a0b2a82e9615d1f32f3b0bf76572146
2023-01-17 15:03:03 +09:00
Dan Stahr
1a8d9d1521 Set up the jarjar config generator for the Tethering module.
This does not affect existing classes in framework-tethering.jar
as everything inside android.net is excluded from being jarjar'ed.
It is a preparatory step to adding cronet to framework-tethering.jar
which will use jarjar.

Test: m
Change-Id: I8cc7babaa37f7aef52306a833593dba097fd26db
2023-01-13 02:26:19 -08:00
Patrick Rohr
a6d600ff50 cronet: enable defaults in aosp
Automerger into tm-mainline-prod is currently broken, so this change
uses a Merged-In line that is already present in tm-mainline-prod (and
downstream from it). This means that this change must also be
cherry-picked into internal-master with a slightly different Merged-In
specification.

Test: TH
Merged-In: I555ad1ed687632cfe8a7e30283f80e80956fc1d4
Change-Id: I25096f4cc21923c602d77a66aad248d52b42b18f
2023-01-06 04:13:56 -08:00
Patrick Rohr
3b9ba6acdf cronet: add defaults to enable / disable Cronet in framework-tethering
A similar option already exists in
packages/modules/Connectivity/Cronet/apex/Android.bp. This is in
preparation of adding cronet to framework-tethering. It is possible that
we only end up using one of the variables but better safe than sorry.

This change will be blocked by the blocked automerger into
tm-mainline-prod. If this continues to be a problem, we might have to
play some tricks with automerger.

Test: TH
Change-Id: I40ba22aba041ec12ec2bf2881df14e6c0ee53b44
2023-01-06 04:12:59 -08:00
Igor Chernyshev
9dac660bf0 Add CDM dependency in Tethering
This change introduces a limited library for dependencies on
framework-connectivity from Tethering,
connectivity-internal-api-util, where all classes are annotated with
@RequiresApi(S) to ensure proper API checks are done before usage.

Bug: 245972418

Change-Id: I82bafd9063341adc71d07f0858e6d68283d081f0
2022-12-16 17:55:53 +00:00
Mark Chien
381e339647 Merge "Remove unused TetheringConfigurationParcel fileds" 2022-10-21 07:50:23 +00:00
Cole Faust
fe60c0fe31 Fix array-related errorprone warnings
The ArrayEquals, ArrayHashCode, ArrayToString, and
ArraysAsListPrimitiveArray errorprone findings were
demoted from errors to warnings. Fix existing
occurrences of them so they can be made errors again.

Bug: 242630963
Test: RUN_ERROR_PRONE=true m javac-check
Change-Id: I95b4d0f8d3dfa957285ca94e0846fd3da4734e57
2022-08-22 00:30:47 +00:00
Mark Chien
40caeb78f3 Remove unused TetheringConfigurationParcel fileds
Bug: 237338640
Test: atest TetheringTests

Change-Id: Ic851e2e9ed16b5be6f5b1380f6b905fcc1e131cf
2022-08-16 15:58:44 +00:00
Mark Chien
b03b4dd899 Merge changes I41ae1d61,I334860af am: 794d04d779
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2167064

Change-Id: Ic38c1111925c571ae020a3d0b2437939bd844dfa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-28 02:49:10 +00:00
Mark Chien
874a3e273e Revert "Revert "Add onSupportedTetheringType callback""
This reverts commit 4bf22ae076.

Reason for revert: land the change again

Change-Id: I334860af201ce0faa09f1dbb8935bc9fddd66c50
2022-07-20 06:18:13 +00:00
Mark Chien
6e8549b3ab Merge "Revert "Add onSupportedTetheringType callback"" am: 370ba4f3c5
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2150813

Change-Id: I29e07baaa0c921c769c030f37f78cf48e5028e74
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-12 07:47:52 +00:00
Mark Chien
4bf22ae076 Revert "Add onSupportedTetheringType callback"
This reverts commit ae3d303344.

Reason for revert: this cause GTS fail
Bug: 238038401

Change-Id: I3e21321e931f60208cb0befaed38e58b088ff966
2022-07-12 02:11:48 +00:00
Mark Chien
5702c68944 Merge "Add onSupportedTetheringType callback" am: c4379c2440 am: fb8dc55f47
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/1940847

Change-Id: I824f6f485ce7411ef59a3fa3abbb645869e92f31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-20 06:13:52 +00:00
markchien
ae3d303344 Add onSupportedTetheringType callback
This new callback could tell caller Tethering is supported for what tethering
types.

Bug: 184996041
Test: atest TetheringTests
      atest EthernetTetheringTest
CTS-Coverage-Bug: 223340235

Change-Id: Ib80ed8d7f73f4a098b8965db186d24d8cf1884d3
2022-04-20 00:41:41 +08:00
Xin Li
a459e6a12d Merge sc-v2-dev-plus-aosp-without-vendor@8084891
Bug: 214455710
Merged-In: I5894450f3089b2ea105722a18ddf8f1eed1c28a0
Change-Id: If2045705da821c90705f7dd1e6944c0bb92e3289
2022-02-11 06:57:49 +00:00
Remi NGUYEN VAN
85a4e07826 Add visibility for core tests
Allow core tests to use hidden connectivity APIs. Benchmark tests in
particular cannot be run without these.

Ignore-AOSP-First: Avoiding merge conflicts, cherry-pick will follow
Bug: 197717846
Test: m
  (cherry-picked from ag/16772124)
Change-Id: Ia01f24317d14b063f9a7e24c3ada11b140641c50
Merged-In: Ia01f24317d14b063f9a7e24c3ada11b140641c50
2022-02-09 23:08:37 +08:00
Aaron Huang
720ad7c026 Have connectivity targets be visible to Frameworks[Vcn|Ike]Tests
(cherry picked from commit 7174ac3d86)
Bug: 204153604
Ignore-AOSP-First: part of large topic that only builds internally
Test: build, FrameworksVcnTests, FrameworksIkeTests
Change-Id: I40740200fe4a7476a21bb5330429a11c97e38fb8
Merged-In: I40740200fe4a7476a21bb5330429a11c97e38fb8
2022-02-08 14:31:27 +00:00
Remi NGUYEN VAN
bdaa351e8a Add visibility for core tests
Allow core tests to use hidden connectivity APIs. Benchmark tests in
particular cannot be run without these.

Ignore-AOSP-First: Avoiding merge conflicts, cherry-pick will follow
Bug: 197717846
Test: m
Change-Id: Ia01f24317d14b063f9a7e24c3ada11b140641c50
2022-02-07 10:11:40 +09:00
Aaron Huang
7174ac3d86 Have connectivity targets be visible to Frameworks[Vcn|Ike]Tests
Bug: 204153604
Ignore-AOSP-First: part of large topic that only builds internally
Test: build, FrameworksVcnTests, FrameworksIkeTests
Change-Id: I40740200fe4a7476a21bb5330429a11c97e38fb8
2022-02-02 23:53:43 +00:00
Chiachang Wang
8e4530c439 Merge "Enable strict_updatability_linting in connectivity src" am: 81bc609550 am: e5c363a3bd am: 6a1c5dc295
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/1902533

Change-Id: I30bcf47dc757cd3fa8672aa9bc775ba612daa65a
2021-12-08 03:29:53 +00:00
Chiachang Wang
3bc5276568 Enable strict_updatability_linting in connectivity src
Bug: 188851968
Test: m lint-check
Change-Id: I3cd06ea16f05cb37d9369a48dd0285d8239fd764
2021-11-26 10:31:58 +08:00
Treehugger Robot
f83c080ea8 Merge "Add TetheredInterface{Request, Callback} interface" am: 7269fb17fd am: 5b6e2b3509 am: 12f02fa941 am: 0287eafe07
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/1873874

Change-Id: I34b9fae1da161ae3db5d22f56334ea7c9c3b9278
2021-11-08 10:48:13 +00:00
markchien
48e271bdcb Add TetheredInterface{Request, Callback} interface
Define interfaces that match the signature of the existing
EthernetManager.TetheredInterfaceRequest and TetheredInterfaceCallback
classes and make EthernetManager.TetheredInterfaceRequest and
TetheredInterfaceCallback implement/subinterface these interfaces. The
new bluetooth API could also implement these interfaces to make API surface
consistent.

Test: TH would test the existing tests that use the subclass.
Bug: 190438212
Change-Id: I093972c111cb1d921076782492716d5a046be8fc
2021-11-08 16:44:34 +08:00
Treehugger Robot
9771458a49 Merge "Unregister the tethering internal callback in finalize" am: f8d1f3d1cd am: c472eed19a am: e92e0a4e9a am: eed118a4bf
Original change: https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/1838543

Change-Id: If4d032058b4e28dfb70ceb1064e4bc5e4dfbdf00
2021-10-20 09:40:57 +00:00
Treehugger Robot
f8d1f3d1cd Merge "Unregister the tethering internal callback in finalize" 2021-10-20 08:40:08 +00:00