Commit Graph

7930 Commits

Author SHA1 Message Date
Automerger Merge Worker
cd4a924e90 Merge "rm libbinderthreadstate" am: d072174fbc am: 4041565ef6
Change-Id: I25aacc3f1cd9c3544e90934c37cff5a973a7bd7b
2020-02-09 23:44:07 +00:00
Automerger Merge Worker
4041565ef6 Merge "rm libbinderthreadstate" am: d072174fbc
Change-Id: Ib7de947aa4ee5b349c9576355869702ac94d8624
2020-02-09 23:27:45 +00:00
Treehugger Robot
d072174fbc Merge "rm libbinderthreadstate" 2020-02-09 23:06:21 +00:00
Automerger Merge Worker
8a7b232080 Merge "[NS A43] Separate updating the linger timer and sending LOSING" am: 10c32e38a2 am: 42a3342ed7
Change-Id: Id7ed8f80307d2e1252195a6aef62e51d0c4e7f27
2020-02-09 07:21:19 +00:00
Automerger Merge Worker
5fff418068 Merge "[NS A42] Move writing to the reassignment to the computation" am: 113d552eff am: f0c7699e38
Change-Id: Iebe3dbd3b98f4b92486e86c48b0e50b6713b2aa6
2020-02-09 07:20:57 +00:00
Automerger Merge Worker
42a3342ed7 Merge "[NS A43] Separate updating the linger timer and sending LOSING" am: 10c32e38a2
Change-Id: I4b8e7eec2df77d04700582542d6f3f2fb455c2af
2020-02-09 07:06:13 +00:00
Automerger Merge Worker
f0c7699e38 Merge "[NS A42] Move writing to the reassignment to the computation" am: 113d552eff
Change-Id: Ic04c72d0720bb53a38329dbcbc75cd914e1296c0
2020-02-09 07:05:54 +00:00
Chalard Jean
10c32e38a2 Merge "[NS A43] Separate updating the linger timer and sending LOSING" 2020-02-09 06:51:06 +00:00
Chalard Jean
113d552eff Merge "[NS A42] Move writing to the reassignment to the computation" 2020-02-09 06:50:48 +00:00
Automerger Merge Worker
fab9832dc7 Merge "[NS A41] Cut out a function to update NAI info" am: 956532eb3e am: ffc43638ef
Change-Id: If22b44893c33c3640a85eed7e6dc0ce888018059
2020-02-09 05:33:29 +00:00
Automerger Merge Worker
ffc43638ef Merge "[NS A41] Cut out a function to update NAI info" am: 956532eb3e
Change-Id: I668fe3095ee9184b50db83d8f52f572dc57cfa1f
2020-02-09 05:09:07 +00:00
Chalard Jean
956532eb3e Merge "[NS A41] Cut out a function to update NAI info" 2020-02-09 04:56:37 +00:00
Automerger Merge Worker
00afbce489 Merge "Fix typo in ConnectivityDiagnosticsManager constant." am: 5ee2390f0b am: 406345a19c
Change-Id: Iab752a848a8017fbfdc4517502d5a39d8201a682
2020-02-07 17:22:37 +00:00
Automerger Merge Worker
406345a19c Merge "Fix typo in ConnectivityDiagnosticsManager constant." am: 5ee2390f0b
Change-Id: Icaae03ca1895de4012deed1c1b81b16fad4ba439
2020-02-07 17:08:20 +00:00
Cody Kesting
5ee2390f0b Merge "Fix typo in ConnectivityDiagnosticsManager constant." 2020-02-07 16:57:19 +00:00
Steven Moreland
93e27f5f77 rm libbinderthreadstate
This library is empty, and its functionality has moved
into libbinder/libhwbinder.

Bug: 148692216
Test: N/A
Change-Id: I3ee973cef68281cb57b4912b4b66c798b5d9d715
2020-02-06 13:23:47 -08:00
Automerger Merge Worker
3fd040a4f2 Merge "Use waitForIdle() to wait for Threaded processing." am: a67124b1af am: cfa95efc78
Change-Id: I1d648dd7d700230afab893336ef853a41717ba80
2020-02-06 16:23:10 +00:00
Automerger Merge Worker
8d58f46d52 Merge "Fire ConnectivityDiagnostics callbacks on Connectivity reported." am: bd021eb75e am: e42c0bbb01
Change-Id: I44d75efacebae77914eda6da7efaaf11676e71fc
2020-02-06 16:22:50 +00:00
Automerger Merge Worker
e183639edf Merge "Implement INetworkMonitorCallbacks#notifyDataStallSuspected." am: d0045a1064 am: 08850cb3fb
Change-Id: Iebcb87445b9bb7b36052c62160b4069b76432a18
2020-02-06 16:21:44 +00:00
Automerger Merge Worker
cfa95efc78 Merge "Use waitForIdle() to wait for Threaded processing." am: a67124b1af
Change-Id: Ida71ad5d045f87dd11877dc93d42885333bba336
2020-02-06 16:10:28 +00:00
Automerger Merge Worker
e42c0bbb01 Merge "Fire ConnectivityDiagnostics callbacks on Connectivity reported." am: bd021eb75e
Change-Id: I60d418afb145238981c17cc9a29ff57dc42c1ff0
2020-02-06 16:10:05 +00:00
Automerger Merge Worker
08850cb3fb Merge "Implement INetworkMonitorCallbacks#notifyDataStallSuspected." am: d0045a1064
Change-Id: I20aab2e77056df67df5bf9e9d6bd1888cf17a558
2020-02-06 16:08:33 +00:00
Cody Kesting
a67124b1af Merge "Use waitForIdle() to wait for Threaded processing." 2020-02-06 15:54:53 +00:00
Cody Kesting
bd021eb75e Merge "Fire ConnectivityDiagnostics callbacks on Connectivity reported." 2020-02-06 15:54:06 +00:00
Cody Kesting
d0045a1064 Merge "Implement INetworkMonitorCallbacks#notifyDataStallSuspected." 2020-02-06 15:47:26 +00:00
Chalard Jean
d915e36582 [NS A43] Separate updating the linger timer and sending LOSING
This will be necessary because updating the linger timer is
what lets the network agent know whether the network is

Test: ConnectivityServiceTest
Change-Id: I9b5a36f6d5eac5a404eff6740cd8f4dcbb0c2786
2020-02-06 18:04:13 +09:00
Chalard Jean
81a757ef4e [NS A42] Move writing to the reassignment to the computation
...instead of the side effect loop. This is a no-op refactoring.

Test: ConnectivityServiceTest
Change-Id: I8308d55eaff080efb22a7a43142492545e626cf5
2020-02-06 18:04:09 +09:00
Chalard Jean
f57b969d66 [NS A41] Cut out a function to update NAI info
Test: ConnectivityServiceTest
Change-Id: I6d92fb1699eb0acb1bcd7baa4a5d9d3e1c0dc728
2020-02-06 18:03:30 +09:00
Automerger Merge Worker
a43b0b1379 Merge "[NS A40] Read current reassignment state instead of global state" am: 9af866f454 am: ee850dc0c2
Change-Id: I897076fedc74a810e4eaeb530c496219e26ebbf1
2020-02-06 04:26:56 +00:00
Automerger Merge Worker
ee850dc0c2 Merge "[NS A40] Read current reassignment state instead of global state" am: 9af866f454
Change-Id: I12ca40b29588c651c77d272bcde87fdbe8037f60
2020-02-06 04:23:11 +00:00
Chalard Jean
9af866f454 Merge "[NS A40] Read current reassignment state instead of global state" 2020-02-06 04:14:43 +00:00
Cody Kesting
1bae54ccb1 Use waitForIdle() to wait for Threaded processing.
Unit testing for ConnectivityDiagnostics API in ConnectivityServiceTest
is updated to use HandlerUtilsKt#waitForIdle. In the general case, this
takes the same time to run as verify-with-timeout (used previously).
However, test failures due to messages not being enqueued on the handler
(backed by the ConnectivityService Thread) won't incur the timeout
delay, as the thread will be idle sooner. This shortens the delay in the
event of a programming error.

Bug: 143187964
Test: atest FrameworksNetTests
Change-Id: Iae66309501bb83449ca735dfa5e972a9852cbcd0
2020-02-05 15:05:29 -08:00
Cody Kesting
a58c07c71e Fire ConnectivityDiagnostics callbacks on Connectivity reported.
When ConnectivityService#reportNetworkTested is called, the platform
needs to fire ConnectivityDiagnostics callbacks for registered callbacks
that are permissioned for the network being reported on. This adds a new
event to ConnectivityDiagnosticsHandler for invoking these callbacks.

Bug: 143187964
Test: compiles
Test: atest CtsNetTestCases ConnectivityServiceTest
Change-Id: Icc6bcf7a2411133d8ecd7477bc351dad9333f24f
Merged-In: Icc6bcf7a2411133d8ecd7477bc351dad9333f24f
2020-02-05 15:05:29 -08:00
Cody Kesting
1d326387e4 Implement INetworkMonitorCallbacks#notifyDataStallSuspected.
INetworkMonitorCallbacks defines notifyDataStallSuspected() for
notifying ConnectivityService of networks encountering a potential data
stall. A new event is introduced for ConnectivityDiagnosticsHandler to
process the notification and invoke the relevant
ConnectivityDiagnosticsCallbacks.

Bug: 143187964
Test: compiles
Test: atest CtsNetTestCases FrameworksNetTests
Change-Id: I70320bdda9855dced31e08e6a0b25329fb5cb535
Merged-In: I70320bdda9855dced31e08e6a0b25329fb5cb535
2020-02-05 15:05:28 -08:00
Automerger Merge Worker
36922216ad Merge "Implement INetworkMonitorCallbacks#notifyNetworkTestedWithExtras." am: b68115afb8 am: dcc253f9a5
Change-Id: I3b32a91106646e98cf52b4ca48eeb4ebacd164db
2020-02-05 20:23:52 +00:00
Automerger Merge Worker
dcc253f9a5 Merge "Implement INetworkMonitorCallbacks#notifyNetworkTestedWithExtras." am: b68115afb8
Change-Id: I39b74228c6c2a48ace7ad36dba995fa6f91bfbb5
2020-02-05 20:09:32 +00:00
Cody Kesting
b68115afb8 Merge "Implement INetworkMonitorCallbacks#notifyNetworkTestedWithExtras." 2020-02-05 19:55:05 +00:00
Cody Kesting
d292a330c1 Implement INetworkMonitorCallbacks#notifyNetworkTestedWithExtras.
INetworkMonitorCallbacks defines notifyNetworkTestedWithExtras() for
notifying ConnectivityService of networks being tested along with a
PersistableBundle of extras. A new event is introduced for
NetworkStateTrackerHandler to notify the ConnectivityDiagnosticsHandler
before continuing with the normal processing for "network tested"
notifications. The event is also used in the
ConnectivityDiagnosticsHandler.

Bug: 143187964
Bug: 147391402
Test: compiles.
Test: atest CtsNetTestCases FrameworksNetTests
Change-Id: Iab29da790c0f5faae68227770bc3a84bbc94f124
Merged-In: Iab29da790c0f5faae68227770bc3a84bbc94f124
2020-02-05 18:48:12 +00:00
Cody Kesting
c52e5aa76e Fix typo in ConnectivityDiagnosticsManager constant.
This change fixes a typo in the value assigned to the constant
KEY_NETWORK_PROBES_ATTEMPTED_BITMASK, which is defined in
ConnectivityDiagnosticsManager.ConnectivityReport.

Bug: 148939502
Test: compiles
Change-Id: I63863efa8c69593012bf4e95d896db192c6bfb5c
2020-02-05 08:56:48 -08:00
Automerger Merge Worker
4ea20ef2f0 Merge changes Ic1a5d032,I271e7f4d,I7af37281 am: 775babe0c6 am: f011628969
Change-Id: If59fd7e540dbb2fa49cb10e5193ad3b5e044b39e
2020-02-05 01:03:09 +00:00
Automerger Merge Worker
f011628969 Merge changes Ic1a5d032,I271e7f4d,I7af37281 am: 775babe0c6
Change-Id: Ia1ec0ddbe841536f6525a9b5579603af620dae56
2020-02-05 00:59:17 +00:00
Chalard Jean
775babe0c6 Merge changes Ic1a5d032,I271e7f4d,I7af37281
* changes:
  [NS A39] Simplification
  [NS A38] Fill the initial reassignment
  [NS A37] Don't reassign requests multiple times
2020-02-05 00:53:28 +00:00
Automerger Merge Worker
735f90f644 Merge "Add separate user consent for Platform VPNs" am: 53bc29df86 am: 1784e620b6
Change-Id: If2d856c62b77da4bc8ea99335b1e89170f24fbca
2020-02-05 00:24:10 +00:00
Automerger Merge Worker
1784e620b6 Merge "Add separate user consent for Platform VPNs" am: 53bc29df86
Change-Id: I38ceff087e37f6ede6819e706c36ee9129a1cc6b
2020-02-05 00:07:41 +00:00
Benedict Wong
53bc29df86 Merge "Add separate user consent for Platform VPNs" 2020-02-04 23:56:16 +00:00
Benedict Wong
6458ddff18 Add separate user consent for Platform VPNs
This change adds a new VPN user consent flow (using the same text) for
granting the lesser OP_ACTIVATE_PLATFORM_VPN. A new
PlatformVpnConfirmDialog is created as a subclass to preserve all logic,
but ensure the right appop is granted for the relevant dialog.

Intent extras were considered, but are inherently unsafe, since the
caller may add any extras that they would want.

Bug: 144246835
Test: FrameworksNetTests passing
Change-Id: Ia6f36207d43c3748f938430c2780dcf29e5623f3
Merged-In: Ia6f36207d43c3748f938430c2780dcf29e5623f3
2020-02-04 21:05:36 +00:00
Automerger Merge Worker
ebf43a3221 Merge changes Icb062ffb,I66c4e8f5,I85247411,Id47c19b7,Ib713c4ae, ... am: 0b32981970 am: e8f922bf04
Change-Id: Id88e2387eedf611e2347605b97b4ec9031eaada8
2020-02-04 13:41:11 +00:00
Automerger Merge Worker
e8f922bf04 Merge changes Icb062ffb,I66c4e8f5,I85247411,Id47c19b7,Ib713c4ae, ... am: 0b32981970
Change-Id: I6b601f88b8411de9d1a5551d9b9b6c3e329087f4
2020-02-04 13:30:03 +00:00
Chalard Jean
7431e20d9f [NS A40] Read current reassignment state instead of global state
The reassignment state has the future value, but is transient
instead of global. With this, the reassignment loop does not
read from global state any more, so it's not affected by the
side effects from the loop.

This means future patches will be able to move the side effects
out of the computation.

Test: atest ConnectivityServiceTest
Change-Id: I43499f19730bcd94b691cfea83aa1ca1d3de75db
2020-02-04 21:18:25 +09:00
Chalard Jean
1ade57a05c [NS A39] Simplification
If newNetwork is satisfying this request, it means it is the old
satisfier. Plain and simple.

Test: ConnectivityServiceTest
Change-Id: Ic1a5d032801bac476b1c1f53da6f1c4c6056bff0
2020-02-04 16:49:54 +09:00