Hugo Benichi ec41a56b55 DO NOT MERGE: ConnectivityServiceTest: fix testAvoidBadWifiSettings ...

This patch introduces an assertEventuallyThat helper function in
ConnectivityServiceTest which given a boolean function retries until the
function returns true or until a maximum retry time is reached.

This function is used to fix flakyness of testAvoidBadWifiSetting where
the Message posted by reevaluate() could reach the Handler's
MessageQueue after waitForIdle takes effect, resulting in the test to
fail.

Instead of fixing the flakyness by introdcing hard sleep times,
assertEventuallyThat is used to reduce the overall test time.

With this change the test has been observed to pass with 100% success
rate over 50000 invocations.

Test: $ runtest frameworks-net
Bug: 32561414

(cherry picked from commit ccf7f00258)

(cherry picked from commit aadb059a9f)

Change-Id: I432f90a699dadfef37a5d0a69e25050753340964

2017-01-18 19:08:39 +09:00

core

DO NOT MERGE: ConnectivityThread: use lazy holder idiom

2017-01-18 19:08:23 +09:00

services

DO NOT MERGE: Refactored NetworkStatsServiceTest to use Mockito instead of EasyMock.

2017-01-18 19:08:29 +09:00

tests

DO NOT MERGE: ConnectivityServiceTest: fix testAvoidBadWifiSettings

2017-01-18 19:08:39 +09:00

Description

android_packages_modules_Connectivity

189 MiB

Languages

Java 81.4%

Kotlin 7.7%

AIDL 4.5%

C++ 4.5%

C 1.7%

Other 0.1%