It is not ideal to try to handle two separate enums within one switch.
Handle those separately to avoid:
src/binder_util.c:282:5: warning: case value ‘23’ not in enumerated type ‘RADIO_PREF_NET_TYPE’ {aka ‘enum radio_pref_net_type’} [-Wswitch]
282 | case RADIO_PREF_NET_NR_ONLY:
| ^~~~
src/binder_util.c:285:5: warning: case value ‘24’ not in enumerated type ‘RADIO_PREF_NET_TYPE’ {aka ‘enum radio_pref_net_type’} [-Wswitch]
285 | case RADIO_PREF_NET_NR_LTE:
src/binder_cbs.c: In function 'binder_cbs_set_config':
src/binder_cbs.c:229:41: warning: implicit declaration of function 'atoi' [-Wimplicit-function-declaration]
229 | config->fromServiceId = atoi(range[0]);
src/binder_gprs_context.c: In function 'binder_gprs_context_set_address':
src/binder_gprs_context.c:218:40: warning: implicit declaration of function 'atoi' [-Wimplicit-function-declaration]
218 | const int prefix = atoi(s + 1);
| ^~~~
src/binder_netreg.c: In function 'binder_netreg_nitz_notify':
src/binder_netreg.c:2015:23: warning: implicit declaration of function 'atoi' [-Wimplicit-function-declaration]
2015 | time.utcoff = atoi(tz) * 15 * 60;
| ^~~~
EHRPD is only used in CDMA networks. The modem might not expect
it and raise an INVALID_ARGUMENT when using setPreferredNetworkTypeBitmap.
Signed-off-by: Eugenio Paolantonio (g7) <me@medesimo.eu>
Replaced this warning in the release build:
src/binder_sms.c:1120:13: warning: unused variable 'ind_code' [-Wunused-variable]
guint32 ind_code = self->interface_aidl == RADIO_MESSAGING_INTERFACE ?
^~~~~~~~
with this one (whichi appears in both release and debug builds):
src/binder_sms.c:1124:18: warning: comparison between 'RADIO_IND' {aka 'enum radio_ind'}
and 'enum radio_messaging_ind' [-Wenum-compare]
code == RADIO_MESSAGING_IND_NEW_SMS_ON_SIM);
^~
The enum-compare warning is at least useful because it reminds about
different enums being mixed up.
src/binder_voicecall.c: In function 'binder_voicecall_list_find_call_with_id':
src/binder_voicecall.c:377:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (GSList* l = list; l; l = l->next) {
^
src/binder_voicecall.c: In function 'binder_voicecall_merge_call_lists':
src/binder_voicecall.c:403:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (GSList* l = self->calls; l; l = l->next) {
^
src/binder_voicecall.c: In function 'binder_voicecall_call_state_changed_event':
src/binder_voicecall.c:1386:13: warning: unused variable 'ind_code' [-Wunused-variable]
guint32 ind_code = self->interface_aidl == RADIO_VOICE_INTERFACE ?
^
src/binder_plugin.c: In function 'binder_logger_dump_update_slot':
src/binder_plugin.c:471:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (RADIO_AIDL_INTERFACE i = 0; i < RADIO_AIDL_INTERFACE_COUNT; i++) {
^
src/binder_plugin.c:471:5: note: use option -std=c99, -std=gnu99, -std=c11 or -std=gnu11 to compile your code
src/binder_plugin.c: In function 'binder_logger_trace_update_slot':
src/binder_plugin.c:489:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (RADIO_AIDL_INTERFACE i = 0; i < RADIO_AIDL_INTERFACE_COUNT; i++) {
^
src/binder_plugin.c: In function 'binder_plugin_is_slot_client_connected':
src/binder_plugin.c:533:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (RADIO_AIDL_INTERFACE i = 0; i < RADIO_AIDL_INTERFACE_COUNT; i++) {
^
src/binder_plugin.c: In function 'binder_plugin_slot_shutdown':
src/binder_plugin.c:608:13: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (RADIO_AIDL_INTERFACE i = 0; i < RADIO_AIDL_INTERFACE_COUNT; i++) {
^
src/binder_plugin.c: In function 'binder_plugin_slot_enabled_changed':
src/binder_plugin.c:787:5: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
for (RADIO_AIDL_INTERFACE i = 0; i < RADIO_AIDL_INTERFACE_COUNT; i++) {
^
make: *** [Makefile:204: build/release/binder_plugin.o] Error 1
