ubports-volte/ofono-binder-plugin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[binder-ofono] Tweaked compilation warning binder_sms_on_sim

Browse Source 
Replaced this warning in the release build:

src/binder_sms.c:1120:13: warning: unused variable 'ind_code' [-Wunused-variable]
     guint32 ind_code = self->interface_aidl == RADIO_MESSAGING_INTERFACE ?
             ^~~~~~~~

with this one (whichi appears in both release and debug builds):

src/binder_sms.c:1124:18: warning: comparison between 'RADIO_IND' {aka 'enum radio_ind'}
and 'enum radio_messaging_ind' [-Wenum-compare]
             code == RADIO_MESSAGING_IND_NEW_SMS_ON_SIM);
                  ^~

The enum-compare warning is at least useful because it reminds about
different enums being mixed up.
This commit is contained in:
Slava Monich
2024-11-15 15:13:17 +02:00
parent 2cfc88f62b
commit 6b30a0ec0b
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/binder_sms.c
View File

@@ -1,6 +1,7 @@
/*
* oFono - Open Source Telephony - binder based adaptation
*
* Copyright (C) 2024 Slava Monich <slava@monich.com>
* Copyright (C) 2021-2022 Jolla Ltd.
*
* This program is free software; you can redistribute it and/or modify
@@ -1117,11 +1118,10 @@ binder_sms_on_sim(
gint32 rec;
ofono_info("new sms on sim");
guint32 ind_code = self->interface_aidl == RADIO_MESSAGING_INTERFACE ?
RADIO_MESSAGING_IND_NEW_SMS_ON_SIM : RADIO_IND_NEW_SMS_ON_SIM;
/* newSmsOnSim(RadioIndicationType type, int32 recordNumber); */
GASSERT(code == ind_code);
GASSERT(code == RADIO_IND_NEW_SMS_ON_SIM ||
code == RADIO_MESSAGING_IND_NEW_SMS_ON_SIM);
gbinder_reader_copy(&reader, args);
if (gbinder_reader_read_int32(&reader, &rec)) {
DBG("rec %d", rec);