ubports-volte/ofono
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gprs: Do not detach when running LTE and GPRS is unavailable.

Browse Source 
There are cases where the gprs status might updated to for instance
"unknown" while LTE is the bearer.
In that case we should not set the attach state to FALSE,
since then running LTE the conext activation reflects the attached
state.
This commit is contained in:
Richard Röjfors
2019-08-12 22:37:56 +02:00
committed by Denis Kenzior
parent f7fca8b662
commit 88ee0123ab
1 changed files with 20 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/gprs.c
View File

@@ -1660,6 +1660,15 @@ static void gprs_netreg_removed(struct ofono_gprs *gprs)
gprs_attached_update(gprs);
}
static gboolean on_lte(struct ofono_gprs *gprs)
{
if (ofono_netreg_get_technology(gprs->netreg) ==
ACCESS_TECHNOLOGY_EUTRAN && have_read_settings(gprs))
return TRUE;
return FALSE;
}
static void gprs_netreg_update(struct ofono_gprs *gprs)
{
ofono_bool_t attach;
@@ -1682,8 +1691,7 @@ static void gprs_netreg_update(struct ofono_gprs *gprs)
DBG("attach: %u, driver_attached: %u", attach, gprs->driver_attached);
if (ofono_netreg_get_technology(gprs->netreg) ==
ACCESS_TECHNOLOGY_EUTRAN && have_read_settings(gprs))
if (on_lte(gprs))
/*
* For LTE we set attached status only on successful
* context activation.
@@ -2560,7 +2568,16 @@ void ofono_gprs_status_notify(struct ofono_gprs *gprs, int status)
if (status != NETWORK_REGISTRATION_STATUS_REGISTERED &&
status != NETWORK_REGISTRATION_STATUS_ROAMING) {
gprs_attached_update(gprs);
/*
* For LTE we attached status reflects successful context
* activation.
* Since we in gprs_netreg_update not even try to attach
* to GPRS if we are running on LTE, we can on some modems
* expect the gprs status to be unknown. That must not
* result in detaching...
*/
if (!on_lte(gprs))
gprs_attached_update(gprs);
return;
}