Commit Graph

34405 Commits

Author SHA1 Message Date
Charles Chen
27871db61e Create SampleVisualQueryDetectionService
Create SampleVisualQueryDetectionService for the Sample VoiceInteractor
devlopment app. The service currently only has the no functionalities.
Only the creation and initialization is integrated.

Test: Manual
Bug: 261517532
Change-Id: Ia5354b24e21854fb5e53857f9a6db7c8b80d3f5a
2023-01-12 21:13:18 +00:00
Kean Mariotti
e75ca180ff Fix rects view (weird triangular shapes)
Rectangles with property cornerRadius === 0 could result
in weird triangular shapes being drawn instead of rectangles

Fix: b/264541479
Test: follow steps in b/264541479 and check issue is gone
Change-Id: I2421e47cdbf7c932218640f2553647ded676a80d
2023-01-05 17:04:03 +00:00
Kean Mariotti
7ea7bf3815 Merge changes I126a5f2f,I522d5d9f,I0eb35399,If3a79de6
* changes:
  Fix title (WinscopeNg => Winscope)
  Fix parsing of timeline's timestamp input
  Fix tslint errors
  Add tslint
2023-01-05 13:11:34 +00:00
Kean Mariotti
25682f6e34 Fix title (WinscopeNg => Winscope)
Bug: b/264247967
Test: open app and check the title is 'Winscope'
Change-Id: I126a5f2f714c2fbefa42f2d7281abb9b2feb798f
2023-01-05 13:03:42 +00:00
Kean Mariotti
e1cfda57cb Fix parsing of timeline's timestamp input
Test: npm run build:all && npm run test:all
Fix: b/264504813
Change-Id: I522d5d9f47a684e013d405ed6b6395820354ef3c
2023-01-05 13:03:42 +00:00
Kean Mariotti
db3015b799 Fix tslint errors
Test: npm run build:all && npm run test:all
Change-Id: I0eb35399afc4156b93a9b1d5213c70c4baa63316
2023-01-05 13:03:42 +00:00
Kean Mariotti
80105ae0ca Add tslint
Add tslint with google3 config (google3/javascript/typescript/tslint).

Skipped google3 custom rules that need to be built and added to the project.

If needed, with some extra effort it should be possible
to get the google3 rules to build/run also in the Winscope environment.
However, it is probably simpler and quicker to run (and maybe fix?)
those checks on critique once we port Winscope to google3.

Fix: b/264505907
Test: npm run tslint:check / npm run tslint:fix
Change-Id: If3a79de673503e0c06541f0329163dee93849c3c
2023-01-05 13:03:42 +00:00
TreeHugger Robot
55c14c15b0 Merge "Update API 34 release config and emulator files for UDC DP 1 " 2023-01-04 23:49:00 +00:00
Kean Mariotti
a3d891dab6 Reorganize src/common package
- Move src/common/trace => src/trace (make its own package)
- Move src/common/utils => src/common

Fix: b/264362866
Test: npm run build:all && npm run test:all
Change-Id: I9941997d1f0f7ef5558ed75a56d48acba69e39a3
2023-01-04 11:04:41 +00:00
Kean Mariotti
9ffaca7fdb Rename source files to be google3-compliant
<name>.module.ts => <name>_module.ts
<name>.component.ts => <name>_component.ts
<name>.component.spec.ts => <name>_component_test.ts
<name>.spec.ts => <name>_test.ts
main.prod.ts => main_prod.ts
main.dev.ts => main_dev.ts

Fix: b/263471805
Test: npm run build:all && npm run test:all
Change-Id: I190c6be7a552624e7965568f04cb498305d37683
2023-01-04 09:38:50 +00:00
Kean Mariotti
fbec45f115 Fix rounded rect corners computation
Handle the case where corner radius > height/2 (or width/2)

Fix: b/264264761
Test: npm run build:all && npm run test:all
Change-Id: I9327189a3b9a59128d9ed3cc885f5887900a952a
2023-01-04 08:28:09 +00:00
Neha Jain
6a9a13f010 Update API 34 release config and emulator files for UDC DP 1
Bug: 264307057
Change-Id: I71518a343b8ecabfa1703a04e2a233bbe99fc97e
2023-01-03 23:23:09 +00:00
Hui Yu
a9f2d0567d Merge "Specify foreground service type and permissions for FGS under development/samples" 2023-01-03 17:40:33 +00:00
Hui Yu
412e563671 Specify foreground service type and permissions for FGS under development/samples
TO meet the U requirement that apps targetSdkVersion U+ must specify
foreground service type and permissions.

Bug: 262580021
Test: build and run.
Change-Id: I0e6bf918b17eee82bdb2669a8c28e17e327a728f
2023-01-03 17:39:01 +00:00
Kean Mariotti
4c849366bf Rename winscope-ng => winscope
Fix: b/264247967
Test: npm install && npm run build:all && npm run test:all
Change-Id: I562e7386a1fe250f5042f2aec67d4731d4f6d3d7
2023-01-03 16:36:16 +00:00
Kean Mariotti
969b3358d7 Remove legacy Winscope
Bug: b/264247967
Test: not needed
Change-Id: I61108714c08e0a4ab2e0c5bf25931740218e68e8
2023-01-03 15:16:20 +00:00
Kean Mariotti
601c771923 Merge "Fix rects view for WM trace" 2023-01-03 09:05:51 +00:00
Treehugger Robot
2c8c4bebdb Merge "Revert "Provide a script to update the generated Android.bp"" am: a8802bc47a am: 61b1a8bb12 am: 0f8496ddd3
Original change: https://android-review.googlesource.com/c/platform/development/+/2373488

Change-Id: If645019725313f487e15407f19b773bed754a135
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-03 07:20:27 +00:00
Treehugger Robot
0f8496ddd3 Merge "Revert "Provide a script to update the generated Android.bp"" am: a8802bc47a am: 61b1a8bb12
Original change: https://android-review.googlesource.com/c/platform/development/+/2373488

Change-Id: Ied36e079508f43ba458636b667b81ac4b367aa54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-03 06:40:04 +00:00
Treehugger Robot
61b1a8bb12 Merge "Revert "Provide a script to update the generated Android.bp"" am: a8802bc47a
Original change: https://android-review.googlesource.com/c/platform/development/+/2373488

Change-Id: Ifee80edd8427b45c80ff662ac07ac382a46e6e6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-03 05:51:18 +00:00
Treehugger Robot
a8802bc47a Merge "Revert "Provide a script to update the generated Android.bp"" 2023-01-03 05:19:58 +00:00
Justin Yun
699b519ec1 Revert "Provide a script to update the generated Android.bp"
This reverts commit c7c0e42748.

Reason for revert: This workaround is no longer required.

Change-Id: If85cb87c2af02b321bfa484bdfe791ede144d490
2023-01-02 07:12:19 +00:00
Nataniel Borges
0d4a2d2919 Fix rects view for WM trace
The rounded corners property should be 0 on WM traces, instead of null

Fixes: 264024995
Test: open a wm trace and check rects view
Change-Id: I53e6668a8bdaa460e2e740936b719a3a4f813f8c
2023-01-01 10:31:46 +00:00
Nataniel Borges
ed96ad4fc4 Merge "Add cyclic dependencies check" 2023-01-01 10:06:56 +00:00
Nataniel Borges
27e7b80d58 Merge changes Ida110947,I8289c8b2
* changes:
  The great formatting
  Fix eslint errors
2023-01-01 10:06:10 +00:00
TreeHugger Robot
acc3216f0e Merge changes I6f215860,I912a455c
* changes:
  Set up prettier + eslint
  Upgrade chrome driver
2022-12-31 18:30:00 +00:00
Kean Mariotti
547e0f5f4b Add cyclic dependencies check
Add new check based on tool "madge" to prevent cyclic dependencies regressions.
Madge currently reports 10 cycles. The new check makes sure we don't introduce new ones.

Bug: b/261552483
Test: npm run deps_graph:check_cycles
Change-Id: I2630ddcb94101be9b288ce0708fca3231962f406
2022-12-30 15:24:51 +00:00
Kean Mariotti
73be9787b6 The great formatting
Unleash prettier on the entire codebase

Fix: b/263471740
Test: npm run format:check && npm run lint:check
Change-Id: Ida110947bec9c9a9b385c64e126ccf6d7ad6652b
2022-12-30 15:24:43 +00:00
Hsin-Yi Chen
bbc4922306 Merge "Determine struct extensions before calling IRDiffDumper" am: 25a02ee161 am: 90dd62487d am: aa64717b4d
Original change: https://android-review.googlesource.com/c/platform/development/+/2363619

Change-Id: I43b28a7ef5bb0f1f8f3fcdb3bf06c9ff92ea7740
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-30 12:03:47 +00:00
Hsin-Yi Chen
aa64717b4d Merge "Determine struct extensions before calling IRDiffDumper" am: 25a02ee161 am: 90dd62487d
Original change: https://android-review.googlesource.com/c/platform/development/+/2363619

Change-Id: I2b1302a328173ab5ad8a11a84304855f253bbcb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-30 11:22:11 +00:00
Kean Mariotti
1a06fc399f Set up prettier + eslint
- Add npm scripts format:check, format:fix, lint:check, lint:fix
- Include format:check + lint:check into the test suite (test:all)
- Configure eslint to play nice with prettier (basically no format checks)

Test: npm run format:check && npm run lint:check
Bug: b/263471740
Change-Id: I6f215860a24302ed04c2689ac31e4dd4e7e6fd5e
2022-12-30 11:21:46 +00:00
Kean Mariotti
83fdc7fbe0 Fix eslint errors
Test: npm run lint:check
Bug: b/263471740
Change-Id: I8289c8b22d5af5e85fd94ccebf1d82abb0a062c2
2022-12-30 11:21:46 +00:00
Hsin-Yi Chen
90dd62487d Merge "Determine struct extensions before calling IRDiffDumper" am: 25a02ee161
Original change: https://android-review.googlesource.com/c/platform/development/+/2363619

Change-Id: I008131f0e8f256fac8176385bf3d474b22357ffc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-30 10:48:28 +00:00
Kean Mariotti
896aef66b8 Upgrade chrome driver
Test: npm run build:e2e && npm run test:e2e
Change-Id: I912a455c4dc86f3d48265963d1cab4e19e1e7872
2022-12-30 10:29:04 +00:00
Hsin-Yi Chen
25a02ee161 Merge "Determine struct extensions before calling IRDiffDumper" 2022-12-30 09:55:24 +00:00
Hsin-Yi Chen
a062a6cf35 Determine struct extensions before calling IRDiffDumper
This commit moves the functions that determine struct extensions from
ir_diff_representation.cpp to abi_diff_helpers.cpp. The functions
are called before IRDiffDumper so that the IR and the dumper do not
include the diff logic.

Test: ./test.py
Bug: 259148872
Change-Id: I93aaa3028bf6a30312f0b0e5b1ef5f6ae1041f21
2022-12-30 16:33:48 +08:00
Shuo Wang Hsu
00c5825a4a Merge "Support building crate variants." am: eb91e5586a am: 6e08106f21 am: 68a953961f
Original change: https://android-review.googlesource.com/c/platform/development/+/2368768

Change-Id: Idd1acdb859295a8ec63f21314a3276fd1468f627
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-29 21:19:48 +00:00
Shuo Wang Hsu
68a953961f Merge "Support building crate variants." am: eb91e5586a am: 6e08106f21
Original change: https://android-review.googlesource.com/c/platform/development/+/2368768

Change-Id: I0020c995b59befe9096932b33a1dd45937dddfcc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-29 20:31:55 +00:00
Shuo Wang Hsu
6e08106f21 Merge "Support building crate variants." am: eb91e5586a
Original change: https://android-review.googlesource.com/c/platform/development/+/2368768

Change-Id: I6d566bd8fd9392bfa68bc5e852332f80df023bea
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-29 20:03:07 +00:00
Shuo Wang Hsu
eb91e5586a Merge "Support building crate variants." 2022-12-29 19:29:01 +00:00
Shuo Wang Hsu
be3f0d9d11 Support building crate variants.
The cargo2android.json config file now supports the key "variants" with
a list of entries containing keys and build name suffix. Each entry
will produce a different library (or binary). Keys supplied for each
variant will overwrite any existing ones specified in the config file.

See an example of the protobuf crate on aosp/2368788.

Test: None
Change-Id: Iaca67c7f22718c27b3cb118d9794f1ff01d31c84
2022-12-28 15:39:42 -08:00
Kean Mariotti
eadf44ec29 Merge changes Iaf248668,Ic1701cd0,I56274973
* changes:
  Mediator cleanup
  Refactor dependency inversion interfaces
  Remove legacy data and properties view from layer trace root
2022-12-28 18:59:19 +00:00
TreeHugger Robot
e1a84ab2ec Merge "Draw rounded corners when layers have them" 2022-12-28 16:22:10 +00:00
Nataniel Borges
d1dc6d0cac Draw rounded corners when layers have them
Plus some code clean up

Result: https://screenshot.googleplex.com/BNYzBrQ9SMeiPxU

Test: npm start and open a trace with rounded corners (e.g. quick
switch)

Change-Id: I93c36eaccd440c3420e3bb7fe25d262979dbde5e
2022-12-28 15:05:33 +00:00
Hsin-Yi Chen
290cc7b000 Merge "Allow extending qualifiers of function parameters and return values" am: 82b8191b50 am: 2a813cdeb7 am: 0c20c58b66
Original change: https://android-review.googlesource.com/c/platform/development/+/2337410

Change-Id: I565247f1eeee7715aaf19f29dbadd79451264ba2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-28 12:12:08 +00:00
Hsin-Yi Chen
0c20c58b66 Merge "Allow extending qualifiers of function parameters and return values" am: 82b8191b50 am: 2a813cdeb7
Original change: https://android-review.googlesource.com/c/platform/development/+/2337410

Change-Id: Idd55d66dab2177233cbb4f50bf194e75242553ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-28 11:25:53 +00:00
Kean Mariotti
fded3d4cb2 Mediator cleanup
Test: npm run build:all && npm run test:all
Change-Id: Iaf2486682146310a0c888e9c67ad34751068f3be
2022-12-28 11:22:22 +00:00
Kean Mariotti
b6a9c8b94d Refactor dependency inversion interfaces
Fix: b/262840884
Test: npm run build:all && npm run test:all
Change-Id: Ic1701cd069e2cff29590b3b2d35b01dfcb74004b
2022-12-28 11:14:43 +00:00
Hsin-Yi Chen
2a813cdeb7 Merge "Allow extending qualifiers of function parameters and return values" am: 82b8191b50
Original change: https://android-review.googlesource.com/c/platform/development/+/2337410

Change-Id: I4884d914a5f60d89ab5c99e0b6e0ea337c896584
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-28 10:52:26 +00:00
Hsin-Yi Chen
82b8191b50 Merge "Allow extending qualifiers of function parameters and return values" 2022-12-28 09:31:24 +00:00