Commit Graph

3741 Commits

Author SHA1 Message Date
Pablo Gamito
b38a01fb29 Merge "Add option to press enter to search for timestamp" 2021-08-25 09:09:53 +00:00
Pablo Gamito
fb863ba404 Add option to press enter to search for timestamp
Change-Id: Idaae216df04c34cdc73e796379c5358736661010
2021-08-24 20:01:27 +02:00
TreeHugger Robot
a71ccc7104 Merge "Fix broken trace views for accessibility/IM." 2021-08-24 15:53:46 +00:00
Priyanka
c132b4643c Fix broken trace views for accessibility/IM.
Due to new UI, Accessibility Trace and IM Trace views were broken. This
CL passes values in for presentTags and presentErrors to ensure the
views display as expected.

Bug: b/197628035

Test: run a trace with all checkboxes ticked and ensure the views
display as expected.

Change-Id: Iad98ab88b0250447ead72c5bcf467f8873d25182
2021-08-24 14:50:02 +00:00
Priyanka
41cf977e9b Fix spec tests
Fixed all failing spec tests so that object transformations, diff tree
generation and proto file decoding can all be tested via yarn.

Bug: b/196210353

Test: `yarn run test`
Change-Id: Iefd41dd93d6a591756d1a60ae6e42c3b08f9d5e0
2021-08-23 16:45:27 +00:00
Priyanka
aadd3418fd Add tags/errors to trace views.
At the start or end timestamp of a transition, or at an error timestamp, colour coded tags show up
next to the relevant layer/task in the WM and SF trace hierarchy views.
Tick the transition checkbox to only show entries that have tags/errors.
Compatible with flat checkbox.

Bug: b/196544612

Test: upload the zip onto the x20 (see bug) and test above.
Change-Id: Ied84adbedc38324629c8b50178b44041f8e8b66e
2021-08-23 10:58:29 +00:00
Priyanka
0e80ea1000 Add tags and errors to focused/targeted timelines.
Extend the tag timeline display from global to specific WM/SF trace
timelines. During focused or targeted navigation, the tags/errors should display for their associated trace
only. On global navigation, the minimum start and maximum end timestamp
for each transition is displayed. In the search bar, under transitions
and errors, note that the timestamps displayed as the global start and
end.

Bug: b/197066003

Test: upload SampleWinscope.zip from bug and test the different
navigation types.

Change-Id: Id273bf77425c504d943f1ee9716ce2f3ad0ec9c5
2021-08-20 14:45:04 +00:00
Priyanka
e93515ef89 Add functionality to search + navigate tags/errors.
Add a searchbar to bottom of Winscope that can be used to navigate through
all the tags/transitions/errors present in a trace (integrating existing timestamp search).
Choose the desired tab to set the type of search. Typing input into the relevant search will filter the elements.
Click on the start or end timestamp in the scrollable search table to navigate to that
timestamp in the timeline. Click on a transition in the search table to navigate to the start timestamp for that transition. Click on a transition in the timeline to toggle between start and end timestamps for that transition.

Bug: b/196197875

Test: upload the traces on the bug and test the above implementations on
the x20.

Change-Id: Ib3a0fff770cc65a38e50a8d99f130752b2f98eeb
2021-08-20 14:43:55 +00:00
TreeHugger Robot
6f3098ad9c Merge "Fix flat and visible checkboxes on trace views." 2021-08-20 10:35:09 +00:00
Treehugger Robot
21ee402904 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a am: 023d8bfa44 am: 461112ec85 am: d2d3c0d4d9
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: I517e83dd918c656d679d1064265726f8c3308ce1
2021-08-19 22:05:41 +00:00
Treehugger Robot
d2d3c0d4d9 Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15 am: 4976675e9a am: 023d8bfa44 am: 461112ec85
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: I5170fb8ea6a2a5d223aff85212e13098f7bbc0d6
2021-08-19 21:51:15 +00:00
Treehugger Robot
4976675e9a Merge "Add support for reuse configuration in OTA generator." am: 097e8c0a15
Original change: https://android-review.googlesource.com/c/platform/development/+/1802616

Change-Id: Idb3bc4cbff66d8bd9c410cf5225bb9c1f7dac04a
2021-08-19 21:01:12 +00:00
Treehugger Robot
097e8c0a15 Merge "Add support for reuse configuration in OTA generator." 2021-08-19 20:45:53 +00:00
Treehugger Robot
dedcabf27b Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc am: e3d4db13a7 am: cd0f8452be am: 74f0d027a6 am: 59ee286b44
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: Ifae3dc3d4c1b4ef0d4a9182dfda3247c567e23a4
2021-08-19 17:53:27 +00:00
Treehugger Robot
59ee286b44 Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc am: e3d4db13a7 am: cd0f8452be am: 74f0d027a6
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: I6c06e0da2ec2d2a0536dd3698171dcd10b343eed
2021-08-19 17:34:26 +00:00
Treehugger Robot
e3d4db13a7 Merge "Fix a bug that may cause the ota generation fail." am: 54f24641bc
Original change: https://android-review.googlesource.com/c/platform/development/+/1801907

Change-Id: I9f74bd1fd9422116d4fe6726b4d34585c5f84cdf
2021-08-19 16:51:53 +00:00
lishutong
1ec526c9a0 Add support for reuse configuration in OTA generator.
Use vuex to store the otaConfig, now the history configurations can be
reused in the job detail page. Also the targetBuilds, incrementalSources
are not stored in vuex as well. Once the targetBuilds are chosen, it
will not lose the states when switching the tab between singleOTA,
batchOTA and chainOTA.

Test: npm run test:unit
Change-Id: I563ac0c79fd0cedd5e71e8722b956545f6624551
2021-08-19 16:34:09 +00:00
lishutong
e8c8d88b8c Fix a bug that may cause the ota generation fail.
The extra space in args['extra'] may cause the ota generation fail.

Test: python test_ota_interface.py -v
Change-Id: Iac6d06a89c52ab7554e54c08e5e04496b3da730a
2021-08-19 15:32:38 +00:00
Priyanka
9236a95bd6 Fix flat and visible checkboxes on trace views.
Now ticking the flat checkbox displays all entries without indentation,
and only visible entries are shown upon ticking only visible.

Bug: b/196951608

Test: upload a WM or SF trace and tick flat - all entries should be
aligned to left of Hierarchy box.

Change-Id: Iedb755d94895afcdca334871e980064c79430206
2021-08-19 10:58:48 +00:00
Treehugger Robot
ce94ea7003 Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb am: 5b72622eba am: d66dd9da46 am: eafc8734a5 am: 40d314d0aa
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: I9dd89fc6cf8a585337306798e764da876b0e0968
2021-08-18 20:17:59 +00:00
Treehugger Robot
40d314d0aa Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb am: 5b72622eba am: d66dd9da46 am: eafc8734a5
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: If517dc76118669142b287a21dd02809eafcb064f
2021-08-18 19:55:12 +00:00
Treehugger Robot
5b72622eba Merge "Add test to the MapParser class in OTA_analyzer." am: 571c6e4ecb
Original change: https://android-review.googlesource.com/c/platform/development/+/1800267

Change-Id: I12f9c1334b7e1b042b745a383a5facd20eb71d96
2021-08-18 19:11:55 +00:00
lishutong
fce8266b7e Add test to the MapParser class in OTA_analyzer.
Add unit test to the MapParser class in map_parser.js. Please refer to
this CL for the original class definition:

https://android-review.googlesource.com/c/platform/development/+/1760909

Test: npm run test:unit
Change-Id: I2d640e9c5e27c0a012e32b4be09348034b67b235
2021-08-18 16:06:32 +00:00
TreeHugger Robot
168339f6cf Merge "Fix no files returned by proxy on second consecutive tracing" 2021-08-18 09:41:43 +00:00
Treehugger Robot
d432aa3b99 Merge "Add test to target_lib.py." am: f73c0f6138 am: 7a75be2c8b am: 85501ae6e5 am: 277ae073a6 am: 84b1f82d83
Original change: https://android-review.googlesource.com/c/platform/development/+/1795808

Change-Id: Ia173f1a215f4f28b6ea41dc08b826d12b3ef7241
2021-08-17 19:15:19 +00:00
Treehugger Robot
84b1f82d83 Merge "Add test to target_lib.py." am: f73c0f6138 am: 7a75be2c8b am: 85501ae6e5 am: 277ae073a6
Original change: https://android-review.googlesource.com/c/platform/development/+/1795808

Change-Id: I5e9d5c3b7ed0a3a36a75c37517894e51e7ba4ed9
2021-08-17 18:35:02 +00:00
Xin Li
4e9b8886c5 Merge "Merge sc-dev-plus-aosp-without-vendor@7634622" into stage-aosp-master 2021-08-17 18:14:19 +00:00
Treehugger Robot
85501ae6e5 Merge "Add test to target_lib.py." am: f73c0f6138 am: 7a75be2c8b
Original change: https://android-review.googlesource.com/c/platform/development/+/1795808

Change-Id: I1358d1b24ed898cca973d5338df9cf157e8074b0
2021-08-17 17:53:28 +00:00
lishutong
54071681c8 Add test to target_lib.py.
Add test to two classes: BuildInfo and TargetLib. BuildInfo is a
dataclass which can store and parse Android Build informations from an
OTA package. TargetLib is a database interface which can be used to
store and extract BuildInfo.

Please refer to this CL for more details of these two classes:
https://android-review.googlesource.com/c/platform/development/+/1735315

Test: python test_target_lib.py -v
Change-Id: I3b2143af7f3708207b6c53744d903d3dcee92d55
2021-08-17 15:31:28 +00:00
Nataniel Borges
796ea0a96a Fix no files returned by proxy on second consecutive tracing
Python map function returns an iterator that cannot be reused. Convert
it into a list instead to support multiple usages.

Also, add an error message to the ocnsole if no files are returned

Test: run proxy, start/stop trace 2+ times in a row
Change-Id: I09e4a4a28315b28f8d6eabdbfe60890cdfb8510c
2021-08-17 15:05:06 +00:00
TreeHugger Robot
5a15b987a1 Merge "Make sure all entries are shown in the proto section" 2021-08-16 09:34:17 +00:00
Xin Li
f631d20429 Merge sc-dev-plus-aosp-without-vendor@7634622
Merged-In: I815ef03c93bec8be2340dc340d840895f47ecafe
Change-Id: I2f6316055af5cb77c66ff2a741a2d37db3d1691a
2021-08-14 06:31:09 +00:00
TreeHugger Robot
01e5451f72 Merge "Store transition types in enum" 2021-08-13 08:45:02 +00:00
Kelvin Zhang
f341e3e605 Merge "Fix a bug where small manifest isn't read" am: 62582263a2 am: 6750cd8b02 am: d5764b5753 am: b6debb366b am: 7c66bb6542
Original change: https://android-review.googlesource.com/c/platform/development/+/1792911

Change-Id: I881d5d78e3044826bfdf80d740d88f5d8cd5b25b
2021-08-12 19:27:09 +00:00
Treehugger Robot
585a97d135 Merge "Add test to ota_interface.ProcessManagement." am: 4a5ee938da am: 85e6dea009 am: 3a894fb3c2 am: ebc318c424 am: 76559b2f42
Original change: https://android-review.googlesource.com/c/platform/development/+/1793173

Change-Id: I7c515fd29e7b908b6e6235169193353d31ce42ed
2021-08-12 19:17:02 +00:00
Kelvin Zhang
7c66bb6542 Merge "Fix a bug where small manifest isn't read" am: 62582263a2 am: 6750cd8b02 am: d5764b5753 am: b6debb366b
Original change: https://android-review.googlesource.com/c/platform/development/+/1792911

Change-Id: I4c5299137aa29476784277a6f437fb420f3a63bc
2021-08-12 19:02:08 +00:00
Treehugger Robot
76559b2f42 Merge "Add test to ota_interface.ProcessManagement." am: 4a5ee938da am: 85e6dea009 am: 3a894fb3c2 am: ebc318c424
Original change: https://android-review.googlesource.com/c/platform/development/+/1793173

Change-Id: Ie6c7923a1e76c3c60119364b4e07c5a903ec5548
2021-08-12 18:55:39 +00:00
Kelvin Zhang
d5764b5753 Merge "Fix a bug where small manifest isn't read" am: 62582263a2 am: 6750cd8b02
Original change: https://android-review.googlesource.com/c/platform/development/+/1792911

Change-Id: If724cf9d9bad6143f0534b5cf5512b5b9f5a23be
2021-08-12 18:32:03 +00:00
Pablo Gamito
5e19d0217f Make sure all entries are shown in the proto section
Problem was that we were relying on getProperties to iterate through all
the properties to format them, but getProperties would filter out any
falsy value so all properties that had fasly values were pre-filtered out regardless of if show defaults was toggled or not.

We also make sure that null and undefined fields are shown when show
defaults is enabled

Test: Check proto section of entries in winscope to see all missing entries
Fixes: 187463843
Change-Id: Iaf6ef1b855edafb0dfbd324e73bbd5c3ce1b2f59
2021-08-12 17:42:14 +00:00
Kelvin Zhang
c05d0bd37c Fix a bug where small manifest isn't read
If a single read request contains the entire manifest, we will return
right after prefixLength is computed, and the UI just hangs there.

Test: load a small OTA pkg
Change-Id: Idb93fdba103f9c6e7b14974b45d1aecdb2ae9168
2021-08-12 10:32:07 -07:00
Treehugger Robot
3a894fb3c2 Merge "Add test to ota_interface.ProcessManagement." am: 4a5ee938da am: 85e6dea009
Original change: https://android-review.googlesource.com/c/platform/development/+/1793173

Change-Id: Iae4640fecea1f175dcc730c701c9cc26ded68f46
2021-08-12 17:15:09 +00:00
Treehugger Robot
05a3ef9580 Merge "Add test to ota_interface.JobInfo." am: ba7d668e84 am: 42f7ba7bc8 am: 307faa3b5f am: 4535d298e4 am: e6a368c75f
Original change: https://android-review.googlesource.com/c/platform/development/+/1793172

Change-Id: I018f0448eb11c53c16029b36be32be33741862cb
2021-08-12 15:34:43 +00:00
Treehugger Robot
e6a368c75f Merge "Add test to ota_interface.JobInfo." am: ba7d668e84 am: 42f7ba7bc8 am: 307faa3b5f am: 4535d298e4
Original change: https://android-review.googlesource.com/c/platform/development/+/1793172

Change-Id: I06465fd059ee4d88cea3a01b19edbb575abd3176
2021-08-12 15:21:04 +00:00
Treehugger Robot
307faa3b5f Merge "Add test to ota_interface.JobInfo." am: ba7d668e84 am: 42f7ba7bc8
Original change: https://android-review.googlesource.com/c/platform/development/+/1793172

Change-Id: Ia252d6871d21fcf010fe10db477ceb8f99d6be06
2021-08-12 14:24:21 +00:00
Priyanka
0bb308f2a8 Store transition types in enum
Store transition types in enum so easier to type check in Typescript if necessary later on.

Bug: b/196203538

Test: check that the tag trace attached to the bug still uploads
correctly

Change-Id: I2994f58ceb1d49bd82af54fb075369bd70dc1394
2021-08-12 08:48:52 +00:00
Treehugger Robot
8559a54d0d Merge changes I8449eea7,I24666871 am: 5d8768f2ca am: 303ca2baa8 am: 4bb39c56da am: 28af1c725d am: 4537095627
Original change: https://android-review.googlesource.com/c/platform/development/+/1793171

Change-Id: I21113b288dbd5c3ab6dbe00aa309a105b9633afc
2021-08-12 02:05:26 +00:00
Treehugger Robot
4537095627 Merge changes I8449eea7,I24666871 am: 5d8768f2ca am: 303ca2baa8 am: 4bb39c56da am: 28af1c725d
Original change: https://android-review.googlesource.com/c/platform/development/+/1793171

Change-Id: I81e3fd1198482b50508403673a7006121a622907
2021-08-12 01:54:12 +00:00
Treehugger Robot
4bb39c56da Merge changes I8449eea7,I24666871 am: 5d8768f2ca am: 303ca2baa8
Original change: https://android-review.googlesource.com/c/platform/development/+/1793171

Change-Id: I815ef03c93bec8be2340dc340d840895f47ecafe
2021-08-12 01:16:26 +00:00
lishutong
70026190c6 Add test to ota_interface.ProcessManagement.
The ProcessManagement helps initiate OTA generation processes and
monitor those processes. Add some test and comments to this class.
Please refer to:
https://android-review.googlesource.com/c/platform/development/+/1736940
for more details.

Test: python test_ota_interface.py -v
Change-Id: Ib22fca4c5a670f8b55db8a4175fef16d92eaceaf
2021-08-12 00:44:42 +00:00
lishutong
1e82f06150 Add test to ota_interface.JobInfo.
Add testcases for ota_interface.JobInfo, which is used as object to
store task information and serve/read data to/from database.
Refer to:
https://android-review.googlesource.com/c/platform/development/+/1736940
for more details.

Test: python test_ota_interface.py -v
Change-Id: I74dcb16390078bd9258da490e21cb2b73dd78e81
2021-08-11 20:45:23 +00:00