Commit Graph

3938 Commits

Author SHA1 Message Date
Priyanka Patel
864e448436 Fixing e2e tests.
Broken e2e test due to changing the way files are uploaded. This should
fix it.

Test: npm run test:e2e
Bug: b/241571689
Change-Id: I74c8d489ecf4c0627d844505037f886d1f183b72
2022-08-12 12:16:40 +00:00
Priyanka Patel
42b10df22d Add functionality to upload traces component.
Upload multiple files via clicking to browse or drag and drop.

Test: spin up winscope and see if the files upload.

Bug: b/241571689
Change-Id: I67b801008ddcfa5be3ae724eb4db6f9b723eebd6
2022-08-11 10:00:34 +00:00
Kean Mariotti
5415b8bf69 add support for traces real timestamp
Parsers support real timestamps (along the legacy elapsed timestamps) for the following trace types:
- Accessibility
- InputMethodClients
- InputMethodManagerService
- InputMethodService
- ProtoLog
- SurfaceFlinger
- Transactions
- WindowManager

Bug: 235196806
Test: cd development/tools/winscope-ng && npm run build:unit && npm run test:unit
Change-Id: Ib26fa7c4b8b4cc0ed3128c6805c57fcb1ce7ae85
2022-08-09 14:03:44 +00:00
Kean Mariotti
31392005c5 refactor test code
- segregate unit and e2e test utils
- add UnitTestUtils::getParser()

Test: cd development/tools/winscope-ng && npm run build:all && npm run test:all
Change-Id: I48212fe9bb1ef01b09301cd8a721f10ea18c9b77
2022-08-09 14:03:44 +00:00
Kean Mariotti
e081cfee6b refactor Parser's interface
- add class TimestampType (ELAPSED or REAL)
- add class Timestamp (timestamp value + type)
- use bigint (instead of number) to represent timestamp values

Test: cd development/tools/winscope-ng && npm run build:all && npm run test:all
Change-Id: I1db9f2f9d48ca54bd79d3ffb989f6dde9ac11cd7
2022-08-09 14:03:44 +00:00
Kean Mariotti
75862f22be parser for new screen recording metadata
Bug: 235196806
Test: cd development/tools/winscope-ng && npm run build:unit && npm run test:unit
Change-Id: Ie964b30f2f88a35ce428fab9fe1da192599da6e5
2022-08-09 14:03:44 +00:00
Pablo Gamito
99a2ff31bc Merge "Compile FaaS common config package for Winscope" 2022-08-08 09:08:46 +00:00
Hui Ling Shi
cba772e665 Add fields to WM&SF Properties panel for Ime IMMS
Add windowContainer > identifier > title property for imeControlTarget,
imeInputTarget and imeLayeringTarget, which are extracted from WM trace,
into the WM&SF Properties panel for ImeTrace InputMethodManagerService.

Also, change the titles of 'IME...Target' properties into clickable
text (originally, the clickable text was in the right column).

Screenshot: https://screenshot.googleplex.com/BWZFJgca2YmXk6X.png
Bug: 236226833
Test: manual on local build of Winscope
Change-Id: I8da832fa36c722688c73a16d5381d7ef49fbfb0e
2022-08-04 12:56:46 +00:00
Hui Ling Shi
f6593124e5 Add specific values for testing IME processing
Previous CL ag/19516273 added tests for the new logic in
ime_processing.js, which extracts properties from WM & SF trace
entries and combines them into IME trace entries. However, the
checks used in the tests were a bit vague as they just expected some
fields to be defined (non-null). This CL improves on this by specifying
some values to verify the extracted WM / SF fields' correctness.

Bug: 237744706
Test: yarn run test
Change-Id: I1f237135520f0ef5dc85b257f6602196aa534197
2022-08-04 12:29:03 +00:00
Pablo Gamito
c2f4bc4b8c Compile FaaS common config package for Winscope
Test: yarn run v1.22.18
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Bug: 241061291
Change-Id: I109aa17a607ee6cd5978f4af4c51dc49a67f5d98
2022-08-04 11:06:38 +00:00
Hui Ling Shi
df557d595f Add tests for combining IME with WM / SF entries
Add tests for the new logic in ime_processing.js, which extracts
properties from WindowManager and SurfaceFlinger trace entries and
combines them into IME trace entries.

Some simple IME, WM and SF traces are added into
spec/traces/ime_processing_traces, and the results of combining them are
asserted for in spec/ImeProcessingSpec.js.

Bug: 237744706
Test: yarn run test
Change-Id: If2a053c4885cc4c522c93cf747b94cb69aceb1c6
2022-08-03 12:06:16 +00:00
Hui Ling Shi
8a507b7a54 Fix SFLayer TypeErrors in Winscope
Fix the errors that pop up when clicking `SurfaceFlingerLayer` in
SurfaceFlingerTrace panel's Hierarchy panel, by taking care of cases
where the property is null.

Bug: 240405932
Test: manual on local build of Winscope
Change-Id: Ic9e8f6e75dcfde8af97aeb5254d1e2d8f7b3d669
2022-08-01 08:46:45 +00:00
Hui Ling Shi
595c67d790 [11] Change matching WM/SF entry to IME entry algo
Due to there being some slightly different timestamps between WM/SF
trace and IME trace, we want to allow some "fault tolerance" -- even
if a WM/SF entry comes after IME entry in time, it may still be the
corresponding entry if it's within a manually-defined "fault tolerance"
time.

For now, fault tolerance is defined to be 200ms. So if a WM/SF entry is
within IME entry +- 200ms, it may be considered a matching /
corresponding entry. Within this range, we will always try to pick a
WM/SF entry that comes before the IME entry. If there is no such WM/SF
entry, then we will pick one that comes after.

Bug: 236226833
Test: manual on local build of Winscope
Change-Id: I0782ec520284517bf964eeffd552e6175758c9f1
2022-08-01 08:46:43 +00:00
Hui Ling Shi
948c897065 [10] Refine WM & SF Properties IME subpanel
Make the following headers clickable; upon clicking, will show proto
details in the 'Properties' sub-panel on the right:
- WMState
- Ime Container
- Input Method Surface
- IME Insets Source Provider

Add the following properties:
- Focused window's color / rgba information -- focused window title
  extracted from WM trace, the corresponding surface's rgba extracted
  from SF trace
- InputMethod Window's visibility
- InputMethod Surface's visibility
- InputMethod Surface's rect & screenBounds

Remove the following properties:
- ImeContainer's rect & screenBounds

Rename the following properties:
- Frame (under 'Focus' heading) --> Input Control Target Frame

Screenshots: in buganizer ticket
Bug: 236226833
Test: manual on local build of winscope

Change-Id: I2a2747b57639f40c8f6bf71d5cb49268e4ee5044
2022-08-01 08:45:24 +00:00
Hui Ling Shi
cb0d23d9dd [9] Fix null targets in IME's 'WM & SF Properties'
Fix incorrect names of properties being extracted from WM Trace:
- 'Input Method Control Target' has been replaced with 'IME Control
Target', 'Input Method Input Target' with 'IME Input Target', and 'Input
Method Target' with 'IME Layering Target'.

Bug: 239145867
Test: manual on local build of winscope
Change-Id: If067cf73de32d4374b33d1f07f179b63c9fb0c27
2022-08-01 08:34:36 +00:00
Priyanka Patel
c40abfeb90 Add component tests and an upload card.
Adding component spec tests for all new components involved in trace
collection. This includes a new card for this CL, UploadTracesComponent,
to make testing more methodical.

Test: npm run test:component
Bug: b/238981126

Change-Id: I46d1b24fed84ce35432dad36fd5ac24d35cd0542
2022-07-29 11:36:25 +00:00
Priyanka Patel
64b08efa13 Adding ability to run and end traces via proxy.
Finishing proxy migration by creating functionality to run and end
traces and dumps after selecting trace config.

Test: Connect a device via remote device proxy and follow the proxy
workflow for a trace or dump. Should see a placeholder message saying data loaded (trace
views not yet created).

Bug: b/238113543
Change-Id: Ic7e0948341511f6ec0bf1021d2ffbb7b198c9410
2022-07-29 10:52:13 +00:00
Priyanka Patel
b6ee5d4794 Refactor code to use common connection.
None of the components should directly interact with the proxy because
non-android development workflow (using web adb) will also be possible
in the future. Instead the ui components interact with a common
connection interface which handles the proxy or web adb respectively.

Test: check that proxy workflow still works as expected.

Bug: b/234103636
Change-Id: I0e7bbaf4b5f342ca99dd67f890c135dbf3ef61ec
2022-07-29 10:50:31 +00:00
Priyanka Patel
88ea98f6ba Migration of proxy.
Migrating the proxy to the new trace collection UI. Should be able to
enter the proxy token, select your connected device and then make
changes to trace configrurations.

Test: try running the proxy and test that functionality is same as old
winscope.

Bug: b/238113543
Change-Id: I195f65df5d09e22db54cb9f5a7ba0396948f43d3
2022-07-29 10:50:12 +00:00
Priyanka Patel
b91e72bf40 trace collection UI
Created new UI components for trace collection. Since the proxy is not
yet migrated, click through the buttons to automatically cycle through
the components.

Bug: b/238981126

Test: npm run start
Click Web ADB tab to see basic component. Click ADB proxy tab to see
proxy component. Click Retry to get to authorisation options. Click
Connect to get to trace configuration component.

Change-Id: I1e7a9895ece06856c095d8c85c28d22bbfa94b31
2022-07-29 10:49:44 +00:00
Hui Ling Shi
febda81348 Merge "Downgrade vue-material version" 2022-07-27 06:04:05 +00:00
Kean Mariotti
6751fa5bd3 fix flickerlib facade
Remove code related to error/tag, which was removed from the Kotlin flickerlib as well

Test: npm run build:all && npm run test:all
Change-Id: Iaba34b458dd08aaae5ad18968a11ca8ab2d1e33a
2022-07-26 15:22:55 +00:00
Hui Ling Shi
8130d2c9e8 Downgrade vue-material version
Fix vue-material errors that show up when using MdSelect (which
we use for <Overlay />). These errors are a known bug in the
vue-material codebase
(https://github.com/vuematerial/vue-material/issues/2285) but no
patch is out for it yet. Hence, downgrade vue-material to the
latest version that does not have these errors.

Test: manual with local build of Winscope
Bug: 238262637
Change-Id: Icffead3cbf1fa1f2a6e4ec83564078f396e660cf
2022-07-25 07:49:36 +00:00
Treehugger Robot
a2b818c331 Merge "Exclude list may have comment" am: 71caa549f3 am: eeba035377 am: daa7ed2846 am: b06917a133 am: 8ecfab5be1
Original change: https://android-review.googlesource.com/c/platform/development/+/2158136

Change-Id: Idd73fbd17ac826dfaec421857a303730b9c45628
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 08:30:22 +00:00
Treehugger Robot
eeba035377 Merge "Exclude list may have comment" am: 71caa549f3
Original change: https://android-review.googlesource.com/c/platform/development/+/2158136

Change-Id: Ifc39a4719c6c1ea0c5589ec46ae7babf1479f98f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-19 07:01:48 +00:00
Treehugger Robot
71caa549f3 Merge "Exclude list may have comment" 2022-07-19 06:44:43 +00:00
Justin Yun
b2143bf4dc Exclude list may have comment
With this change the exclude list file may have comments that start
with '#'

Test: Run collect_ninja_inputs.py with excluded file list that has
      '#' comments
Change-Id: Ic2e3da8a34144426e00ebd45ee09ff9cb3b339bd
2022-07-19 14:31:44 +09:00
Treehugger Robot
73d2a0cd6c Merge "repo_pull: Attempt to fetch via ssh first" am: 4a2aacdeed am: cf1bb77660 am: 0fb346cb84 am: 38d0ea7201 am: bdb3a8c0c4
Original change: https://android-review.googlesource.com/c/platform/development/+/2128416

Change-Id: Ica21b170cc665429373cc91ee682fc6a341bb62d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-18 11:39:46 +00:00
Treehugger Robot
cf1bb77660 Merge "repo_pull: Attempt to fetch via ssh first" am: 4a2aacdeed
Original change: https://android-review.googlesource.com/c/platform/development/+/2128416

Change-Id: I258f742d4f9cbc209488e343378c74fbb7555fd9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-18 10:07:40 +00:00
Treehugger Robot
4a2aacdeed Merge "repo_pull: Attempt to fetch via ssh first" 2022-07-18 09:48:02 +00:00
Treehugger Robot
cd48267edd Merge "[LSC] Add LOCAL_LICENSE_KINDS to development" am: 4b914d2e0d am: 0709cb8a7b am: 4d0d1a8058 am: 0cdcbb640f am: 54be2a1032
Original change: https://android-review.googlesource.com/c/platform/development/+/2154415

Change-Id: Ia47f2eb32f048852b39f59f557e3f88010c3ad31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-15 02:32:43 +00:00
Treehugger Robot
0709cb8a7b Merge "[LSC] Add LOCAL_LICENSE_KINDS to development" am: 4b914d2e0d
Original change: https://android-review.googlesource.com/c/platform/development/+/2154415

Change-Id: I833e6c5ad0cce25e0a4f0f9fbe5aae2524ec5f69
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-15 01:01:44 +00:00
Bob Badour
49a787d725 [LSC] Add LOCAL_LICENSE_KINDS to development
Added SPDX-license-identifier-Apache-2.0 to:
  apps/OBJViewer/Android.bp
  samples/HeavyWeight/Android.bp
  samples/MySampleRss/Android.bp
  tools/ninja_dependency_analysis/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all
Change-Id: Ic4627f424a3ecfbe65145268242a37f373c05a01
2022-07-14 11:08:07 -07:00
Kean Mariotti
a50b7f37cd Merge changes I8c59c8a0,Id6a20576
* changes:
  add eslint to keep code consistent
  add Presenter + UI data example
2022-07-14 17:38:11 +00:00
Hui Ling Shi
8310ad724d Merge "[8] Add screenshot button to capture each panel" 2022-07-14 13:12:43 +00:00
Kean Mariotti
a601688303 add eslint to keep code consistent
Bug: 236369779
Test: npm run eslint
Change-Id: I8c59c8a0ff6b63920ad0298c9625bee9709f2bb6
2022-07-14 08:29:44 +00:00
Kean Mariotti
3c32ba53f0 add Presenter + UI data example
Bug: 236369779
Test: cd development/tools/winscope-ng && npm run build:all && npm run test:all
Change-Id: Id6a20576cdb87c54e503e46b2f40562900295bc5
2022-07-14 08:27:24 +00:00
Kean Mariotti
2e464d915b fix global styles
Bug: 236369779
Test: cd development/tools/winscope-ng && npm run build:all && npm run test:all
Change-Id: I551889207862cfd698ccf634275c5c84d1b976d1
2022-07-12 18:13:04 +00:00
Luca Stefani
396466344b repo_pull: Attempt to fetch via ssh first
This is usually preferred if supported by the server

Change-Id: Ie15df0231a679d55ba1adfd7e7d86f4999828e27
2022-07-12 13:02:59 +00:00
Kean Mariotti
ebcaef29b7 Merge "Parsers receive Blob instead of Uint8Array" 2022-07-11 06:48:01 +00:00
Kean Mariotti
f20532c080 Parsers receive Blob instead of Uint8Array
Now Parsers rely on the Blob interface/abstraction, instead of the concrete Uint8Array.
Thus, in the future we'll be able to implement incremental trace parsing (e.g. stream parsing)
without breaking client code (e.g. ABT).

Minor: specify timeout in end-to-end tests

Test: npm run test:all
Change-Id: I9098ee3beba231f4bb4b59b24cee60e5a1e1122e
2022-07-08 13:41:05 +00:00
Hui Ling Shi
85da20b4d8 Merge "[7] Refine UI for IME panels, PropertiesTableView" 2022-07-08 09:20:08 +00:00
Treehugger Robot
199b636d65 Merge "Ninja dependency analysis tool" am: 58776972a8 am: af31f40f98 am: ec6ac730d5 am: 4c03e446d1 am: a01a5a42c1
Original change: https://android-review.googlesource.com/c/platform/development/+/2146699

Change-Id: I3a40a88b3186bac6a2af8653f146c1c3a59a42f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-08 07:49:59 +00:00
Treehugger Robot
af31f40f98 Merge "Ninja dependency analysis tool" am: 58776972a8
Original change: https://android-review.googlesource.com/c/platform/development/+/2146699

Change-Id: Iadd71e7ed10730884ee410729bc07c2b3c6359dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-08 06:21:40 +00:00
Jeongik Cha
1408cdc5e6 Ninja dependency analysis tool
The tool collects every input file for target except exempted_files.
And also, it counts input files per each project.

Bug: 238156000
Test: collect_ninja_inputs \
  -n prebuilts/build-tools/linux-x86/bin/ninja \
  -f out/combined-aosp_cf_x86_64_phone.ninja \
  -t vendorimage \
  -e exempted_files \
  -r .repo/project.list

Change-Id: I19b8b3462a1f1766babe4d437fe71bd7eb4bc7d2
2022-07-08 01:28:37 +00:00
Kean Mariotti
bc9ec13037 add Parser::getTraceEntries() for protologs
Test: npm run test:unit
Bug: 238091229
Change-Id: Iba828868625b320c9fc03ca9d95f44dc76315e2e
2022-07-07 05:56:10 +00:00
Kean Mariotti
4d70c4b4a4 More trace parsers
- SurfaceFlinger dump
- WindowManager dump
- screen recording
- Minor renaming to keep code semantic consistent also with ParserScreenRecording

Fixes: 238097667
Fixes: 238097628
Fixes: 238078364
Test: npm run build:unit && npm run test:unit
Change-Id: I01aa22c1bb030da21f6fb44eb1b159a4431191ce
2022-07-07 05:55:11 +00:00
Hui Ling Shi
ea043e692e [8] Add screenshot button to capture each panel
Screenshot button is added as a camera icon at the top right corner
of each panel (e.g. WindowManagerTrace, SurfaceFlingerDump).
Upon clicking this button, an image is downloaded to the user's
computer (Downloads folder), showing the whole panel - Hierarchy,
Properties etc.

Added dependency: html2canvas library

Screenshot: https://screenshot.googleplex.com/5rRzqKcEVsJRW2K.png

Bug: 236226833
Test: manual on local build of Winscope
Change-Id: Idd476017a780288c0e5ae09ce62334333fb9a652
2022-07-07 02:48:57 +00:00
Kean Mariotti
f339fe9f42 add e2e test infrastracture (protractor-based)
Test: npm run test:e2e
Change-Id: I5b9c227e4538bb64410b3bf2aa5543c91a23a0f2
2022-07-05 17:42:42 +00:00
Kean Mariotti
7f1e9e3c45 enable Angular production mode
Test: npm run build:prod
Change-Id: Iadfe6f81b0cfb611aa6b9266a08424927d82c5d1
2022-07-05 17:09:00 +00:00