Commit Graph

3807 Commits

Author SHA1 Message Date
TreeHugger Robot
56ff8aae2e Merge "Bounds representation improvements." 2021-09-24 11:26:06 +00:00
Rob Seymour
8e464ef166 Merge "Extend gerrit query to handle all changes in a topic." am: 8c58225807 am: 7264da3b42 am: 3dab1f72f7 am: 0f06749fab am: aadefda2a8
Original change: https://android-review.googlesource.com/c/platform/development/+/1828152

Change-Id: I8429be19cc4d593e5ed4e32377962c4c5614c6b2
2021-09-23 22:30:09 +00:00
Rob Seymour
aadefda2a8 Merge "Extend gerrit query to handle all changes in a topic." am: 8c58225807 am: 7264da3b42 am: 3dab1f72f7 am: 0f06749fab
Original change: https://android-review.googlesource.com/c/platform/development/+/1828152

Change-Id: Ibb1b22829cbbd62ed4f4a10bc38335aa0b61cb67
2021-09-23 22:18:41 +00:00
Rob Seymour
7264da3b42 Merge "Extend gerrit query to handle all changes in a topic." am: 8c58225807
Original change: https://android-review.googlesource.com/c/platform/development/+/1828152

Change-Id: I75c72015208ec6a5c003bf64a78ad29e103295a7
2021-09-23 21:33:06 +00:00
Rob Seymour
8c58225807 Merge "Extend gerrit query to handle all changes in a topic." 2021-09-23 21:18:04 +00:00
Rob Seymour
7f265b92fa Extend gerrit query to handle all changes in a topic.
Handle _more_changes property to download all changes in a query
Add multiple print formats (JSON, oneline) to gerrit.py  CLI

Bug: 200079625
Test: gerrit.py
Test: gerrit.py --verbose
Test: gerrit.py --start 10 --limits 10
Test: gerrity.py --start 50000 // Validate bad start index
Test: repo_review.py  // Validate Change Lists: returned
Test: repo_patch.py   // Validate patch created for all changes
Test: repo_pull.py bash // Validate commands exists for all changes
Change-Id: I532eb2f709aff29cf9c8ff7fc428d53b5c607101
2021-09-23 19:26:13 +00:00
Shashwat
4f12a28b0d Add transaction history for each transaction
Value of transaction history was never initialised in Transaction class
in Transaction.ts

Bug: 170224039

Test: See no errors generated regarding cannot read property 'generateHistoryTreesOf' of undefined".

Change-Id: Ifaae5808b56607b06251635d4fae0ee5a3484fd0
2021-09-23 14:52:21 +00:00
Priyanka
7cf0e4fe2b Bounds representation improvements.
Highlighted rects change background color to a red tint to make them
easier to see. The new displays property on an entry is now shown as a
blue-dashed rect on the SF trace - should still be able to click on
other rects to highlight them. Old SF traces (without display property)
should not be affected. Boundless displays now constrained to 1.3 times
display size.

Bug: b/198306246
Test: Upload trace to x20 (see bug).
Change-Id: Id80e539cd5f302754146d0bb1708784e3a57067c
2021-09-23 12:32:40 +00:00
Shashwat
7e0fbcbc13 Add analytics for timeline navigation
Test: Please see Google analytics and see event updates as you change
timeline navigation on winscope.
Bug: 200518515

Change-Id: I42152025d8cc2ef0b596d65fce177732eb6f9a98
2021-09-22 10:18:15 +00:00
Priyanka
9d3f674027 Edit SF and WM config from winscope.
Can now set the buffer sizes for these two traces, as well as set
tracing level and type for WM. Tested for multiple combinations of
config settings, as well as if settings are left as
placeholders/selected as the name of the config.

Bug: b/200159899

Test: Run a SF/WM trace with arbitrary config settings and check that all loads as normal.

Change-Id: I50ccc271bd2f90dba1d22c3e8c568490c4bf831f
2021-09-21 12:46:10 +00:00
TreeHugger Robot
a03f6e3fa5 Merge "Add Google analytics with events on winscope" 2021-09-21 12:27:50 +00:00
Shashwat
b76946939c Add Google analytics with events on winscope
- Events occuring
- Buttons clicked
- Files dragged/dropped vs uploaded

Test: Please see winscope dashboard on google analytics for events
Bug: 200518515
Change-Id: I338e5dd4351cfb416793105e8916543a8bdb5032
2021-09-21 11:08:17 +00:00
Nataniel Borges
ed101c9e9f Merge "Add visibility chip to activities" 2021-09-20 21:17:57 +00:00
Nataniel Borges
097c45728d Add visibility chip to activities
For a window to be visible, both the window and activity must be
visible. Show the visible chip on the activity to aid debugging

Test: yarn run dev and open a wm trace
Bug: 183993924
Change-Id: I97e9fbb916ffe95026effc3dfc3c97870949d697
2021-09-20 19:18:53 +02:00
Priyanka
6b6b76f54e Fixing an issue with transition overlap.
Transitions that are not overlapping no longer stay in the same row.
This should fix the problem.

Bug: b/200516237

Test: run a trace with pip enter, then rotation. Tags should display in
the same row on timeline.

Change-Id: I39b50f7636ec7c02de5e15e117542dface0154fc
2021-09-20 10:27:10 +00:00
TreeHugger Robot
0fa8228060 Merge "Reduce contrast on search bar colours." 2021-09-16 15:43:02 +00:00
Priyanka
d0bc553346 Reduce contrast on search bar colours.
Red/green contrast for hovering over errors in search bar may present an
issue for colour blind users. Reduce contrast to improve UX.

Bug: b/200150386

Test: upload a trace with errors and see the display. Example trace on
bug.

Change-Id: I9648fd0bce904c2c7bd13d0600d8dc58280fe7ab
2021-09-16 14:34:02 +00:00
Priyanka
e632742540 Added display support for PIP_CLOSE.
Add PIP_CLOSE to transitions supported by display.

Bug: b/199882679

Test: Upon merge of PipCloseProcessor, test display.

Change-Id: I2856a6b74b0ffe680f6bb978322ef3ceb98d267f
2021-09-16 14:32:51 +00:00
Priyanka
d911b839f8 Generate tags/errors for uploaded SF/ WM traces.
Tags can be generated after uploading SF/WM pair. If a Tag File is also
uploaded, clicking `Generate Tags` in the toolbar will regenerate the
tags, but not destroy the tag file, which can be redownloaded via
`Download All`. Otherwise, clicking `Generate Tags` will create tags
(which cannot be downloaded), and automatically display them where
relevant.

Bug: b/198590445
Test: upload a SF and WM trace without tags (example attached to bug),
click the button in the toolbar to Generate Tags and see that the tag
trace is generated and displays correctly. It should not download as a
trace if you click Download All.

Change-Id: I2c72de91691584add707065ac38ba83c49cfe705
2021-09-15 10:32:40 +00:00
TreeHugger Robot
e40228b7f1 Merge "Minor display changes for transitions and errors." 2021-09-15 09:28:40 +00:00
Priyanka
36f80b0bb1 Minor display changes for transitions and errors.
Split the transitions and errors search into separate tabs in the search
bar. Shortened the error tooltip on trace views.

Bug: b/199891856

Test: upload any trace with errors and transitions (see bug for
example).

Change-Id: I9bde012761bcd83933ffb269442e49133b3b75e5
2021-09-15 08:08:22 +00:00
Nataniel Borges
002ee4ccf0 Merge "Make FASS accessible from winscope" 2021-09-14 17:59:04 +00:00
Nataniel Borges
fb845bbc80 Make FASS accessible from winscope
Flickerlib has been refactored so that more functionality can be used directly in Winscope.

This will enable us to add an option in winscope to detect transitions
for manually created WM and SF traces, without relying on flicker.

The winscope change is not part of this topic.

This CL updates winscope for compatibility

Test: build and check if winscope works
Change-Id: I28dca32600786b7955afa98f632f06628b528222
2021-09-14 12:47:18 +00:00
Shashwat
92d886ff60 Allow add file button to upload .winscope files
Bug: 199837682
Test: Can upload .winscope files by clicking "Add File". They are no
longer greyed out.

Change-Id: I547a7d627c89549723bd0bb60ceb53d5e6e8919a
2021-09-14 10:17:29 +00:00
Shashwat
3f81b13a28 Add box for drag and drop files on winscope
Test: Please see home screen with dashed drag and drop section on Open Files section.
Bug: 199517977
Change-Id: Ida5c8979e1e98a5be6ead0af4d0da63c65df2d87
2021-09-10 16:33:28 +00:00
Priyanka
5292fee7c2 Minor winscope improvements.
Expand/collapse button for traces now centred with icon. Keyboard arrows
move cursor in input text fields, rather than the timeline. Error lines now clickable and hit
area increased - click to navigate to error timestamp. Timestamp label
on minimized timeline and seek time field on expanded timeline are now
editable in the same way as the search timestamp function in search bar.

Bug: b/199146199
Test: Upload any trace to see the implementations.
Change-Id: Iff2c5423933b7f77292f0786ddcf5ffe715c2854
2021-09-09 09:38:15 +00:00
Priyanka
b415682b29 Add display support for tag fields and app pairs.
LayerId now present on windows, and window token will be added to tags
where possible, so display support added on frontend. Also, app pairs
transitions added to colour code.

Bug: b/199274556
Test: upload a trace to ensure everything still displays as normal.
Change-Id: I5d0c2e26ac5f18090d0fe6e8df5f4e1305822c41
2021-09-08 15:10:08 +00:00
TreeHugger Robot
e0e7565fbd Merge "Pass layerId from proto data through to WindowContainer constructor" 2021-09-06 16:56:41 +00:00
TreeHugger Robot
493fd1cd04 Merge "Change defaults to 0 for taskId and layerId." 2021-09-06 16:44:40 +00:00
Nataniel Borges
c8dad66975 [DO NOT MERGE] Sync flicker from master to sc-v2 am: 325b0476f5
Original change: https://googleplex-android-review.googlesource.com/c/platform/development/+/15737825

Change-Id: I98cc88b49f25f7066e9b4de4dc2b1e27b7b4528d
2021-09-04 00:36:01 +00:00
Priyanka
6d70b2ed93 Change defaults to 0 for taskId and layerId.
Bug: b/198634721
Test: check upload of tags with only a taskId or a layerId.
Change-Id: I8fc44f6074a1e17264177d251f1bd7ba319701d2
2021-09-03 15:12:19 +00:00
Priyanka
70283c4740 Group tags by id and transition.
Tag Id increments for each additional transition of the same type but
resets to zero as each processor is called. This fix groups tags by both
id and transition to avoid confusion.

Bug: b/198757467

Test: upload a trace with multiple types of transition, where
transitions have the same tag id.

Change-Id: Idad9c04dc5ac01faf0234d131cbb03364b2ccc36
2021-09-03 13:04:32 +00:00
Pablo Gamito
592e789e97 Pass layerId from proto data through to WindowContainer constructor
Test: N/A
Change-Id: I8a8db9b496567c0777a1008bc3040fe3f25999e8
2021-09-03 12:43:32 +02:00
Priyanka
06873c96cf Fix logic for multiple tags with same id.
Bug: b/198622547

Test: upload the traces attached to the bug to ensure a rotation
displays on the timeline.

Change-Id: I6acd8bf0bdbd5d2ad15664dcd16096a711697440
2021-09-02 15:21:30 +00:00
Kelvin Zhang
4c253b5284 Merge changes Ic5fdefe2,I32cbd027,I464d846c,Ie9ef8e2b,Ib7b02d5c am: e6ae7c629b am: 8834603a01 am: a30572e3a4 am: 06bfa0009e am: 93ddcc59d9
Original change: https://android-review.googlesource.com/c/platform/development/+/1815621

Change-Id: Ib20dee3d3484d5f1ad785eacdbbec3e620533905
2021-09-01 15:34:03 +00:00
Kelvin Zhang
a230cdc9b6 Merge "Cancel polling task after component unmount" am: 3862d22d0e am: b1da09b852 am: 8a287efeea am: c2272f8e82 am: bd2f4b0e13
Original change: https://android-review.googlesource.com/c/platform/development/+/1815616

Change-Id: I939fa8046e9a0100e7704c62c9b2742ba7104a7c
2021-09-01 15:33:55 +00:00
Kelvin Zhang
623e83e227 Merge "Remove noop try catch statements" am: 401c6d5d23 am: 5e1f196247 am: 5a581bdeb3 am: ad98f50a84 am: 0f9c47934c
Original change: https://android-review.googlesource.com/c/platform/development/+/1815095

Change-Id: I16b4bafca9efd85da23f81012d82f272070c8844
2021-09-01 15:33:45 +00:00
Kelvin Zhang
93ddcc59d9 Merge changes Ic5fdefe2,I32cbd027,I464d846c,Ie9ef8e2b,Ib7b02d5c am: e6ae7c629b am: 8834603a01 am: a30572e3a4 am: 06bfa0009e
Original change: https://android-review.googlesource.com/c/platform/development/+/1815621

Change-Id: I47799c78c525f3334f7eb02c1610ee1dc284d8e1
2021-09-01 15:18:30 +00:00
Kelvin Zhang
bd2f4b0e13 Merge "Cancel polling task after component unmount" am: 3862d22d0e am: b1da09b852 am: 8a287efeea am: c2272f8e82
Original change: https://android-review.googlesource.com/c/platform/development/+/1815616

Change-Id: Id9cc96c9d39f22d2165ae14f764a47ef37799f2d
2021-09-01 15:18:19 +00:00
Kelvin Zhang
0f9c47934c Merge "Remove noop try catch statements" am: 401c6d5d23 am: 5e1f196247 am: 5a581bdeb3 am: ad98f50a84
Original change: https://android-review.googlesource.com/c/platform/development/+/1815095

Change-Id: I0f523f35cf0fd72e8c1d1a499c98d4e7caf66c1f
2021-09-01 15:18:04 +00:00
Kelvin Zhang
8834603a01 Merge changes Ic5fdefe2,I32cbd027,I464d846c,Ie9ef8e2b,Ib7b02d5c am: e6ae7c629b
Original change: https://android-review.googlesource.com/c/platform/development/+/1815621

Change-Id: I18cc97ec071980725514785aafdd7927821410b8
2021-09-01 14:34:23 +00:00
Kelvin Zhang
b1da09b852 Merge "Cancel polling task after component unmount" am: 3862d22d0e
Original change: https://android-review.googlesource.com/c/platform/development/+/1815616

Change-Id: If897bc469c04123262e67807e05f74fdc5a50ac0
2021-09-01 14:34:12 +00:00
Kelvin Zhang
5e1f196247 Merge "Remove noop try catch statements" am: 401c6d5d23
Original change: https://android-review.googlesource.com/c/platform/development/+/1815095

Change-Id: I6c5c988fb833d75cf03359267db6bbce049319fa
2021-09-01 14:34:06 +00:00
TreeHugger Robot
20beac3c08 Merge "Display tags/errors on all timelines." 2021-09-01 10:57:24 +00:00
Pablo Gamito
1bd76ac672 Merge "Make search bar buttons clearer" 2021-09-01 10:42:32 +00:00
Kelvin Zhang
6e0c8c6c37 API Service should return json data directly
Change-Id: Ic5fdefe23443733c3c7e0ae8f351c39117326794
2021-08-31 20:06:57 -07:00
Kelvin Zhang
63b4252142 Merge "Skip non-zip files when refreshing build library" am: 2d4909a1cb am: 985259187a am: 0a3522a60e am: adb23121fd am: 6186351117
Original change: https://android-review.googlesource.com/c/platform/development/+/1811897

Change-Id: I93fc1da7bd208f5662bd147692a62ab7204e7350
2021-09-01 01:43:39 +00:00
Kelvin Zhang
6186351117 Merge "Skip non-zip files when refreshing build library" am: 2d4909a1cb am: 985259187a am: 0a3522a60e am: adb23121fd
Original change: https://android-review.googlesource.com/c/platform/development/+/1811897

Change-Id: Ibc3b79aca659deed86b6d4db1645a84fbc5df324
2021-09-01 01:22:18 +00:00
Kelvin Zhang
985259187a Merge "Skip non-zip files when refreshing build library" am: 2d4909a1cb
Original change: https://android-review.googlesource.com/c/platform/development/+/1811897

Change-Id: I376dbf4d7cf672a7d64419b6cfae634b5b66c91e
2021-09-01 00:37:19 +00:00
Kelvin Zhang
fd50cb8be1 Rename path to db_path
Change-Id: I32cbd02722a81b54f55df092bc762463df939a9d
2021-08-31 17:28:43 -07:00