Due to there being some slightly different timestamps between WM/SF
trace and IME trace, we want to allow some "fault tolerance" -- even
if a WM/SF entry comes after IME entry in time, it may still be the
corresponding entry if it's within a manually-defined "fault tolerance"
time.
For now, fault tolerance is defined to be 200ms. So if a WM/SF entry is
within IME entry +- 200ms, it may be considered a matching /
corresponding entry. Within this range, we will always try to pick a
WM/SF entry that comes before the IME entry. If there is no such WM/SF
entry, then we will pick one that comes after.
Bug: 236226833
Test: manual on local build of Winscope
Change-Id: I0782ec520284517bf964eeffd552e6175758c9f1
Make the following headers clickable; upon clicking, will show proto
details in the 'Properties' sub-panel on the right:
- WMState
- Ime Container
- Input Method Surface
- IME Insets Source Provider
Add the following properties:
- Focused window's color / rgba information -- focused window title
extracted from WM trace, the corresponding surface's rgba extracted
from SF trace
- InputMethod Window's visibility
- InputMethod Surface's visibility
- InputMethod Surface's rect & screenBounds
Remove the following properties:
- ImeContainer's rect & screenBounds
Rename the following properties:
- Frame (under 'Focus' heading) --> Input Control Target Frame
Screenshots: in buganizer ticket
Bug: 236226833
Test: manual on local build of winscope
Change-Id: I2a2747b57639f40c8f6bf71d5cb49268e4ee5044
Fix incorrect names of properties being extracted from WM Trace:
- 'Input Method Control Target' has been replaced with 'IME Control
Target', 'Input Method Input Target' with 'IME Input Target', and 'Input
Method Target' with 'IME Layering Target'.
Bug: 239145867
Test: manual on local build of winscope
Change-Id: If067cf73de32d4374b33d1f07f179b63c9fb0c27
Adding component spec tests for all new components involved in trace
collection. This includes a new card for this CL, UploadTracesComponent,
to make testing more methodical.
Test: npm run test:component
Bug: b/238981126
Change-Id: I46d1b24fed84ce35432dad36fd5ac24d35cd0542
Finishing proxy migration by creating functionality to run and end
traces and dumps after selecting trace config.
Test: Connect a device via remote device proxy and follow the proxy
workflow for a trace or dump. Should see a placeholder message saying data loaded (trace
views not yet created).
Bug: b/238113543
Change-Id: Ic7e0948341511f6ec0bf1021d2ffbb7b198c9410
None of the components should directly interact with the proxy because
non-android development workflow (using web adb) will also be possible
in the future. Instead the ui components interact with a common
connection interface which handles the proxy or web adb respectively.
Test: check that proxy workflow still works as expected.
Bug: b/234103636
Change-Id: I0e7bbaf4b5f342ca99dd67f890c135dbf3ef61ec
Migrating the proxy to the new trace collection UI. Should be able to
enter the proxy token, select your connected device and then make
changes to trace configrurations.
Test: try running the proxy and test that functionality is same as old
winscope.
Bug: b/238113543
Change-Id: I195f65df5d09e22db54cb9f5a7ba0396948f43d3
Created new UI components for trace collection. Since the proxy is not
yet migrated, click through the buttons to automatically cycle through
the components.
Bug: b/238981126
Test: npm run start
Click Web ADB tab to see basic component. Click ADB proxy tab to see
proxy component. Click Retry to get to authorisation options. Click
Connect to get to trace configuration component.
Change-Id: I1e7a9895ece06856c095d8c85c28d22bbfa94b31
Remove code related to error/tag, which was removed from the Kotlin flickerlib as well
Test: npm run build:all && npm run test:all
Change-Id: Iaba34b458dd08aaae5ad18968a11ca8ab2d1e33a
Fix vue-material errors that show up when using MdSelect (which
we use for <Overlay />). These errors are a known bug in the
vue-material codebase
(https://github.com/vuematerial/vue-material/issues/2285) but no
patch is out for it yet. Hence, downgrade vue-material to the
latest version that does not have these errors.
Test: manual with local build of Winscope
Bug: 238262637
Change-Id: Icffead3cbf1fa1f2a6e4ec83564078f396e660cf
With this change the exclude list file may have comments that start
with '#'
Test: Run collect_ninja_inputs.py with excluded file list that has
'#' comments
Change-Id: Ic2e3da8a34144426e00ebd45ee09ff9cb3b339bd
Now Parsers rely on the Blob interface/abstraction, instead of the concrete Uint8Array.
Thus, in the future we'll be able to implement incremental trace parsing (e.g. stream parsing)
without breaking client code (e.g. ABT).
Minor: specify timeout in end-to-end tests
Test: npm run test:all
Change-Id: I9098ee3beba231f4bb4b59b24cee60e5a1e1122e
Screenshot button is added as a camera icon at the top right corner
of each panel (e.g. WindowManagerTrace, SurfaceFlingerDump).
Upon clicking this button, an image is downloaded to the user's
computer (Downloads folder), showing the whole panel - Hierarchy,
Properties etc.
Added dependency: html2canvas library
Screenshot: https://screenshot.googleplex.com/5rRzqKcEVsJRW2K.png
Bug: 236226833
Test: manual on local build of Winscope
Change-Id: Idd476017a780288c0e5ae09ce62334333fb9a652
PropertiesTableView:
- Fix a PropertiesForTableView bug - did not account for null value
of IME 'Client' in the trace
- Remove ‘Key Properties’ table heading as it is obvious enough
TreeView:
- Wrap text properly in TreeView component (for node names)
IME Panels / WM&SF Properties sub-panel:
- Add table view for coordinates (for bounds, rects, frame etc.)
- Cut away the parent nodes above ‘ImePlaceholder’ or ‘Task’ node
for the SF subtree displayed in ImeTrace Clients & IMS panels
- Allow 2 SF subtrees, hypothetically: one for 'ImeContainer' and
one for 'IME-snapshot'
- Change its color when an InputMethod...Target is selected in
ImeTrace IMMS' WM&SF Properties sub-panel
- Show a message when there is no corresponding WM / SF entry
- Fix y-overflow / scrolling issues for the WM&SF Properties sub-panel
- Add SFLayer timestamp in WM&SF Properties sub-panel
- Change 'bounds' to 'screenBounds' attribute of ImeContainer
Screenshots: in buganizer ticket
Bug: 236226833
Test: manual on local build of winscope
Change-Id: I667bb97a580ba8dd2f17e86f956012b69b964767
Previously, some Winscope traces and ADB captures will go into an
infinite loop after IME processing was introduced.
The issue was a loop in filtering the SF Layer node that did not
account for multi-windowing mode or cases where the expected parent
could not be found. This commit fixes this issue.
Bug: 236679852
Test: manual with previously failing traces
Change-Id: I8d3fe42802efa195926b5be0d4242a0bb0696988
- Add constants to flickerlib's common.js defining the "kind" of
WindowManager and SurfaceFlinger entries
- Modify flickerlib's WindowManagerState and LayerTraceEntry,
as well as ime_processing.js, to use these constants
- Modify the "kind" of IME entries directly in transform_ime.js.
In the future, these should also be constants defined in flickerlib
Bug: 236226833
Test: manual on local build
Change-Id: I310f301e82ae976a202ca1c8cc40c7b686a9723f
- Extract specific WM / SF properties and display only in relevant IME
panel(s) (Client / Service / ManagerService)
- Add clickable items in 'WM & SF Properties' sub-panel that shows full
tree in 'Properties' sub-panel
Screenshots:
- ManagerService: https://screenshot.googleplex.com/ZkoDs8SfxLtprH5.png
- Clients: https://screenshot.googleplex.com/7PT6GG8YRbNrDcC
- Service panel displays the same properties as Clients panel
Bug: 236226833
Test: manual on local build of winscope
Change-Id: Ie96e17cf32311e56af66f8cee66e4f92b9751b5b
If there are WM or SF trace entries that correspond with IME trace
entries (i.e. the WM/SF entry comes before the IME entry in time),
the 'WM & SF Properties' sub-panel will be displayed below the
'Hierarchy' sub-panel in the IME trace panel.
- This sub-panel currently displays properties extracted from
WM entry, not yet SF entry.
- Code is added in 'ime_processing.js' to extract WM properties,
and 'freeze: false' is set in 'transform_ime.js' so that IME entry
objects are not frozen and can be modified during processing
- SF entry, displayed as a tree in the Hierarchy sub-panel, is pruned
to only ImeContainer or IME-snapshot node and its sibling nodes.
Note: there is a bug in this CL (b/236679852) that is fixed later
in CL[6]. Also, null values are not handled well in this CL, and
will be fixed later in CL[4].
Screenshot: https://screenshot.googleplex.com/6RXiRyX47qLAL9i.png
Bug: 236226833
Test: manual on local winscope
Change-Id: I07be7f492a6275c3fdafd6d1f523fdf4d552d16b
IME processing refers to adding WM and SF properties into corresponding
IME entries. Shared functions for this are in 'ime_processing.js',
called when IME and WM / SF traces are input via both ADB or file upload.
- WM and SF entries are displayed as nodes in the 'Hierarchy' sub-panel
of IME panels.
- The SF entry is pruned to only the branch containing 'ImeContainer'
node.
- The WM entry is not yet filtered.
Screenshots:
- Before: https://screenshot.googleplex.com/BYU279cqkTQ5iBP.png
- After: https://screenshot.googleplex.com/3Uhj3XBcpp9Cc6u.png
- Note: screenshots only show 1 IME panel; same changes are made to
all 3 IME panels
Bug: 236226833
Test: manual via local Winscope
CL[1]: If64aff9e899363188010633758e36be474666984
Change-Id: I31d96a43769d64d1e0151b8d620d9d5beaaf7e79
Add a new toolbar at the top of the front page of Winscope app.
This toolbar will show a list of beta features and checkboxes for
users to choose whether to use the beta feature.
For now, the only beta feature is the new / improved UI version
of the ImeTrace panels (to be implemented in the next few CLs).
Bug: 236226833
Test: manual (on local winscope build)
Change-Id: If64aff9e899363188010633758e36be474666984
Previously in [1], the style in PropertiesTableView component is applied
directly to common Vue components like <md-table-cell />. This may
create confusion in the future if <md-table-cell /> is used in other
components, as the style configuration of <md-table-cell /> would not
be the default Vue one, and would instead follow PropertiesTableView's.
This commit fixes this issue by limiting the scope of the CSS styling
in PropertiesTableView.vue.
CL[1]: I39fe382ffb50d71e67cace912452a33ca49de3f9
Test: manual on local build of Winscope
Bug: 235313782
Change-Id: I44d9afb8f49cc21748807c0b8b7e912db6f37a52
