Commit Graph

27281 Commits

Author SHA1 Message Date
Treehugger Robot
719f925df0 Merge changes I5775d732,I27673017
* changes:
  [DO NOT MERGE] Add aosp config for winscope
  Create stub proto definitions for traces that are not available in AOSP
2020-01-28 01:40:39 +00:00
Vishnu Nair
c49c2698ec [DO NOT MERGE] Add aosp config for winscope
- config redirects searches to stub folder for unavailable traces

Bug: 148409169
Test: builds and opens traces in AOSP
Change-Id: I5775d732de64c2e66ed35a04bf868f2aee883add
2020-01-27 15:12:29 -08:00
Vishnu Nair
92dccb506d Create stub proto definitions for traces that are not available in AOSP
Also add a readme for winscope development.

Bug: 148409169
Test: builds and opens traces in AOSP

Change-Id: I2767301734bcd90410e0f97bc3da22a647bf195c
2020-01-27 15:12:27 -08:00
Treehugger Robot
c9a7975674 Merge changes Id1d59bd7,Ief46f2f3,I2e34edd2,I203f3f19,I756b596c, ...
* changes:
  Added visibility check for missing relativeOf
  Added format for ColorTransform matrix
  Update Winscope with ProtoLog changes
  Download trace files from Winscope
  Support ProtoLog in Winscope
  Support WM & SF dumps with ADB Connect, minor fixes
  Add transaction tracing support, fix device id regex.
  Introduced filters to winscope for transaction files.
  Fix variable name in DataAdb
  Limit the height of Hierarchy and Properties views.
  Add support for Wayland traces
  Winscope: prefix layer id to surface flinger layer name
  Fixed bug when clearing file, winscope could not allow up/down arrows.
  Changed shell script for capturing traces.
  Implement Winscope ADB connect.
  Added transaction support for winscope.
  Update vue-material, regenerate yarn.lock
  Refactor file decoding, implement video view
  Fixed visibility check in winscope.
  Added check for invalid transform.
  Added reasons for invisibility of a layer.
  Fix overlapping timeline indicator
2020-01-27 19:10:36 +00:00
Treehugger Robot
6e988fdc1a Merge changes I11abcf8b,Ia638bb4f
* changes:
  Support multiple trace files.
  Improved logic for error detection.
2020-01-27 18:59:07 +00:00
chaviw
0fa0953237 Added visibility check for missing relativeOf
When the layer has the flag isRelativeOf but the relativeOf is -1, that
means the relativeOf layer has been removed. This would prevent the
layer from showing up on screen, but still be in memory. Added this
reason to list of reasons why layer wouldn't be visible.

Also added fix for BufferLayer check to instead check for BufferQueueLayer
and BufferStateLayer.

Test: winscope shows "RelativeOf layer has been removed"
Change-Id: Id1d59bd71a5aac7a011204ba345d694f67c28a29
Merged-In: Id1d59bd71a5aac7a011204ba345d694f67c28a29
2020-01-27 10:20:14 -08:00
chaviw
0d8808df5e Added format for ColorTransform matrix
ColorTransform is a 4x4 matrix so formated the values to be more
readable.

Also changed code where determines if the buffer is null to check if the
layer type is BufferStateLayer or BufferQueueLayer

Test: go/winscope with color transform
Change-Id: Ief46f2f3260e0736ffced8c233ab375e162d4228
Merged-In: Ief46f2f3260e0736ffced8c233ab375e162d4228
2020-01-27 10:20:05 -08:00
Adam Pardyl
819c345c1e Update Winscope with ProtoLog changes
Winscope side changes for ag/9225809 and ag/9447040.

Bug:
Test: yarn run dev
Change-Id: I2e34edd244996124fa894ee5ee5a57f554fe771e
Merged-In: I29db4770065ffc5bcced5d4cb17a51d2b9924f06
2020-01-27 10:19:57 -08:00
Adam Pardyl
2a94ec6dba Download trace files from Winscope
Added a download file button to DataView.

Bug:
Test: yarn run dev
Change-Id: I203f3f19168c43a0dbefb3ec00237c021380f89f
Merged-In: I203f3f19168c43a0dbefb3ec00237c021380f89f
2020-01-27 10:19:43 -08:00
Adam Pardyl
c5708b2f83 Support ProtoLog in Winscope
Added a new view for displaying logs, ProtoLog decoding and tracing
with ADB Connect.
Fixed a vertical scrolling bug.

Bug:
Test: yarn run dev
Change-Id: I756b596c10242ff919c0d7053813fa0b9f1f88fd
Merged-In: I756b596c10242ff919c0d7053813fa0b9f1f88fd
2020-01-27 10:19:32 -08:00
Adam Pardyl
7c3b2d568f Support WM & SF dumps with ADB Connect, minor fixes
Added support for capturing WindowManager and SurfaceFlinger dumps
directly from the browser.

Fixed DataFilter errors on non-transaction data files.
Fixed Timeline behaviour on empty data list.

Bug: 140374376
Test: yarn run dev & python3 adb_proxy/winscope_proxy.py
Change-Id: I0d47ec36e1e769b856365d2a36c91bfb1f831b71
Merged-In: I0d47ec36e1e769b856365d2a36c91bfb1f831b71
2020-01-27 10:19:23 -08:00
Adam Pardyl
f9e219ce1d Add transaction tracing support, fix device id regex.
Added support for recording SF transactions with ADB Connect,
Fixed device regex not matching emulated devices.

Bug:
Test: yarn run dev & python3 adb_proxy/winscope_proxy.py
Change-Id: I43b45b978841309d3f011df919df69ae7ebc905a
Merged-In: I43b45b978841309d3f011df919df69ae7ebc905a
2020-01-27 10:19:13 -08:00
Vishnu Nair
a1262475d3 Introduced filters to winscope for transaction files.
Test: Launch winscope and upload a transaction file. Verify that the
filter checklist at the top left corner will filter each of the eight
increment types.

Change-Id: I3e2506bdbe32dbcda59b6f263e2bc13e8403ae38
Merged-In: I3e2506bdbe32dbcda59b6f263e2bc13e8403ae38
2020-01-27 10:19:02 -08:00
Adam Pardyl
ab03a005c0 Fix variable name in DataAdb
A typo in a variable name caused the exception handling to fail.

Bug:
Test: yarn run dev
Change-Id: Id02495fe323bbb7f6ccbb973fbe6091a3d518523
Merged-In: Id02495fe323bbb7f6ccbb973fbe6091a3d518523
2020-01-27 10:18:51 -08:00
Adam Pardyl
cbe7c4e5ed Limit the height of Hierarchy and Properties views.
Bug:
Test: yarn run dev
Change-Id: I50d4c9ebe7c376cd7595ffddc092b8d3c760c629
Merged-In: I50d4c9ebe7c376cd7595ffddc092b8d3c760c629
2020-01-27 10:18:39 -08:00
Evan Rosky
e1f3d5d92b Add support for Wayland traces
This adds support for wayland traces, but it isn't complete.
Specifically the rects are ordered funny. However, it is enough
to help with debugging and can be improved over time.

Bug: 129502361
Test: Open a wayland trace and a wayland dump
Change-Id: Iee327f2fee2651ff492d56ee0b06935b5ed57de7
Merged-In: Iee327f2fee2651ff492d56ee0b06935b5ed57de7
2020-01-27 10:18:28 -08:00
Vishnu Nair
33009d144c Winscope: prefix layer id to surface flinger layer name
Also fixes exception on startup in App.vue

Test: open sf trace in winscope
Test: open winscope with debugger and check for exceptions

Change-Id: I2b0e1fad5f26258e7f2ca5c47f82ad11037a84d2
Merged-In: I2b0e1fad5f26258e7f2ca5c47f82ad11037a84d2
2020-01-27 10:18:19 -08:00
Robert Delgado
2c4be1fc8d Fixed bug when clearing file, winscope could not allow up/down arrows.
Test: run yarn dev. First launch a file on winscope, clear, then launch a
second, different file. Now, the up/down arrows will be able to function again.
Change-Id: I4140a1a8f8e1c4d9d2cef054456003aec5661412
Merged-In: I4140a1a8f8e1c4d9d2cef054456003aec5661412
2020-01-27 10:18:09 -08:00
Robert Delgado
a14866b210 Changed shell script for capturing traces.
Captures both transaction and surfaceflinger trace files.

Test: bash capture_transaction.sh then upload transactiontrace.pb and
layerstrace.pb files to the winscope server.

Change-Id: I4461afa4048a504a158e5837af7c75fbedafeb0f
Merged-In: I4461afa4048a504a158e5837af7c75fbedafeb0f
2020-01-27 10:17:59 -08:00
Adam Pardyl
8b38ea8f8d Implement Winscope ADB connect.
The objective of this feature is to simplify the process
of debugging window transition issues by implementing
an automated trace capture flow for the WindowManager
and SurfaceFlinger trace analysis tool - Winscope.
By creating a bridge between the browser-based Winscope
and locally running ADB server traces can be captured
with a single click.

Design doc: https://goto.google.com/winscope-adb-connect

Bug:
Test: yarn run dev & python3 adb_proxy/winscope_proxy.py
Change-Id: I13ee2274566de5e63c89a9e292708416b654fc65
Merged-In: I13ee2274566de5e63c89a9e292708416b654fc65
2020-01-27 10:17:49 -08:00
Robert Delgado
b6eb992807 Added transaction support for winscope.
Test: yarn run dev for a transaction file.
Change-Id: Icfc672e2ab8423da35602d6d3d2e174c53c0154a
Merged-In: Icfc672e2ab8423da35602d6d3d2e174c53c0154a
2020-01-27 10:17:39 -08:00
Adam Pardyl
10884cd134 Update vue-material, regenerate yarn.lock
Version update of vue-material is required by a future CL.

Bug:
Test: yarn run dev

Change-Id: I355720677530066f8bceeb4b36b3841186a67ac1
Merged-In: I355720677530066f8bceeb4b36b3841186a67ac1
2020-01-27 10:17:27 -08:00
Adam Pardyl
f33d616849 Refactor file decoding, implement video view
File decoding code has been refactored to support non-trace files.
Implemented displaying device screen recordings frame-by-frame,
synced to SurfaceFlinger and WindowManager traces.

Design doc: http://go/winscope-video-sync

Test: yarn run dev
Bug:
Change-Id: Ibaa4746a74ecab4ff158cb8bffb346e1f90f8306
Merged-In: Ibaa4746a74ecab4ff158cb8bffb346e1f90f8306
2020-01-27 10:17:15 -08:00
Robert Delgado
0258452674 Fixed visibility check in winscope.
Changed visibility reasoning to check for bufferTransform validity only
when activeBuffer is valid. Also separated reasoning for
transforms and bufferTransforms.

Test: yarn run dev then run a trace file.
Change-Id: I6ed2065c2f316019d9dde41a613b02c311c705e4
Merged-In: I6ed2065c2f316019d9dde41a613b02c311c705e4
2020-01-27 10:17:05 -08:00
Robert Delgado
92b922ac24 Added check for invalid transform.
Test: A transform whose matrix is not invertible.
Change-Id: I6b0b5b9a1c890c8a8694f17a4fbe52a2e875b51a
Merged-In: I6b0b5b9a1c890c8a8694f17a4fbe52a2e875b51a
2020-01-27 10:16:54 -08:00
Robert Delgado
37a206b10b Added reasons for invisibility of a layer.
Test: Create an SFTrace that opens an app, then closes. Then test the
wide variety of layers created by this file.

Change-Id: Idd198cc6507c67a03f38cf3e34d737d319295c16
Merged-In: Idd198cc6507c67a03f38cf3e34d737d319295c16
2020-01-27 10:16:43 -08:00
Adam Pardyl
d49db4cbfb Fix overlapping timeline indicator
The selected data point indicator on timeline was often hidden behind
other data points. This CL changes its behaviour to ensure it is always
visible.

Test: yarn run dev
Bug:
Change-Id: Ide13e97ac7ab54e20cc6213be2ccdadce3d567a7
Merged-In: Ide13e97ac7ab54e20cc6213be2ccdadce3d567a7
2020-01-27 10:16:31 -08:00
Adam Pardyl
813431292c Support multiple trace files.
This commit allows to view trace for both SurfaceFlinger and
WindowManager at the same time using one timeline.

Test: yarn run dev
Bug:
Change-Id: I11abcf8b6423a03ca9af63e56a7b992958d21175
Merged-In: I11abcf8b6423a03ca9af63e56a7b992958d21175
2020-01-27 10:16:29 -08:00
Robert Delgado
8bd2346edf Improved logic for error detection.
Test: Ran windump, winlayer, surfacedump, surfacelayer, and a txt file
on winscope's autodetect file upload feature.
Change-Id: Ia638bb4fbd9c5ad24ac7c84814205eaa8d429824
Merged-In: Ia638bb4fbd9c5ad24ac7c84814205eaa8d429824
2020-01-27 10:16:25 -08:00
Hsin-Yi Chen
cfeef5f41c Merge "Update the format of module variant dir name" 2020-01-08 01:58:55 +00:00
Haibo Huang
f8514fe646 Merge "Add --lldb to gdbclient.py" 2020-01-07 21:14:10 +00:00
Treehugger Robot
aa2b5e1a70 Merge "Output diff result to stderr" 2020-01-07 11:49:51 +00:00
Yo Chiang
967803932e Output diff result to stderr
compare_images_and_print.sh redirect diff result to stderr, so that the
stdout and stderr log don't get interwined.
Don't `cat` common.csv as it is not very useful and clutters the log.

Test: ./development/vndk/tools/image-diff-tool/compare_images_and_print.sh \
    --check "-t \
    compare_images_test/mainline_system_google_arm64-target_files-6112128 \
    compare_images_test/coral-target_files-6112128 -s SYSTEM -i"

Change-Id: Idf609c43a0d1e488ecb2baca99c8ff98edcf7798
2020-01-07 18:30:46 +08:00
Hsin-Yi Chen
d63e723548 Update the format of module variant dir name
The old suffixes were _core_shared and _vendor.{VER}_shared.
The new suffix is _shared. The new prefix for VNDK is vendor.{VER}_.

Bug: 147254738
Test: ./create_reference_dumps.py
Change-Id: Ieb37c14d5deaab437783c07edf268c1488afa441
2020-01-07 13:36:25 +08:00
Haibo Huang
e194fcecf9 Add --lldb to gdbclient.py
Test: `gdbclient.py --lldb -r /system/bin/toybox` and try `b main` `c`
Test: `/data/local/tmp/arm64-lldb-server gdbserver :5039 /system/bin/toybox` and `gdbclient.py --lldb -p 4909`
Change-Id: If7b6895e9c778cdee3764a4058cf70238bdd6b8a
2020-01-06 14:55:28 -08:00
Treehugger Robot
eaee8a5229 Merge "Move the app to /system_ext" 2019-12-31 00:50:15 +00:00
Jeongik Cha
b7aa057aa1 Move the app to /system_ext
As mentioned in go/partitions-in-r, we plan to forbid hidden API in
product partition.
So this app should be moved to /system_ext because it uses hidden API.
It is not permanent, so they can be moved back to /product due to
needs if there isn't hidden usage anymore.

Bug: 137908189
Test: m
Test: check whether device boots successfully
Change-Id: Id1e897eadea814b780f199fa7f3d683924eb4ab3
2019-12-30 04:42:01 +00:00
Jiyong Park
1bc6c36e3e Merge "Move android_*_stubs_current modules to frameworks/base" 2019-12-23 05:25:18 +00:00
Jiyong Park
d3edb1b2a1 Move android_*_stubs_current modules to frameworks/base
frameworks/base/StubLibraries.bp is the place where the droidstubs and
java_library modules for the API stub libraries are defined.

Bug: N/A
Test: m

Exempt-From-Owner-Approval: cherry-pick from internal

Merged-In: I407d0d939582841ffa651488bf76667ab7ce9c64
(cherry picked from commit f371ec46ec)
Change-Id: I407d0d939582841ffa651488bf76667ab7ce9c64
2019-12-22 17:21:55 +09:00
David Gross
519a9f6d57 Merge "Populate SDK with clang linker (lld) in addition to GNU linker." 2019-12-19 18:21:16 +00:00
David Gross
00be4d0b38 Populate SDK with clang linker (lld) in addition to GNU linker.
Note that clang linker is multi-target whereas GNU linker is
single-target; so while we need multiple GNU linkers (because we
support multiple targets) we only need a single clang linker.

We retain the GNU linkers so that a new SDK is still compatible with
older gradle plugins.

Bug: 142590626
Bug: 144040336

Test: (gLinux) m PRODUCT-sdk_phone_armv7-sdk dist sdk_repo
      (gLinux) m PRODUCT-sdk_phone_armv7-win_sdk dist sdk_repo

Change-Id: I2a04f6fd464b5eb6a2e9a632f49409c1d7e60170
(cherry picked from commit c22ed0eece)
2019-12-18 16:15:59 -08:00
Logan Chien
5ff740f0ed Merge "header-checker: Remove C++ 17 usages" 2019-12-17 05:52:02 +00:00
Treehugger Robot
384d61d947 Merge "Add preserve_extracted_files option in compare_images" 2019-12-17 05:00:30 +00:00
Jeongik Cha
e35e89dd77 Add preserve_extracted_files option in compare_images
With the option: extract zip file in the directory where zip is, and the
extracted files remain.
Without the option: extract zip file in tmp and clean up after a run

Test: check if files remain with -p option
Bug: N/A
Change-Id: I1aa74c017dbb885481b8f5a0674d089c0a732620
2019-12-17 02:03:20 +00:00
Logan Chien
877c9a1457 header-checker: Remove C++ 17 usages
Bug: 139945549
Test: OUT_DIR=out \
      ./development/vndk/tools/header-checker/android/build-prebuilts.sh
Change-Id: Ia98e03e532ca91e52eb6be561ae8082da1c6bcc7
2019-12-16 22:31:33 +00:00
Treehugger Robot
d8055f8cee Merge "Extract zip file in tmp directory" 2019-12-16 07:17:45 +00:00
Treehugger Robot
b2ddb4d536 Merge "header-checker: Encapsulate AbiDiffHelper" 2019-12-12 18:21:04 +00:00
Treehugger Robot
f253fc4007 Merge "header-checker: Remove type_id" 2019-12-12 17:01:36 +00:00
Treehugger Robot
3addde7f6b Merge "[Bug Fix] Not able to create secondary user due to lack of permission" 2019-12-12 02:23:26 +00:00
Weilun Du
aa2ec781e8 [Bug Fix] Not able to create secondary user due to lack of permission
BUG: 145353724

Signed-off-by: Weilun Du <wdu@google.com>
Change-Id: Icce8f6d280b29c4390dcd5947516a06448799862
2019-12-11 09:58:45 -08:00