- Fix order of accesses to TracingConfig class. The CollectTracesComponent used to fetch
configurations from TracingConfig before TraceConfigComponent changes, i.e. CollectTracesComponent
was missing the latest changes to TracingConfig.
- Remove TracingConfig initialization performed in AppComponent. Now TracingConfig takes care of
fetching the globalConfig's MODE (DEV or PROD) and initialize accordingly.
- Remove TracingConfig#isTracingConfigSet(). Now TracingConfig is always fully constructed/initialized.
- Rename various "tracing config" methods to "trace config" to reduce confusion with TracingConfig class
Fix: b/267275104
Test: npm run build:all && npm run test:all
Change-Id: I168a25f69a405422d8d983d5710d6a67773f0b48
Fix: b/265342451
Test: click trace config checkboxes + drop down lists and check they work as expected
Change-Id: I5bd8ab8bd20b15e97c9e8ca4fead94fd42337971
Ensure the UI shows the checkbox as being clicked immediately instead of when clicking out only.
Test: click on the trace config checkbox and make sure they are uncheck and checked as expected
Change-Id: I37471161e38f473310433a772cb0def3ab747b16
A fork of cargo2android, initially aimed at big imports like crosvm.
* Faster run time when there are many packages (30 min -> 1 min for
crosvm).
* `--reuse-cargo-out` feature allows iterating on most of the config
with sub second run time.
* Most options can be specified per-package.
Bug: 261486161
Test: ran on crosvm and checked diffs
Change-Id: Iaf3f4732e828a6f8b281f0e63fe1e0e1e9e98631
Previously the viewer had all methods in the builder because of name
mangling. With jsName annotation this issue was solved and we can now
use the correct API
Test: open winscope and take a SF dump
Change-Id: I4c1ad3dada5ce994540adb45ad04041e02a4ad39
This will help those working on tm-dev to run the new winscope, without having to download an additional file.
Change-Id: I7aaaef7eb2ae6166bc914db81ffa1f557d4d62e1
Fixes: 264719130
Test: run the proxy, open go/winscope and check if it can collect traces
+ ensure displays are sorted to ensure same ordering between SF and WM trace displays
Fixes: 264688936
Test: npm run build:unit && npm run test:unit
Change-Id: If5cbeb1f14545a30da0c0181884ab74132bdde77
Will revert/adapt this change once the new winscope_proxy.py will
be available in AOSP as well.
Bug: b/264573983
Test: open winscope, click on "Download from Code Search"
Change-Id: I2c03c7d295465ef60c4c6c3f61399c90cb7ff1c0
Rectangles with property cornerRadius === 0 could result
in weird triangular shapes being drawn instead of rectangles
Fix: b/264541479
Test: follow steps in b/264541479 and check issue is gone
Change-Id: I2421e47cdbf7c932218640f2553647ded676a80d
Add tslint with google3 config (google3/javascript/typescript/tslint).
Skipped google3 custom rules that need to be built and added to the project.
If needed, with some extra effort it should be possible
to get the google3 rules to build/run also in the Winscope environment.
However, it is probably simpler and quicker to run (and maybe fix?)
those checks on critique once we port Winscope to google3.
Fix: b/264505907
Test: npm run tslint:check / npm run tslint:fix
Change-Id: If3a79de673503e0c06541f0329163dee93849c3c
Handle the case where corner radius > height/2 (or width/2)
Fix: b/264264761
Test: npm run build:all && npm run test:all
Change-Id: I9327189a3b9a59128d9ed3cc885f5887900a952a
The rounded corners property should be 0 on WM traces, instead of null
Fixes: 264024995
Test: open a wm trace and check rects view
Change-Id: I53e6668a8bdaa460e2e740936b719a3a4f813f8c
Add new check based on tool "madge" to prevent cyclic dependencies regressions.
Madge currently reports 10 cycles. The new check makes sure we don't introduce new ones.
Bug: b/261552483
Test: npm run deps_graph:check_cycles
Change-Id: I2630ddcb94101be9b288ce0708fca3231962f406
Unleash prettier on the entire codebase
Fix: b/263471740
Test: npm run format:check && npm run lint:check
Change-Id: Ida110947bec9c9a9b385c64e126ccf6d7ad6652b
- Add npm scripts format:check, format:fix, lint:check, lint:fix
- Include format:check + lint:check into the test suite (test:all)
- Configure eslint to play nice with prettier (basically no format checks)
Test: npm run format:check && npm run lint:check
Bug: b/263471740
Change-Id: I6f215860a24302ed04c2689ac31e4dd4e7e6fd5e
