Commit Graph

33970 Commits

Author SHA1 Message Date
Kean Mariotti
bfb80775a6 Improve rects view code health
Fix: b/254244305
Test: npm run test:component
Change-Id: Iac424696b4351dc22c2f802d19aff6d7b029556c
2022-10-21 09:55:15 +00:00
Kean Mariotti
fe3458851f Improve rects view
- Labels have typography consistent with the rest of Winscope
- Fix labels position - get rid of fragile hardcoded x-axis shifts

Fix: b/251785717
Test: run "npm run start", load SF trace, check layers labels
Change-Id: Id32b31f3bf66e4096fedfb3369f6df479f4e0c47
2022-10-21 09:19:18 +00:00
Kean Mariotti
9815ff5c32 Remove blank space in properties view
- WindowManager viewer
- IME viewers

Fix: b/254437771
Test: load WM + IME traces in winscope, click on an entry in the hierarchy view, check that there is no blank space in the properties view between controls on top (filter) and the properties (tree) view below
Change-Id: I943433b594e91d4d6323af50087002b42d324d40
2022-10-21 09:19:18 +00:00
Kean Mariotti
5137d1ae45 Fix npm package vulnerability
The previous version of terser was volnerable to ReDos attacks.

Test: npm audit
Change-Id: I0ceda6931e68ad4338f7b382bfc6866812315e08
2022-10-21 09:19:18 +00:00
Kean Mariotti
0fa0e6070b Add prettier
Test: npm run prettier
Change-Id: Ie15a2104be13ccf37ca155c334fdd2798bad539f
2022-10-21 09:19:18 +00:00
Kean Mariotti
fd6c1bdf85 Merge "Add viewer Transaction" 2022-10-21 09:18:10 +00:00
Kean Mariotti
81c2db9a67 Add viewer Transaction
Fix: 238088678
Test: npm run build:all && npm run test:all
Change-Id: I90ad36a0a18e3b68216ea18d2a47e3ff38d98412
2022-10-21 08:13:54 +00:00
Kean Mariotti
fe5c7132de Remove obsolete dependencies to legacy transactions proto
Fix: b/254653004
Test: yarn build
Change-Id: I864c3c3a6a8524e54e363398f17403db7e81c0a6
2022-10-20 16:39:09 +00:00
Kean Mariotti
00c160c5fd Merge "Add viewer ProtoLog" 2022-10-20 15:23:52 +00:00
Treehugger Robot
3deceb52e7 Merge "Use gdb-remote without host if not given" am: a063ff34e4 am: d48428a5a9 am: ece1e0406b
Original change: https://android-review.googlesource.com/c/platform/development/+/2254565

Change-Id: Icdee637968b93eb7047ad28f85da2f104ecda870
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 20:19:09 +00:00
Treehugger Robot
ece1e0406b Merge "Use gdb-remote without host if not given" am: a063ff34e4 am: d48428a5a9
Original change: https://android-review.googlesource.com/c/platform/development/+/2254565

Change-Id: Id92f8272adeaaeba41683019b00210754d54046b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 19:47:02 +00:00
Treehugger Robot
d48428a5a9 Merge "Use gdb-remote without host if not given" am: a063ff34e4
Original change: https://android-review.googlesource.com/c/platform/development/+/2254565

Change-Id: Id44f10fcb801a7781e00056f8099ab9a764c1265
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 19:00:23 +00:00
Treehugger Robot
a063ff34e4 Merge "Use gdb-remote without host if not given" 2022-10-19 18:38:57 +00:00
Florian Mayer
b61f795aa4 Use gdb-remote without host if not given
Test: lldbclient.py -r ls
Change-Id: I162d318fa30c44f180b6104b31e61e7521fb6a48
2022-10-19 01:16:11 +00:00
Treehugger Robot
01ec705b9f Merge "Remove scripts that haven't yet been updated for python3." am: 002769b04c am: 037b36fd6e am: e7d3461c31
Original change: https://android-review.googlesource.com/c/platform/development/+/2260065

Change-Id: Ifecdf3d7beb96b06e22dbb0c863dcc5a85c01a08
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 01:01:22 +00:00
Treehugger Robot
e7d3461c31 Merge "Remove scripts that haven't yet been updated for python3." am: 002769b04c am: 037b36fd6e
Original change: https://android-review.googlesource.com/c/platform/development/+/2260065

Change-Id: Ic0103b8470c1d4e7583bc07c5c0c6162facea599
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-19 00:12:20 +00:00
Treehugger Robot
037b36fd6e Merge "Remove scripts that haven't yet been updated for python3." am: 002769b04c
Original change: https://android-review.googlesource.com/c/platform/development/+/2260065

Change-Id: Ie029fe896fa829c44d4f86f8953d24a88890c908
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 23:42:05 +00:00
Treehugger Robot
002769b04c Merge "Remove scripts that haven't yet been updated for python3." 2022-10-18 23:10:29 +00:00
Elliott Hughes
f8b9b91130 Remove scripts that haven't yet been updated for python3.
That seems like a sign none of these are used. (Two of them haven't been
touched since their initial import in 2009!)

Test: treehugger
Change-Id: I76042f6c8fab84669c83aa72cd0b5df13f01ed7c
2022-10-18 21:41:59 +00:00
Treehugger Robot
aa9d4c5145 Merge "[clang-tools] Symlink lib -> lib64 in prebuilts/clang-tools" am: c3f6fcabf1 am: f9907c288d am: afa6ec1de0
Original change: https://android-review.googlesource.com/c/platform/development/+/2260302

Change-Id: I0caf76556d389c20bae5165dca4363a84ee21a73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 20:44:38 +00:00
Treehugger Robot
afa6ec1de0 Merge "[clang-tools] Symlink lib -> lib64 in prebuilts/clang-tools" am: c3f6fcabf1 am: f9907c288d
Original change: https://android-review.googlesource.com/c/platform/development/+/2260302

Change-Id: I34ec4be544b1bdb015cb6202eef0922ae4f40d5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 20:12:26 +00:00
Treehugger Robot
f9907c288d Merge "[clang-tools] Symlink lib -> lib64 in prebuilts/clang-tools" am: c3f6fcabf1
Original change: https://android-review.googlesource.com/c/platform/development/+/2260302

Change-Id: Ie160b7974b14e91129efdf33633c9c19a2be2f19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 19:43:50 +00:00
Treehugger Robot
c3f6fcabf1 Merge "[clang-tools] Symlink lib -> lib64 in prebuilts/clang-tools" 2022-10-18 18:48:28 +00:00
Pirama Arumuga Nainar
59eac68f50 [clang-tools] Symlink lib -> lib64 in prebuilts/clang-tools
Bug: http://b/241011085

Create symlink lib -> lib64 as toolchain libraries have a RUNPATH pointing
to $ORIGIN/../lib instead of lib64

Test: presubmit with new clang-tools prebuilts
Change-Id: I90973fc756b9489a16a0837473b86e728f50d8e0
2022-10-18 16:39:07 +00:00
TreeHugger Robot
1838d44fcd Merge "Add InputWindowInfoProto to proto parsing" 2022-10-18 14:12:07 +00:00
TreeHugger Robot
b125034389 Merge "Add support to PositionProto in ObjectFormatter" 2022-10-18 12:32:47 +00:00
Chih-hung Hsieh
47b7aaf40f Merge "Update clang-tools build to clang-r468909" am: 2a2efc7cf0 am: cbcf998444 am: 7019011fa5
Original change: https://android-review.googlesource.com/c/platform/development/+/2240912

Change-Id: I65c7c2da0dcad682be7688320d0134a871b2c3fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 05:27:04 +00:00
Chih-hung Hsieh
7019011fa5 Merge "Update clang-tools build to clang-r468909" am: 2a2efc7cf0 am: cbcf998444
Original change: https://android-review.googlesource.com/c/platform/development/+/2240912

Change-Id: I87de4853f47f1169e46bb93e89184b6fdda0082f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 04:55:46 +00:00
Chih-hung Hsieh
cbcf998444 Merge "Update clang-tools build to clang-r468909" am: 2a2efc7cf0
Original change: https://android-review.googlesource.com/c/platform/development/+/2240912

Change-Id: I72acd0de1c03581306e65e25d8df5d18dafce4a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-18 04:27:46 +00:00
Chih-hung Hsieh
2a2efc7cf0 Merge "Update clang-tools build to clang-r468909" 2022-10-18 04:02:14 +00:00
Chih-Hung Hsieh
21b04bc844 Update clang-tools build to clang-r468909
Bug: 241011085
Test: presubmit
Change-Id: I969239931c07dd97ce0259a3766ae93d68b21927
2022-10-17 23:45:22 +00:00
Treehugger Robot
ca95a29781 Merge "Fix errorprone warnings that should be errors" am: eb8582344b am: 123b01e28f am: c1cdf7ddf2
Original change: https://android-review.googlesource.com/c/platform/development/+/2254753

Change-Id: I4e6cddbde582684f84f1ef30dea0193985d0336c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 18:00:32 +00:00
Treehugger Robot
c1cdf7ddf2 Merge "Fix errorprone warnings that should be errors" am: eb8582344b am: 123b01e28f
Original change: https://android-review.googlesource.com/c/platform/development/+/2254753

Change-Id: I62c7d3eb948be177c5f211af7654ca006647e4f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 17:06:55 +00:00
Nataniel Borges
e7cd8fc412 Add InputWindowInfoProto to proto parsing
The field is not registered as an IntDef but uses the same values as
LayeoutParams according to code codumentation

Test: npm run test:all && open a layers trace and check if
inputWindowInfo has a value and if the flags are correctly formatted

Change-Id: I868e1b3088cf9925c50faf0decce2da1f584288d
2022-10-17 16:56:59 +00:00
Nataniel Borges
26c8956a45 Add support to PositionProto in ObjectFormatter
Fixes: 254057780
Test: run winscope and open a SF trace
Change-Id: If69e4c135129b9c38f5a461eb73c3a74769f9425
2022-10-17 16:54:18 +00:00
Treehugger Robot
123b01e28f Merge "Fix errorprone warnings that should be errors" am: eb8582344b
Original change: https://android-review.googlesource.com/c/platform/development/+/2254753

Change-Id: I3ab35338f5e066a20adf163ebbff21d4b6cf0172
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-17 16:38:28 +00:00
Treehugger Robot
eb8582344b Merge "Fix errorprone warnings that should be errors" 2022-10-17 16:03:16 +00:00
Kean Mariotti
1fbdd3efaa Add viewer ProtoLog
Fixes: 251159338
Test: npm run build:all && npm run test:all
Change-Id: Ibd6774ed0bf2bc91a5d128eb8258ed4073279166
2022-10-17 10:26:03 +00:00
Kean Mariotti
a59e808275 Merge changes I36bf2d3f,If15a7c81,Ica350d3e
* changes:
  Improve hierarchy component test
  Improve binary search of timestamps
  Update icon
2022-10-17 10:24:43 +00:00
Kean Mariotti
ef2a794a0c Improve hierarchy component test
Test: npm run test:component
Change-Id: I36bf2d3f124a2d373e9ab37eadbe4144765edd02
2022-10-16 16:32:48 +00:00
Kean Mariotti
5638bf799b Improve binary search of timestamps
In case of repeated/equal timestamps, the first occurrence is the search's result.

Test: npm run build:unit && npm run test:unit
Change-Id: If15a7c815c654a3c6ad53c6626b9a89fcb536bff
2022-10-16 16:32:48 +00:00
Cole Faust
a54b856e8d Fix errorprone warnings that should be errors
This commit is part of a large scale change to fix errorprone
errors that have been downgraded to warnings in the android
source tree, so that they can be promoted to errors again.
The full list of changes include the following, but not all
will be present in any one individual commit:

BadAnnotationImplementation
BadShiftAmount
BanJNDI
BoxedPrimitiveEquality
ComparableType
ComplexBooleanConstant
CollectionToArraySafeParameter
ConditionalExpressionNumericPromotion
DangerousLiteralNull
DoubleBraceInitialization
DurationFrom
DurationTemporalUnit
EmptyTopLevelDeclaration
EqualsNull
EqualsReference
FormatString
FromTemporalAccessor
GetClassOnAnnotation
GetClassOnClass
HashtableContains
IdentityBinaryExpression
IdentityHashMapBoxing
InstantTemporalUnit
InvalidTimeZoneID
InvalidZoneId
IsInstanceIncompatibleType
JUnitParameterMethodNotFound
LockOnBoxedPrimitive
MathRoundIntLong
MislabeledAndroidString
MisusedDayOfYear
MissingSuperCall
MisusedWeekYear
ModifyingCollectionWithItself
NoCanIgnoreReturnValueOnClasses
NonRuntimeAnnotation
NullableOnContainingClass
NullTernary
OverridesJavaxInjectableMethod
ParcelableCreator
PeriodFrom
PreconditionsInvalidPlaceholder
ProtoBuilderReturnValueIgnored
ProtoFieldNullComparison
RandomModInteger
RectIntersectReturnValueIgnored
ReturnValueIgnored
SelfAssignment
SelfComparison
SelfEquals
SizeGreaterThanOrEqualsZero
StringBuilderInitWithChar
TreeToString
TryFailThrowable
UnnecessaryCheckNotNull
UnusedCollectionModifiedInPlace
XorPower

See https://errorprone.info/bugpatterns for more
information on the checks.

Bug: 253827323
Test: m RUN_ERROR_PRONE=true javac-check
Change-Id: Ic7e78cc74523ee09c1b4aa9969756f0cfd609e08
2022-10-15 21:33:28 -07:00
Christopher Ferris
8d9db5423d Merge "Remove obsolete script." am: 7fa99882d8 am: 23d53bfa1b am: a7c03dfc90
Original change: https://android-review.googlesource.com/c/platform/development/+/2254765

Change-Id: Ic8293e34af72236bf49eabb589921d71eeac27f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 20:49:11 +00:00
Christopher Ferris
a7c03dfc90 Merge "Remove obsolete script." am: 7fa99882d8 am: 23d53bfa1b
Original change: https://android-review.googlesource.com/c/platform/development/+/2254765

Change-Id: Iba0ca8bdf7a78553e1d083993dc22d8d7bd7f730
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 20:16:48 +00:00
Christopher Ferris
23d53bfa1b Merge "Remove obsolete script." am: 7fa99882d8
Original change: https://android-review.googlesource.com/c/platform/development/+/2254765

Change-Id: I4ceafe8fa1b263122e5c652bc2c12162520279eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 19:47:27 +00:00
Christopher Ferris
7fa99882d8 Merge "Remove obsolete script." 2022-10-14 19:03:38 +00:00
Kean Mariotti
f20b6e475b Update icon
Test: start winscope and admire the new icon
Change-Id: Ica350d3ea8ae6f4db902fe99f6251b11b16c7df7
2022-10-14 11:50:14 +00:00
Kean Mariotti
6b0d540477 Merge "Use flex instead of fixed sizes" 2022-10-14 11:37:53 +00:00
Treehugger Robot
46ec505bf2 Merge "Fix the comparison of opaque types that have multiple definitions" am: 1d2edd2cd2 am: c542fcf2a5 am: 1c934e4906
Original change: https://android-review.googlesource.com/c/platform/development/+/2252362

Change-Id: I218c2c856d3ce6e3f18ae95a8d491168838b66da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 10:54:37 +00:00
Treehugger Robot
1c934e4906 Merge "Fix the comparison of opaque types that have multiple definitions" am: 1d2edd2cd2 am: c542fcf2a5
Original change: https://android-review.googlesource.com/c/platform/development/+/2252362

Change-Id: If8cf0834cf1cb866570bb9552240cfc18e3317bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-14 10:21:49 +00:00