Commit Graph

27255 Commits

Author SHA1 Message Date
Adam Pardyl
d49db4cbfb Fix overlapping timeline indicator
The selected data point indicator on timeline was often hidden behind
other data points. This CL changes its behaviour to ensure it is always
visible.

Test: yarn run dev
Bug:
Change-Id: Ide13e97ac7ab54e20cc6213be2ccdadce3d567a7
Merged-In: Ide13e97ac7ab54e20cc6213be2ccdadce3d567a7
2020-01-27 10:16:31 -08:00
Adam Pardyl
813431292c Support multiple trace files.
This commit allows to view trace for both SurfaceFlinger and
WindowManager at the same time using one timeline.

Test: yarn run dev
Bug:
Change-Id: I11abcf8b6423a03ca9af63e56a7b992958d21175
Merged-In: I11abcf8b6423a03ca9af63e56a7b992958d21175
2020-01-27 10:16:29 -08:00
Robert Delgado
8bd2346edf Improved logic for error detection.
Test: Ran windump, winlayer, surfacedump, surfacelayer, and a txt file
on winscope's autodetect file upload feature.
Change-Id: Ia638bb4fbd9c5ad24ac7c84814205eaa8d429824
Merged-In: Ia638bb4fbd9c5ad24ac7c84814205eaa8d429824
2020-01-27 10:16:25 -08:00
Hsin-Yi Chen
cfeef5f41c Merge "Update the format of module variant dir name" 2020-01-08 01:58:55 +00:00
Haibo Huang
f8514fe646 Merge "Add --lldb to gdbclient.py" 2020-01-07 21:14:10 +00:00
Treehugger Robot
aa2b5e1a70 Merge "Output diff result to stderr" 2020-01-07 11:49:51 +00:00
Yo Chiang
967803932e Output diff result to stderr
compare_images_and_print.sh redirect diff result to stderr, so that the
stdout and stderr log don't get interwined.
Don't `cat` common.csv as it is not very useful and clutters the log.

Test: ./development/vndk/tools/image-diff-tool/compare_images_and_print.sh \
    --check "-t \
    compare_images_test/mainline_system_google_arm64-target_files-6112128 \
    compare_images_test/coral-target_files-6112128 -s SYSTEM -i"

Change-Id: Idf609c43a0d1e488ecb2baca99c8ff98edcf7798
2020-01-07 18:30:46 +08:00
Hsin-Yi Chen
d63e723548 Update the format of module variant dir name
The old suffixes were _core_shared and _vendor.{VER}_shared.
The new suffix is _shared. The new prefix for VNDK is vendor.{VER}_.

Bug: 147254738
Test: ./create_reference_dumps.py
Change-Id: Ieb37c14d5deaab437783c07edf268c1488afa441
2020-01-07 13:36:25 +08:00
Haibo Huang
e194fcecf9 Add --lldb to gdbclient.py
Test: `gdbclient.py --lldb -r /system/bin/toybox` and try `b main` `c`
Test: `/data/local/tmp/arm64-lldb-server gdbserver :5039 /system/bin/toybox` and `gdbclient.py --lldb -p 4909`
Change-Id: If7b6895e9c778cdee3764a4058cf70238bdd6b8a
2020-01-06 14:55:28 -08:00
Treehugger Robot
eaee8a5229 Merge "Move the app to /system_ext" 2019-12-31 00:50:15 +00:00
Jeongik Cha
b7aa057aa1 Move the app to /system_ext
As mentioned in go/partitions-in-r, we plan to forbid hidden API in
product partition.
So this app should be moved to /system_ext because it uses hidden API.
It is not permanent, so they can be moved back to /product due to
needs if there isn't hidden usage anymore.

Bug: 137908189
Test: m
Test: check whether device boots successfully
Change-Id: Id1e897eadea814b780f199fa7f3d683924eb4ab3
2019-12-30 04:42:01 +00:00
Jiyong Park
1bc6c36e3e Merge "Move android_*_stubs_current modules to frameworks/base" 2019-12-23 05:25:18 +00:00
Jiyong Park
d3edb1b2a1 Move android_*_stubs_current modules to frameworks/base
frameworks/base/StubLibraries.bp is the place where the droidstubs and
java_library modules for the API stub libraries are defined.

Bug: N/A
Test: m

Exempt-From-Owner-Approval: cherry-pick from internal

Merged-In: I407d0d939582841ffa651488bf76667ab7ce9c64
(cherry picked from commit f371ec46ec)
Change-Id: I407d0d939582841ffa651488bf76667ab7ce9c64
2019-12-22 17:21:55 +09:00
David Gross
519a9f6d57 Merge "Populate SDK with clang linker (lld) in addition to GNU linker." 2019-12-19 18:21:16 +00:00
David Gross
00be4d0b38 Populate SDK with clang linker (lld) in addition to GNU linker.
Note that clang linker is multi-target whereas GNU linker is
single-target; so while we need multiple GNU linkers (because we
support multiple targets) we only need a single clang linker.

We retain the GNU linkers so that a new SDK is still compatible with
older gradle plugins.

Bug: 142590626
Bug: 144040336

Test: (gLinux) m PRODUCT-sdk_phone_armv7-sdk dist sdk_repo
      (gLinux) m PRODUCT-sdk_phone_armv7-win_sdk dist sdk_repo

Change-Id: I2a04f6fd464b5eb6a2e9a632f49409c1d7e60170
(cherry picked from commit c22ed0eece)
2019-12-18 16:15:59 -08:00
Logan Chien
5ff740f0ed Merge "header-checker: Remove C++ 17 usages" 2019-12-17 05:52:02 +00:00
Treehugger Robot
384d61d947 Merge "Add preserve_extracted_files option in compare_images" 2019-12-17 05:00:30 +00:00
Jeongik Cha
e35e89dd77 Add preserve_extracted_files option in compare_images
With the option: extract zip file in the directory where zip is, and the
extracted files remain.
Without the option: extract zip file in tmp and clean up after a run

Test: check if files remain with -p option
Bug: N/A
Change-Id: I1aa74c017dbb885481b8f5a0674d089c0a732620
2019-12-17 02:03:20 +00:00
Logan Chien
877c9a1457 header-checker: Remove C++ 17 usages
Bug: 139945549
Test: OUT_DIR=out \
      ./development/vndk/tools/header-checker/android/build-prebuilts.sh
Change-Id: Ia98e03e532ca91e52eb6be561ae8082da1c6bcc7
2019-12-16 22:31:33 +00:00
Treehugger Robot
d8055f8cee Merge "Extract zip file in tmp directory" 2019-12-16 07:17:45 +00:00
Treehugger Robot
b2ddb4d536 Merge "header-checker: Encapsulate AbiDiffHelper" 2019-12-12 18:21:04 +00:00
Treehugger Robot
f253fc4007 Merge "header-checker: Remove type_id" 2019-12-12 17:01:36 +00:00
Treehugger Robot
3addde7f6b Merge "[Bug Fix] Not able to create secondary user due to lack of permission" 2019-12-12 02:23:26 +00:00
Weilun Du
aa2ec781e8 [Bug Fix] Not able to create secondary user due to lack of permission
BUG: 145353724

Signed-off-by: Weilun Du <wdu@google.com>
Change-Id: Icce8f6d280b29c4390dcd5947516a06448799862
2019-12-11 09:58:45 -08:00
Jeongik Cha
af646f7981 Extract zip file in tmp directory
As-is: extract zip file in-place
To-be: extract zip file in tmp dir

Test: run the tool with -u option, and check if there is no file in a
directory where zip file is located

Change-Id: I2654bfa257714cb5b266abf4feb31acaabdbb7cb
2019-12-11 21:55:50 +09:00
Chih-hung Hsieh
dd7bba046d Merge changes I22e348b4,Iaa253a43
* changes:
  Add new cargo2android.py owners
  Auto-build/update codegen
2019-12-10 18:47:00 +00:00
Chih-Hung Hsieh
09539599a0 Add new cargo2android.py owners
* add new cargo2android.py owners
* remove obsolete email address

Bug: 142209566
Test: make
Change-Id: I22e348b45c25ccc82e59fdddf1978462ba2a8e49
2019-12-10 09:19:47 -08:00
Chih-Hung Hsieh
2978204d14 Auto-build/update codegen
Exempt-From-Owner-Approval: introduces separate utility; doesn't touch
anything around it
Test: 1. Manually enter version/presence of build artifact,
and ensure `codegen FILENAME` still works
2. run codegen again without altering version, ensure no build triggered
Change-Id: Iaa253a430e627d0e7c25781cde535958f77db97f
(cherry picked from commit 8ca7673cfc)
Merged-In: Iaa253a430e627d0e7c25781cde535958f77db97f
2019-12-10 09:17:42 -08:00
Logan Chien
1f4f441945 Merge "header-checker: Downgrade to C++ 14" 2019-12-10 04:36:33 +00:00
Treehugger Robot
0d957878a4 Merge "[NDK] Add an option to gdbrunner to run lldb" 2019-12-10 02:18:25 +00:00
Logan Chien
e527e061b8 header-checker: Downgrade to C++ 14
This commit switches the option to `-std=c++14` to avoid potential ODR
violations and fix the Mac build.

This commit downgrades from `-std=c++17` to `-std=c++14` because
"llvm/Support/RWMutex.h" from clang-r370808 will use `std::shared_mutex`
when `-std=c++17` is specified but LLVM/Clang prebuilts are built with a
different implementation.

Furthermore, Mac OS X 10.8 (or 10.9) does not support
`std::shared_mutex`.  Thus, there are availability errors when we are
building header-checker for Mac OS X:

    clang-r370808/include/llvm/Support/RWMutex.h:98:8:
    error: 'shared_mutex' is unavailable: introduced in macOS 10.12

Bug: 139945549
Test: OUT_DIR=out && \
      development/vndk/tools/header-checker/android/build-prebuilts.sh

Change-Id: Ic23fbdb67f7cd0700a3001c644485f7d8d0ee3e2
2019-12-09 17:33:21 -08:00
Haibo Huang
a1d5d38249 [NDK] Add an option to gdbrunner to run lldb
Test: Run ndk-gdb on ndkgdbsample app
Change-Id: I29a892565693adec06d48570e92386e775c87e28
2019-12-10 00:45:43 +00:00
Chih-hung Hsieh
45ffc27e13 Merge "A script to run cargo and generate Android.bp." 2019-12-06 21:15:51 +00:00
Logan Chien
a50907a3fe Merge changes from topic "bump-clang-r370808"
* changes:
  clang-tools: upgrade to r370808
  header-checker: Migrate to clang-r370808
2019-12-06 21:01:35 +00:00
Nick Desaulniers
1fd2cdb777 clang-tools: upgrade to r370808
Bug: 139945549
Test: cd $ANDROID_BUILD_TOP && \
 OUT_DIR=out ./development/vndk/tools/header-checker/android/build-prebuilts.sh
Change-Id: I48de2adac9122206c78625988e11f47ce667d9b8
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
2019-12-05 14:42:44 -08:00
Logan Chien
833560bfa2 header-checker: Migrate to clang-r370808
Bug: 139945549
Test: lunch aosp_arm64-userdebug && mm && ./tests/test.py
Change-Id: I348d179f6c63f975e1b2c539264ee903e8a8e11b
2019-12-05 14:42:44 -08:00
Treehugger Robot
331a744770 Merge "Merge Android10 QPR1 into AOSP master" 2019-12-03 23:14:58 +00:00
Xin Li
2cb3b91207 Merge Android10 QPR1 into AOSP master
Bug: 145570283
Change-Id: If27af71b6cadaaceceac1573913889a9ff8d1f20
2019-12-02 21:25:02 -08:00
Chih-Hung Hsieh
e888737544 A script to run cargo and generate Android.bp.
* Usage note and help for command flags in the script.
  * Run cargo -v multiple times and collect output in cargo.out.
  * Use target.tmp as temporary working directory.
  * Generate multiple Android.bp files into subdirectories.
  * Simplified package names, without version number.
* Merged Android.bp modules.
  * Use --device flag to generate both host and device build targets
    in a combined module.
  * Use --tests flag to generate rust_test modules, with auto_gen_config,
    and multiple unit tests merged in one module.
* Generate cc_library_static modules for rust packages that call
  'cc' and 'ar' to build static C/C++ libraries.
  * Use the --vv flag to call cargo with -vv.
* Limitations:
  * Cargo.toml and its build scripts might need fix for Android first.
  * Depending on user given cargo parameters.
* TODOs:
  * Handle multiple crate types in one rustc command line.
  * Smart merge of host and device rust_test modules,
    to handle device tests that depend on dynamic libraries.
  * Handle special Rust packages that use only build scripts
    and C/C++ compilers to generate included files.

Bug: 142209566
Test: In rust project directories: cargo2android.py --run
Change-Id: Id54652b1e0a6e5fc16619cd05f5b057eee79d610
2019-12-02 15:43:04 -08:00
Alexander Smundak
c117e1745b Merge "Build proto_metadata_plugin, needed for proto cross-referencing"
am: 42f7dbcbd1

Change-Id: I6120faf2e382813aa608ae419019bcfef68f1ba8
2019-11-21 13:48:08 -08:00
Alexander Smundak
42f7dbcbd1 Merge "Build proto_metadata_plugin, needed for proto cross-referencing" 2019-11-21 21:38:18 +00:00
Sasha Smundak
97feb26d9c Build proto_metadata_plugin, needed for proto cross-referencing
Bug: 143574580
Test: run it
Change-Id: I7fd7a804f3e91353ceb4121dba8f98ba92908a29
2019-11-19 18:15:27 -08:00
Yo Chiang
9e15fceb00 Merge "Add 'whitelist' option to compare_images"
am: 0cf2d79947

Change-Id: Ib577bd4a7decf56f3863feb65ac10e61d45c9beb
2019-11-18 01:04:57 -08:00
Yo Chiang
0cf2d79947 Merge "Add 'whitelist' option to compare_images" 2019-11-18 07:07:35 +00:00
Enrico Granata
6af21565ac Merge "idegen fails to build a correct dependency graph if one of the submodules it identifies lacks an Android.mk file"
am: 3b16a02c35

Change-Id: I558b4b5379d0671f7ab919e9454256cdde663c04
2019-11-14 19:28:12 -08:00
Treehugger Robot
3b16a02c35 Merge "idegen fails to build a correct dependency graph if one of the submodules it identifies lacks an Android.mk file" 2019-11-15 03:15:41 +00:00
Weilun Du
8810570222 Merge "[SdkSetup] Set physical keyboard layout"
am: c3aecfaf2e

Change-Id: I8ad6436164705d7c18d68706ef2266f46664e829
2019-11-14 18:17:57 -08:00
Weilun Du
c3aecfaf2e Merge "[SdkSetup] Set physical keyboard layout" 2019-11-15 02:07:04 +00:00
Yo Chiang
9039ad4acd Add 'whitelist' option to compare_images
* `compare_images -t a b -s system -w whitelist.txt` to specify
  whitelist.
* diff.csv is split into two parts:
  - whitelisted_diff.csv: Diffs that are ignored by a whitelist
  - diff.csv: Diffs that are not ignored by any whitelist.
* Add `-c, --check` option to compare_images_and_print.sh
  When this option is specified, compare_images_and_print.sh exits with
  a non-zero status if diff.csv contains any unexpected diffs.

Bug: 144398662
Test: Tested manually by creating two directories that contain common
      files, whitelisted diffing files and not whitelisted diffing files.
Test: ./compare_images_and_print.sh --help
Test: ./compare_images_and_print.sh --check "-t a b -s SYSTEM -i"
Change-Id: Ie80741d08ef5bc245b409b46ee716ae783428a7d
2019-11-14 15:49:48 +08:00
Weilun Du
3cac24167f [SdkSetup] Set physical keyboard layout
Emulator host will set the guest keyboard layout with boot
properties based on the host keyboard layout.

Also, fixed complaints in setting properties adb_enabled and
install_non_market_apps.

BUG: 78115103
Merged-In: Iad3750af5383ba27fbf20eb9b26652f037853f1f
Change-Id: Iad3750af5383ba27fbf20eb9b26652f037853f1f
Signed-off-by: Weilun Du <wdu@google.com>
2019-11-12 10:08:09 -08:00