+ ensure displays are sorted to ensure same ordering between SF and WM trace displays
Fixes: 264688936
Test: npm run build:unit && npm run test:unit
Change-Id: If5cbeb1f14545a30da0c0181884ab74132bdde77
Will revert/adapt this change once the new winscope_proxy.py will
be available in AOSP as well.
Bug: b/264573983
Test: open winscope, click on "Download from Code Search"
Change-Id: I2c03c7d295465ef60c4c6c3f61399c90cb7ff1c0
Rectangles with property cornerRadius === 0 could result
in weird triangular shapes being drawn instead of rectangles
Fix: b/264541479
Test: follow steps in b/264541479 and check issue is gone
Change-Id: I2421e47cdbf7c932218640f2553647ded676a80d
Add tslint with google3 config (google3/javascript/typescript/tslint).
Skipped google3 custom rules that need to be built and added to the project.
If needed, with some extra effort it should be possible
to get the google3 rules to build/run also in the Winscope environment.
However, it is probably simpler and quicker to run (and maybe fix?)
those checks on critique once we port Winscope to google3.
Fix: b/264505907
Test: npm run tslint:check / npm run tslint:fix
Change-Id: If3a79de673503e0c06541f0329163dee93849c3c
Handle the case where corner radius > height/2 (or width/2)
Fix: b/264264761
Test: npm run build:all && npm run test:all
Change-Id: I9327189a3b9a59128d9ed3cc885f5887900a952a
The rounded corners property should be 0 on WM traces, instead of null
Fixes: 264024995
Test: open a wm trace and check rects view
Change-Id: I53e6668a8bdaa460e2e740936b719a3a4f813f8c
Add new check based on tool "madge" to prevent cyclic dependencies regressions.
Madge currently reports 10 cycles. The new check makes sure we don't introduce new ones.
Bug: b/261552483
Test: npm run deps_graph:check_cycles
Change-Id: I2630ddcb94101be9b288ce0708fca3231962f406
Unleash prettier on the entire codebase
Fix: b/263471740
Test: npm run format:check && npm run lint:check
Change-Id: Ida110947bec9c9a9b385c64e126ccf6d7ad6652b
- Add npm scripts format:check, format:fix, lint:check, lint:fix
- Include format:check + lint:check into the test suite (test:all)
- Configure eslint to play nice with prettier (basically no format checks)
Test: npm run format:check && npm run lint:check
Bug: b/263471740
Change-Id: I6f215860a24302ed04c2689ac31e4dd4e7e6fd5e
Plus some code clean up
Result: https://screenshot.googleplex.com/BNYzBrQ9SMeiPxU
Test: npm start and open a trace with rounded corners (e.g. quick
switch)
Change-Id: I93c36eaccd440c3420e3bb7fe25d262979dbde5e
- Use OnPush Angular change detection strategy in SF viewer (better perf and avoids change loop errors)
- Hide PropertyGroupsComponent when root layer is selected
- Add formatting for "raw" long numbers
Fix: b/254044321
Test: npm run build:all && npm run test:all
Change-Id: I56274973a8d42c28e49e4a4a92fd6ae09a6693db
npm audit report:
jsonwebtoken <=8.5.1
Severity: high
jsonwebtoken has insecure input validation in jwt.verify function - https://github.com/advisories/GHSA-27h2-hvpr-p74q
jsonwebtoken's insecure implementation of key retrieval function could lead to Forgeable Public/Private Tokens from RSA to HMAC - https://github.com/advisories/GHSA-hjrf-2m68-5959
jsonwebtoken vulnerable to signature validation bypass due to insecure default algorithm in jwt.verify() - https://github.com/advisories/GHSA-qwph-4952-7xr6
jsonwebtoken unrestricted key type could lead to legacy keys usage - https://github.com/advisories/GHSA-8cf7-32gw-wr33
fix available via `npm audit fix --force`
Will install auth0@3.0.1, which is a breaking change
node_modules/jsonwebtoken
auth0 2.13.0 - 3.0.0
Depends on vulnerable versions of jsonwebtoken
Depends on vulnerable versions of jwks-rsa
node_modules/auth0
jwks-rsa 1.5.1 - 1.12.3
Depends on vulnerable versions of jsonwebtoken
node_modules/jwks-rs
Test: npm install && npm run build:all && npm run test:unit
Change-Id: I47dfb353718cd3c40dd7060d2c31cb5e1ebaec43
The RectsComponent and TreeComponent used to rely on the `id` property
instead of `stableId` to identify elements of type Layer/WIndowState.
This created issues in cases where an element doesn't provide an `id`,
e.g. root layer.
Fix: b/263554032
Test: npm run build:all && npm run test:all
Change-Id: If296baa5402b100f67f5326a065ef569aaf2b842
- Search filename of active view (if available) and display it in the toolbar (page top-center)
- Rename TraceViewComponent's event emitters as specified in Angular style guides
Fix: b/258214773
Test: npm run build:all && npm run test:all
Change-Id: I05abb10a9c78ffc8c3208ba081251d068a17a5a7
Now the checkbox shows false/0 values when checked.
Side effect: now transaction trace shows all properties. It should have
a checkbox similar to SF/WM trace to show only the meaningful values
Bug: 254054329
Test: npm run test:unit
Change-Id: I0f88dc3870c8863756a49f9a3698eb4d6d4bed58
